Received: by 2002:a05:6a10:5594:0:0:0:0 with SMTP id ee20csp523690pxb; Mon, 25 Apr 2022 15:32:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfdDlDNYCu+YKYqROEqF1RVdH52MR7jZaYePR5MCOKH7KFRoECvqLHtLkXjekbSJmwH7J+ X-Received: by 2002:a17:903:124a:b0:154:c860:6d52 with SMTP id u10-20020a170903124a00b00154c8606d52mr20323514plh.159.1650925962231; Mon, 25 Apr 2022 15:32:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650925962; cv=none; d=google.com; s=arc-20160816; b=KowOr7qqVEpWky3OwjJOonM34Bd9muS4Rgjkm2IDEclxI4rJZQ4VQLl0WChi0fOl30 Sf3tIUsGfhooLohJ2CkOhL4qgGqdh0kVYJGM3fC3l3A+hbW1jk8UNVtjhextLxHsc1dH S0wL+vYgO/QNypZ9K5DbqL/fSWIlPB/F2mtb24fSAYLV4M3w6XlgOpMoqAxd2VcYIsMx Ms57/eswHDyVqz23BX8nDJiXqo0OneJqzIhPnPDFJYGywxVQWqJEw+Yy4lEp05oU3FDG Bz0fcV5foftoX/DshMGArAaLMyXYq8cY5ZfHrzbImWF3gD4VLUSy/2rPz0n3b+dZylrV Ehtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zeWdts0X6m9V2/VnLwn5mW/GWlrj70BIE54pn8ZTWWI=; b=uaEyCT2KyqazfBtE/9OqNnIlJoZKX90l9YpMeAbJWXwc204FGpHZAp9QQQwZSnMCWS YrmexUJn4cspWa+wuEH9sdoYvpueVQLeez/sehYA8BZUc7KME1AJ6O6Pirt3KAqOwkfP 8RrPMcRMLw0godngTnV1Ft6raKnWkrzqf28h+FG1JHPD4z7zrG1ukrCfdGPUJNGYkwoL 2kp8t9Q4QRkxeV7krgOopQOtjQG6fDEM5suaZM05qxZK0DKFVKKZfd1Kajy8BMDTXgJF Ntz3S/imxWCFtagmv1Nt9ENxDg36UqehV4lZd0kLJNuLDl4V/MWMHA5qKMEj3jD5cyRm R5XA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=ZgCdYYjy; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v5-20020a654605000000b0039e59307c86si18441744pgq.617.2022.04.25.15.32.26; Mon, 25 Apr 2022 15:32:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=ZgCdYYjy; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244042AbiDYR20 (ORCPT + 99 others); Mon, 25 Apr 2022 13:28:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244024AbiDYR2T (ORCPT ); Mon, 25 Apr 2022 13:28:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55B2C41314; Mon, 25 Apr 2022 10:25:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DD580B81928; Mon, 25 Apr 2022 17:25:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD13AC385A4; Mon, 25 Apr 2022 17:25:00 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="ZgCdYYjy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1650907499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zeWdts0X6m9V2/VnLwn5mW/GWlrj70BIE54pn8ZTWWI=; b=ZgCdYYjyecfhJXYgil1H4xLnivPbVaYGH2skIwSmg3BK1qPKXaNGF3WAd4LZELKkYdNbDO R3x0a3HxyYEl9fMLW6Kjy8dXNrYhtY2VU/UKDNhnNlxTZsw7RB2OwUyZJ77JlL3per9yKR Rz6zV78iMisPtC3xR5Ohtx0NJbFyDhA= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 506a2217 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 25 Apr 2022 17:24:59 +0000 (UTC) Date: Mon, 25 Apr 2022 19:24:55 +0200 From: "Jason A. Donenfeld" To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, arnd@arndb.de, Borislav Petkov , x86@kernel.org Subject: Re: [PATCH v6 13/17] x86: use fallback for random_get_entropy() instead of zero Message-ID: References: <20220423212623.1957011-1-Jason@zx2c4.com> <20220423212623.1957011-14-Jason@zx2c4.com> <871qxl2vdw.ffs@tglx> <87ilqx14ed.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87ilqx14ed.ffs@tglx> X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hey Thomas, On Mon, Apr 25, 2022 at 07:03:54PM +0200, Thomas Gleixner wrote: > Bah. Indeed. Misread the patch, but yes, if you are at it to make that > cpu_feature_enabled() then change the config thing to IS_ENABLED() too. Alright, will do for v7. I also just confirmed the !IS_ENABLED() way produces the same code as the #ifndef. Jason