Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 27 Apr 2022 11:14:54 +0800
From:   kernel test robot <lkp@intel.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Cc:     kbuild-all@lists.01.org
Subject: Re: [PATCH] hwrng: cn10k - Enable compile testing
Message-ID: <202204271119.5APX0rdl-lkp@intel.com>
References: <YmEqVLcteYSrDYr6@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YmEqVLcteYSrDYr6@gondor.apana.org.au>
Precedence: bulk

Hi Herbert,

I love your patch! Yet something to improve:

[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on herbert-cryptodev-2.6/master v5.18-rc4 next-20220426]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Herbert-Xu/hwrng-cn10k-Enable-compile-testing/20220421-181432
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git c50c29a806113614098efd8da9fd7b48d605ba45
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220427/202204271119.5APX0rdl-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/c804fd47b3fa542852a8cbd9c76ded8a43d32a90
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Herbert-Xu/hwrng-cn10k-Enable-compile-testing/20220421-181432
        git checkout c804fd47b3fa542852a8cbd9c76ded8a43d32a90
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/char/hw_random/cn10k-rng.c: In function 'check_rng_health':
>> drivers/char/hw_random/cn10k-rng.c:55:18: error: implicit declaration of function 'readq'; did you mean 'readb'? [-Werror=implicit-function-declaration]
      55 |         status = readq(rng->reg_base + RNM_PF_EBG_HEALTH);
         |                  ^~~~~
         |                  readb
   cc1: some warnings being treated as errors


vim +55 drivers/char/hw_random/cn10k-rng.c

38e9791a0209041 Sunil Goutham 2021-12-14  45  
38e9791a0209041 Sunil Goutham 2021-12-14  46  static int check_rng_health(struct cn10k_rng *rng)
38e9791a0209041 Sunil Goutham 2021-12-14  47  {
38e9791a0209041 Sunil Goutham 2021-12-14  48  	u64 status;
38e9791a0209041 Sunil Goutham 2021-12-14  49  	int err;
38e9791a0209041 Sunil Goutham 2021-12-14  50  
38e9791a0209041 Sunil Goutham 2021-12-14  51  	/* Skip checking health */
38e9791a0209041 Sunil Goutham 2021-12-14  52  	if (!rng->reg_base)
38e9791a0209041 Sunil Goutham 2021-12-14  53  		return 0;
38e9791a0209041 Sunil Goutham 2021-12-14  54  
38e9791a0209041 Sunil Goutham 2021-12-14 @55  	status = readq(rng->reg_base + RNM_PF_EBG_HEALTH);
38e9791a0209041 Sunil Goutham 2021-12-14  56  	if (status & BIT_ULL(20)) {
38e9791a0209041 Sunil Goutham 2021-12-14  57  		err = reset_rng_health_state(rng);
38e9791a0209041 Sunil Goutham 2021-12-14  58  		if (err) {
38e9791a0209041 Sunil Goutham 2021-12-14  59  			dev_err(&rng->pdev->dev, "HWRNG: Health test failed (status=%llx)\n",
38e9791a0209041 Sunil Goutham 2021-12-14  60  					status);
38e9791a0209041 Sunil Goutham 2021-12-14  61  			dev_err(&rng->pdev->dev, "HWRNG: error during reset\n");
38e9791a0209041 Sunil Goutham 2021-12-14  62  		}
38e9791a0209041 Sunil Goutham 2021-12-14  63  	}
38e9791a0209041 Sunil Goutham 2021-12-14  64  	return 0;
38e9791a0209041 Sunil Goutham 2021-12-14  65  }
38e9791a0209041 Sunil Goutham 2021-12-14  66  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp