Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1002451iob; Thu, 28 Apr 2022 16:14:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4gMZtSBtQ9EW1SYYeuM4FNmiMgPmZtaCl1TXiv+c+KQof/4mMbOeKteA3tMJyI0aFMK8h X-Received: by 2002:a63:c49:0:b0:3aa:1ad6:2c9f with SMTP id 9-20020a630c49000000b003aa1ad62c9fmr30038693pgm.360.1651187693600; Thu, 28 Apr 2022 16:14:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651187693; cv=none; d=google.com; s=arc-20160816; b=rM6zw+it0taAjpHB/r0Nr8CTeTWW8PvDLuBz5BWF2MfoiXeZGnrBvwIbCl775joYDU uSY+rX2RFjZJzF3yh3B61lECld+j4ehXoPR0CwRvPMthSJBBJxyExMLxMkSWzhrGMEnC oIi0L0XSvYKF5pnZxAfW8wI8oBrGXGnsHj2Dv9ywXwNni+eecYVSWycF+H+tMrrr6UGK gNUete20ybjGifwqWkeV6WPq6bQOrrHBAYYm3Fa7F2LOx0VBErK0UgQ2Bo3Lw9K9gavt RkqYR1+TGtsmf83XbXgdDjdKG1nUmVCLvIW9TramstPzqJ8TuZb6T7FajDg3bC3lDOQ9 STnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=OPXliUFxEjLLsipmDEY+utWLJVUCNRaPtIEfY5xgUjg=; b=Ufrg00llg4Mtry5MSBMgeNkIr1wOJOa08Qcz1BZqQ418dbgMo8Ftu/TsBULtLJ5DEk kuDQc637GvL1u3RnKPzzJIsWB9QoQ2vR4NNHmeV4r1gQq1QfeJ5TMsgGMmQpjQbuZVau UfE6OkgNmhJxFJwXnKFSZKi304+KL0iCcqz3Y8Ch2yUN5zVTnU43IcpS5q0VMTrVW6DZ xzOIA22HluQ4wUGYdC9DiE3CmeDftKuhWf7QM6iiVYHiPEwgBLMeRAfpsuAwodp9da/l QVV3O1lZWaMavcTeCQHUgu2hqjxPaxvuQEvDt7XAfr9KRk6uadjvz0swnE756HQDfmeh PRCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gq24-20020a17090b105800b001cd44cc15d9si5500715pjb.101.2022.04.28.16.14.21; Thu, 28 Apr 2022 16:14:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234884AbiD1RPg (ORCPT + 99 others); Thu, 28 Apr 2022 13:15:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234974AbiD1RPd (ORCPT ); Thu, 28 Apr 2022 13:15:33 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65F335B3FD for ; Thu, 28 Apr 2022 10:12:18 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk7gX-0006Bd-Tu; Thu, 28 Apr 2022 19:12:09 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nk7gX-005nM8-Hi; Thu, 28 Apr 2022 19:12:08 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nk7gV-006FUQ-Bv; Thu, 28 Apr 2022 19:12:07 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Herbert Xu , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 1/2] crypto: atmel-sha204a: Remove useless check Date: Thu, 28 Apr 2022 19:11:45 +0200 Message-Id: <20220428171146.188331-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=754; h=from:subject; bh=5UtBiNq04rrWOgahVSom57KYQrZi//mrUJR010snr00=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBiasrLufiK4i8o/uBVsU7ZNsvsSjVD/ZkdkHl/lmt9 ILJxUxOJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYmrKywAKCRDB/BR4rcrsCcbdB/ 0QBY9tqIC/lwjitWZy37WyxgUBBF/yotPWZ88h1NZqtwnZ73t/jQzVLgY77+rK+mn0Jnjm0oSDh1er bOLMWVHAdb2aY58vR4Vf4/uInMEorDbicVxCfx/QvW0322xxhWCnl6iUuJy7OlEuwVCJQQoU7WuXmO kq7CdDjW5Bifue5ycXFxQJIXj4KbWS5wC4zABirof9mr53OKL52r25+bjB6RJ+PiAbNlTfWzRbpTmc GOmnQc912K+rtew+dPL74LiKMt/xjSwGZR9aMHxwrP05RpuYTKW3sFM3LBMKZZYgXx6eXygRLFVoxd wIKBoQaEefs78d5o6j6Fc7HGgfYXa2 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org kfree(NULL) is a noop, so there is no win in checking a pointer before kfreeing it. Signed-off-by: Uwe Kleine-König --- drivers/crypto/atmel-sha204a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c index c96c14e7dab1..c71fc86eb849 100644 --- a/drivers/crypto/atmel-sha204a.c +++ b/drivers/crypto/atmel-sha204a.c @@ -125,8 +125,7 @@ static int atmel_sha204a_remove(struct i2c_client *client) return -EBUSY; } - if (i2c_priv->hwrng.priv) - kfree((void *)i2c_priv->hwrng.priv); + kfree((void *)i2c_priv->hwrng.priv); return 0; } base-commit: 3123109284176b1532874591f7c81f3837bbdc17 -- 2.35.1