Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1318375iob; Fri, 29 Apr 2022 02:46:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwwINaso+e1PxZODXcsTYHxnPszbZcFko76w5HPp/kMk33IYA684blkqyVmSKncNnE+PhF X-Received: by 2002:a2e:a289:0:b0:24d:baf2:aafe with SMTP id k9-20020a2ea289000000b0024dbaf2aafemr24633276lja.113.1651225607035; Fri, 29 Apr 2022 02:46:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651225607; cv=none; d=google.com; s=arc-20160816; b=vF078e0hBwqvJgZsbyEddjPPIX09I6nwHwhaMkBMj2l8WWu6ZLB3Ad1QFutX4GMVFh TVyQL5B8baSfZ4qclmlcIrG6fhMpoXmj23lVq+FZMhvknecDkZxarGZ9Oqx6RBUx6KY4 zwPUjG4u5c5ccVCzT9QXMnMjiqGNP7EVVpcBZr2xah9MMWnpzfN6KHoyRK0qu2VWWMSE YFKQ+d5Fd2srjwKBDSk2soEnBSUbJiIw+/n4qarsMhVqRFJMOUkv9GozY2Yg45h62ts8 j7VVRCRye8dQBX1xY7cJUkt8CdfT85e83eIa11cS1Y5TPrxF2IC2TEU80ZtZ8TbiOEz6 y65A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=RLBVY+PdEneAv+KshvL85RShU6TAsv0aXYYCJ3hs9TU=; b=PlXVKreVQ1jRWJVsMOdlHvYWn3JQIxdpV/09joq5tZBuHb4+KMC7lRmeCT7oXP5fYT xAKFi80o9O0XQo0dyLjH/0q5rAkSUZF27UDSkUm9/Y7dZWEkbroGaaudDKs/+tHnw8H+ 2E9XTTu5S1CWRZhqnY9k93vKY6zoWk0ndpGwDiThfGkMBodtAKwgBT8wWBjRqKr0gcNo kr1a8xsW3S8HBoQiWNl39RGzu5bd9UMS6XUPIPrsQPxajcrYSDimlGwYGgxA/bfkYfiz ThPBaPnQP5kFnQC1ChnMRqCin2Z7Ps8cLSGSO3LGHbXnvyAKe1L/ad95tsztH1Ufuz4T 8k4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g2-20020a19e042000000b0046bc3aa102asi6505711lfj.301.2022.04.29.02.46.18; Fri, 29 Apr 2022 02:46:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345541AbiD2FyZ (ORCPT + 99 others); Fri, 29 Apr 2022 01:54:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243441AbiD2FyZ (ORCPT ); Fri, 29 Apr 2022 01:54:25 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 327D5B82C6; Thu, 28 Apr 2022 22:51:08 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1nkJWp-008984-TB; Fri, 29 Apr 2022 15:50:57 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 29 Apr 2022 13:50:56 +0800 Date: Fri, 29 Apr 2022 13:50:56 +0800 From: Herbert Xu To: Colin Ian King Cc: Sumit Garg , Matt Mackall , op-tee@lists.trustedfirmware.org, linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwrng: optee-rng: remove redundant initialization to variable rng_size Message-ID: References: <20220424181156.1364446-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220424181156.1364446-1-colin.i.king@gmail.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Apr 24, 2022 at 07:11:56PM +0100, Colin Ian King wrote: > Variable rng_size is being initialized with a value that is never read, > the variable is being re-assigned later on. The initialization is > redundant and can be removed. > > Cleans up cppcheck warning: > Variable 'rng_size' is assigned a value that is never used. > > Signed-off-by: Colin Ian King > --- > drivers/char/hw_random/optee-rng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt