Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5de198b9-7488-13e4-bf22-6c58c1c8b401@I-love.SAKURA.ne.jp>
Date:   Fri, 29 Apr 2022 15:26:07 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] crypto: atmel - Avoid flush_scheduled_work() usage
Content-Language: en-US
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Tudor Ambarus <tudor.ambarus@microchip.com>,
        "David S. Miller" <davem@davemloft.net>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        linux-crypto@vger.kernel.org
References: <35da6cb2-910f-f892-b27a-4a8bac9fd1b1@I-love.SAKURA.ne.jp>
 <Ymt4BfQXbXkY2qo0@gondor.apana.org.au>
From:   Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
In-Reply-To: <Ymt4BfQXbXkY2qo0@gondor.apana.org.au>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/04/29 14:30, Herbert Xu wrote:
> On Wed, Apr 20, 2022 at 10:27:11AM +0900, Tetsuo Handa wrote:
>>
>> +module_init(atmel_i2c_init);
>> +module_exit(atmel_i2c_exit);
> 
> What if everything is built-in? Shouldn't this be moved to a place
> earlier than module_init?

Since drivers/crypto/Makefile has lines in

obj-$(CONFIG_CRYPTO_DEV_ATMEL_I2C) += atmel-i2c.o
obj-$(CONFIG_CRYPTO_DEV_ATMEL_ECC) += atmel-ecc.o
obj-$(CONFIG_CRYPTO_DEV_ATMEL_SHA204A) += atmel-sha204a.o

order (which will be used as link order for built-in.o), module_init()
is processed in this order. Also, module_exit() is no-op if built-in.
Therefore, I think there is no need to explicitly boost the priority
of atmel_i2c_init().