Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 29 Apr 2022 16:44:44 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc:     Tudor Ambarus <tudor.ambarus@microchip.com>,
        "David S. Miller" <davem@davemloft.net>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: atmel - Avoid flush_scheduled_work() usage
Message-ID: <YmulfBqsSON47lDR@gondor.apana.org.au>
References: <35da6cb2-910f-f892-b27a-4a8bac9fd1b1@I-love.SAKURA.ne.jp>
 <Ymt4BfQXbXkY2qo0@gondor.apana.org.au>
 <5de198b9-7488-13e4-bf22-6c58c1c8b401@I-love.SAKURA.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5de198b9-7488-13e4-bf22-6c58c1c8b401@I-love.SAKURA.ne.jp>
Precedence: bulk

On Fri, Apr 29, 2022 at 03:26:07PM +0900, Tetsuo Handa wrote:
>
> Since drivers/crypto/Makefile has lines in
> 
> obj-$(CONFIG_CRYPTO_DEV_ATMEL_I2C) += atmel-i2c.o
> obj-$(CONFIG_CRYPTO_DEV_ATMEL_ECC) += atmel-ecc.o
> obj-$(CONFIG_CRYPTO_DEV_ATMEL_SHA204A) += atmel-sha204a.o
> 
> order (which will be used as link order for built-in.o), module_init()
> is processed in this order. Also, module_exit() is no-op if built-in.
> Therefore, I think there is no need to explicitly boost the priority
> of atmel_i2c_init().

If we're going to rely on the Makefile ordering please make it
explicit and add a comment in the Makefile.  Otherwise this is way
too fragile.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt