Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 2 May 2022 11:08:22 -0700
From:   Eric Biggers <ebiggers@kernel.org>
To:     Nathan Huckleberry <nhuck@google.com>
Cc:     linux-crypto@vger.kernel.org,
        linux-fscrypt.vger.kernel.org@google.com,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        linux-arm-kernel@lists.infradead.org,
        Paul Crowley <paulcrowley@google.com>,
        Sami Tolvanen <samitolvanen@google.com>,
        Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v5 6/8] crypto: x86/polyval: Add PCLMULQDQ accelerated
 implementation of POLYVAL
Message-ID: <YnAeFluc6G7hJ1pT@sol.localdomain>
References: <20220427003759.1115361-1-nhuck@google.com>
 <20220427003759.1115361-7-nhuck@google.com>
 <Ym7w47ngugGohQE/@sol.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ym7w47ngugGohQE/@sol.localdomain>
Precedence: bulk

On Sun, May 01, 2022 at 01:43:23PM -0700, Eric Biggers wrote:
> > diff --git a/include/crypto/polyval.h b/include/crypto/polyval.h
> > index b14c38aa9166..bf64fb6c665f 100644
> > --- a/include/crypto/polyval.h
> > +++ b/include/crypto/polyval.h
> > @@ -8,10 +8,19 @@
> >  #ifndef _CRYPTO_POLYVAL_H
> >  #define _CRYPTO_POLYVAL_H
> >  
> > +#include <crypto/gf128mul.h>
> 
> <crypto/gf128mul.h> doesn't appear to be needed here.
> 

It looks like the issue is that this patch removes <crypto/gf128mul.h> from
crypto/polyval-generic.c.  If you just don't do that, then it won't be needed
here.

- Eric