Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1050980iob; Fri, 13 May 2022 21:08:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZq6tkmQW2uHvLr1Rp95emd8pnP4SZEQD5bOd6lzPG3UwhV3US5epFQaa7ppIfLVZXiJPr X-Received: by 2002:a05:6000:188f:b0:20c:5a1c:b7c with SMTP id a15-20020a056000188f00b0020c5a1c0b7cmr6298472wri.65.1652501338841; Fri, 13 May 2022 21:08:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652501338; cv=none; d=google.com; s=arc-20160816; b=l1b7XoWQx58IRz3tLDewRpLdQzRqtxFoo7heG229r/ch/Cl97mbtBhvB8Yzi3UHLsQ wtK2u/9lAxDPiKY/QlGac/CoVzNlzAuP6EpuPbcXb6ORTD/4X0A8ReAEti/E19IIWHjN U192446lrU8Or4WvIVCyWLkOQjJaqczs66fRpl3WRzh647+wTRVK7QJWUTaMHdZxTZc7 LhiH3AauSkgUnOIrTVSGbm7V6jFR/gLdosbv8USE5q/8guFA2eS8zaVZan0tRmZi/iPZ twBigmNAbEEghmL3cW952P96B8mvlWko3M6TReSpNSLdHJeYDyE+YA0inRatNq6ZE7Nk rfDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zZ6BudfxP76D6plnuX/SQddqB1tD+iQ/1Sw2mOoHt7Q=; b=UR3natixuHAe91yPur/IDdnCfTr/sIrjIONGFg1DYoCqRLd3h6OeVHUkGXUahLpFwk R66LwRGcSn+KhvmX/DEdJrVExQmK6/8W6l6DDQ+ROzhdvHIjMYA08laSn2gn7ThtJxzF q+3/T9+jn2Rj55imjnH5k/2ZF5aeLEx+gnUnsMixnkVTAflljvMKiBpPdkfw8vSokElf tEXZTqS9kUIFoNvGMypTMEbRMUX++lxx/N0E3+NlIahpX3ewInhz55YKVpUpiKfygY6n khKIs44lAKtbbIgY4uo+5ekNK5LQcR/Al89L30aaGmrpjSU/GP+jW8G2PyvDcMf8Y0aO tCuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=bHDhDcUv; spf=softfail (google.com: domain of transitioning linux-crypto-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j15-20020a05600c190f00b00394804fecfbsi5256597wmq.169.2022.05.13.21.08.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 21:08:58 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-crypto-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=bHDhDcUv; spf=softfail (google.com: domain of transitioning linux-crypto-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B86F24CAB24; Fri, 13 May 2022 17:40:34 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230039AbiEMKNz (ORCPT + 99 others); Fri, 13 May 2022 06:13:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229822AbiEMKNy (ORCPT ); Fri, 13 May 2022 06:13:54 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11B8F72E28; Fri, 13 May 2022 03:13:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BC3DDB82C43; Fri, 13 May 2022 10:13:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00980C34100; Fri, 13 May 2022 10:13:50 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="bHDhDcUv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1652436829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zZ6BudfxP76D6plnuX/SQddqB1tD+iQ/1Sw2mOoHt7Q=; b=bHDhDcUvUqsDaev+SziIU0FvvNWTLWVEz+ZGeCiBp+5hV89f/RSmaOtsj0881Dv17mpO/P Kuf8N/iQPqFJs4ONZIfnZEWZImWZrJ4vG8lz9Pc90Qe3J6tRkzacgMD0iAKDcApQc5EHGu UDztwNZ9dlC6P7k/AOhbbOAykkvvFQg= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id d28befee (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 13 May 2022 10:13:49 +0000 (UTC) Date: Fri, 13 May 2022 12:13:47 +0200 From: "Jason A. Donenfeld" To: Dominik Brodowski Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH] random: credit architectural init the exact amount Message-ID: References: <20220512133835.102028-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Dominik, On Fri, May 13, 2022 at 08:18:30AM +0200, Dominik Brodowski wrote: > > - bool arch_init = true; > > + unsigned int i, arch_init; > > Maybe s/arch_init/arch_init_cnt/g to clarify that this is now used as a > counter? Good idea. I'll call it arch_bytes, which will make the `* 8` lower down more obviously doing bytes->bits. Jason