Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Gaurav Jain <gaurav.jain@nxp.com>
To:     Steffen Trumtrar <s.trumtrar@pengutronix.de>,
        Jakub Kicinski <kuba@kernel.org>
CC:     Marc Kleine-Budde <mkl@pengutronix.de>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        Horia Geanta <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Jens Axboe <axboe@kernel.dk>,
        Pavel Begunkov <asml.silence@gmail.com>,
        Boris Pismenny <borisp@nvidia.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [EXT] Re: [BUG] Layerscape CAAM+kTLS+io_uring
Thread-Topic: [EXT] Re: [BUG] Layerscape CAAM+kTLS+io_uring
Thread-Index: AQHYYLVEoVF2rOzAV0qB47N0wrw+pK0Q+dUAgBBd9oCAAVSNoA==
Date:   Tue, 17 May 2022 06:30:32 +0000
Message-ID: <VI1PR04MB5342B4B4BC56387BB1193997E7CE9@VI1PR04MB5342.eurprd04.prod.outlook.com>
References: <878rrqrgaj.fsf@pengutronix.de>
 <20220505192046.hczmzg7k6tz2rjv3@pengutronix.de>
 <20220505171000.48a9155b@kernel.org> <87sfp9vlig.fsf@pengutronix.de>
In-Reply-To: <87sfp9vlig.fsf@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F5v5wzqfehGxM6+QhKtUjIYFXDFjhNpvRK+fUTnU1gF/A3rSXt2Rxm6+C8Na?=
 =?us-ascii?Q?SvP3A57H9CLRuEjMGcl9dOUguHGXo/F3BpNO5c1CDYJuUZv1GmJrIPJlJXHX?=
 =?us-ascii?Q?p4j1RJ709S2eJ1dZMFoS5sqtc1MjmfhzYE1LnMhD0ziZkkwOfmEmrAf4/sOJ?=
 =?us-ascii?Q?NBJCp9OeQq4/4+0CCvs4S3Bqgppxq3LkGTl624R/0aKDnrnU1xqbDCDzV/2R?=
 =?us-ascii?Q?v5X67HeLM8MIi1y0eUqSNteJuicgh2yVLQjLNZd3V9UmYYWQ64R3v2R9zWyK?=
 =?us-ascii?Q?2NYnPkgzsTOiO8IekCY7CY0pqiglJUf5575+hZYRLCJHGhVA2YAuAsY8DKMc?=
 =?us-ascii?Q?JIZoDdQuBglacE2cY5eZFE6biyc/wusFUKwasWCRXako+1NIMqWK0Sz05eQk?=
 =?us-ascii?Q?mftNAh1HZhXvThereegweS3wONfv1LKavexJKqOazlFmdAE2EaALwoPsL1s6?=
 =?us-ascii?Q?swE/xf+aIlidaTxxYYbfwnqcgNKWPjHxeeyWWdZTeA6zIsG7kWnRsX7LK231?=
 =?us-ascii?Q?7BWpIoC03BZhTrMB0mxM/utHcJ7L9zoPGx7YJzWgbdrTKgr8JGc0WqDfXSTs?=
 =?us-ascii?Q?QfGR0ZDU5l1kM5vD76pZOSekWAueo82oaJVbiOud1M0ba0rNDmsKFkaDYoay?=
 =?us-ascii?Q?Aq/no8x83L8BPGHEuOC1xqpgQ1OLSl613vUPlJVjsmHlER2GQbq5pXWxCoHB?=
 =?us-ascii?Q?v9F24WaImvfx4ixSlWAax5Q+gmBexIfGXLHmQcm7OiPNjWzRbkr9kFfAuIHe?=
 =?us-ascii?Q?vk7l3BSFkb9ebKAJWwBtEffv8yRvCxN3SDJpXApRr0Frge2uiyyBSUQSta1u?=
 =?us-ascii?Q?/sFyBXurOCYKRzQDG5+kU5rDnhfYVdMj/vOthhhujLAN7fRZ995FU3Apgp4h?=
 =?us-ascii?Q?NqoxqYcpyCW5Hl6FuSUrHVxz+4NT8s1Dn3Vu27L5QRDWvyxT5hCALba79IHp?=
 =?us-ascii?Q?/B4W9B/i4fYsD0pHiE47+geNpitJxgWW7Ed2T3Kbq1vUO7tTosAheq7ty4Ni?=
 =?us-ascii?Q?blFP1wgmieemhp+quRA3tnL7Szfyen5TmD+y69guUiUOF/LrqQuEpL8+oZoX?=
 =?us-ascii?Q?DEs3pj1bDoKcV0nwiDbNSXPU0DNu40FOiBedvaRJ/kgYkFR4/tC+cihG5MnP?=
 =?us-ascii?Q?bpMny1mdnm8rae/kQIaLWuOmkFbmY3My9SqhZ+O1tDMFqqUO2ORdx+A7S9lK?=
 =?us-ascii?Q?cfHrADjjztge+M+B7+znvJvugseKQZZIdjm5Imv3BJN3E8oVo7Lixv9EGu1q?=
 =?us-ascii?Q?z6xe4bjJZS1zZ1rUqjvss0DaMJFCvvcpz/8dPfUQxKMRvZ1Zk1hzuRawSbjS?=
 =?us-ascii?Q?Ovhkm4Mms1RMYE//s/sTXW3TE0Jg+41xe6QM/RJnbAUUceAQH4J4l4PBF31p?=
 =?us-ascii?Q?AZpFiXvLD3Sxr+pvk2MFsiQ2TaSwrtYAsEbqz9vhZS1y+Ng5gHmY1AdA/zw4?=
 =?us-ascii?Q?qarnyjEGZJE/EpbBxicnWerRJwHtE1f1wJhe0XDwQVUQslrW7V656BukF0Yo?=
 =?us-ascii?Q?jeA2PR/aSABhv1q5pPv8yLHPsScLHZbQE6RfdL9MqwLwvbnERrnPhuv5yGRW?=
 =?us-ascii?Q?rUX0Yat6L3JpQZvG2uKfc7eQ4qkS0uhxHTwFTNIJXwH6RJrvvZ4z9WMsp7z8?=
 =?us-ascii?Q?Yfcf+nPrbx79B1Bk7Na/stILost9p0rZwcs7bat4w6wwFegXkWs7g7V1V/OU?=
 =?us-ascii?Q?VHXJvNwZJCsmXpkPsKrLg1k9GgccFLIv38ipcBIkFokwWr2zMGjY93vc+MFn?=
 =?us-ascii?Q?dHzmhwz1pg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5342.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e94d507-66e0-4ea1-15b6-08da37cebe4d
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 06:30:32.1235
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: O43eisyiGgUQTvZpt4oBl+Mca0/QNJPKp5kP9HLHctUBNki+V0V3iCTTRehPCOOG0J5Xt6sxBGmC1fapNWPZbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5659
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hello Steffen

> -----Original Message-----
> From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Sent: Monday, May 16, 2022 3:36 PM
> To: Jakub Kicinski <kuba@kernel.org>
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>; linux-crypto@vger.kernel.org;
> io-uring@vger.kernel.org; kernel@pengutronix.de; Horia Geanta
> <horia.geanta@nxp.com>; Pankaj Gupta <pankaj.gupta@nxp.com>; Gaurav Jain
> <gaurav.jain@nxp.com>; Jens Axboe <axboe@kernel.dk>; Pavel Begunkov
> <asml.silence@gmail.com>; Boris Pismenny <borisp@nvidia.com>; John
> Fastabend <john.fastabend@gmail.com>; Daniel Borkmann
> <daniel@iogearbox.net>; netdev@vger.kernel.org
> Subject: [EXT] Re: [BUG] Layerscape CAAM+kTLS+io_uring
>=20
> Caution: EXT Email
>=20
> Jakub Kicinski <kuba@kernel.org> writes:
>=20
> > On Thu, 5 May 2022 21:20:46 +0200 Marc Kleine-Budde wrote:
> >> Hello,
> >>
> >> no one seems to care about this problem. :/
> >>
> >> Maybe too many components are involved, I'm the respective
> >> maintainers on Cc.
> >>
> >> Cc +=3D the CAAM maintainers
> >> Cc +=3D the io_uring maintainers
> >> Cc +=3D the kTLS maintainers
> >>
> >> On 27.04.2022 10:20:40, Steffen Trumtrar wrote:
> >> > Hi all,
> >> >
> >> > I have a Layerscape-1046a based board where I'm trying to use a
> >> > combination of liburing (v2.0) with splice, kTLS and CAAM (kernel
> >> > v5.17). The problem I see is that on shutdown the last bytes are
> >> > missing. It looks like io_uring is not waiting for all completions
> >> > from the CAAM driver.
> >> >
> >> > With ARM-ASM instead of the CAAM, the setup works fine.
> >>
> >> What's the difference between the CAAM and ARM-ASM crypto? Without
> >> looking into the code I think the CAAM is asynchron while ARM-ASM is
> >> synchron. Is this worth investigating?
> >
> > Sounds like
> > 20ffc7adf53a ("net/tls: missing received data after fast remote
> > close")
>=20
> That fixes something in tls_sw. I have a kernel that includes this patch.=
 So this
> sounds right, but can't be it, right?
>=20
To understand more on problem, can you share how you are offloading ktls to=
 CAAM?

Gaurav
>=20
> Best regards,
> Steffen
>=20
> --
> Pengutronix e.K.                | Dipl.-Inform. Steffen Trumtrar |
> Steuerwalder Str. 21            |
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fwww.p=
e
> ngutronix.de%2F&amp;data=3D05%7C01%7Cgaurav.jain%40nxp.com%7Cc225fa4
> 3da7f4a43f16b08da3723dc4a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%
> 7C0%7C637882924400875890%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C
> %7C&amp;sdata=3DfI1BHNZIT5RlpjEdEMXVkv1WaHcvgTlZOcaC0LRojac%3D&amp;
> reserved=3D0    |
> 31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
> Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |