Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 18 May 2022 20:33:44 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Corentin Labbe <clabbe.montjoie@gmail.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        linux-crypto@vger.kernel.org, linux-sunxi@lists.linux.dev,
        kernel-janitors@vger.kernel.org
Subject: [PATCH] crypto: sun8i-ss - fix error codes in allocate_flows()
Message-ID: <YoUt+LNsM8qFZYgL@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CwVFrQab4O5OSZCo26SNYS+a1C8nK6DzDPQO8JZr2C7NkvH3PjHbLXl/1y4x?=
 =?us-ascii?Q?Q1S7VRW9IoB2mI/UZ87mT+ayAVehIsRNSsPgwuDopBQ4BjxA3KoqR4+wFr3b?=
 =?us-ascii?Q?0o3Sbv+sTH3HAaMPRzGKwGlEktR/C9aouodR8Myf5FnrjHpbMNsW/+gL4FKg?=
 =?us-ascii?Q?YL/qVEkmT4LPdRkivxwSGEP0/x6+HgEYqNmnqhQ8+82jE6WQSUvRhQMjXTsw?=
 =?us-ascii?Q?aDNppGEqTjea9gWn4TWC1w3OQSXVZUo1VPdpyCEfPAcwGGQE7C/1NYL4OJZE?=
 =?us-ascii?Q?x8QPOyZE7QUjNWrvrVfEtYICnyPP+3I6Ap4zYvY9SscjS+34pb8kTV6v4+jZ?=
 =?us-ascii?Q?J32kRX5rFaB4y6BN15DyHmLKlb0zq066YNAtAM2nvoB4wddsS6Xcvns/wP8O?=
 =?us-ascii?Q?9LAiFKf42vRuXbTF4UB4ae859ez611c6HDfrBGRQ83NZk23TreJAwa1aYbNq?=
 =?us-ascii?Q?usvBBXkV088QnyFVMkeUJmQUA6kJIa7oKjl/2osNBCtZdhhW6qz1dB+yK8Qt?=
 =?us-ascii?Q?2Ds5hQHatoq1rBEp/gtHzblpFpOSfOdYmf+CjUiS7TmyBvhfoznqstzGiIMD?=
 =?us-ascii?Q?8A8mTwcbC0BvDQc1eqrKlgQ8Ph/J+YgBhj/DTvlMRhJeCyI04Av+ss4OP4ci?=
 =?us-ascii?Q?iCADw6/o6J+JoC5k26kJvRT6+FKyCrqWZ+U/dsA2nbSkqCiXm4F762WgmQvH?=
 =?us-ascii?Q?HM62EaZ+DP6/nX9YkXmp66CtIylwrv4aTMbWjJVDutXYo8v0kaI8F8/ElwM9?=
 =?us-ascii?Q?XooNjMWgS2qbg4BL8w8i8Jrh92PnZVwa+Cflsh8H88IBELKPb5uyRYav573k?=
 =?us-ascii?Q?AhMINdrF9BVl2NEM50gSXqVKFAiZnoHctiXcX0oHNjZmZxeGKB3HZYtCTLD4?=
 =?us-ascii?Q?6fYWhSqLJFFEm+d4+1JZSACDbzqSoLJ4HgoQDDh3ebVfVMvBnUcIfuF9PGdO?=
 =?us-ascii?Q?gdDnfZRNCA4urBzvmGT/ZRGhGSIrE5qDDvBdHiFvbw0Zk4cFuwO8vP4iy6/v?=
 =?us-ascii?Q?ESrSqHi4vUJZrUj57P8O9XppxMBXVKzggPo+2ANXDqWu1nUnKX93SSfGOMft?=
 =?us-ascii?Q?1+2LZiC7JDYNyzAfLQ3HNZd+TrRWnFzykBfgJ48wO5BeSSOamkkKJRGsq+ot?=
 =?us-ascii?Q?VNnASA21DLZfhqe/CuKAfOF6zFUKQUrMPu4jMxvICrKufd6Eb9M1A9OYl5fm?=
 =?us-ascii?Q?bX70qQVN2nEOgK4AtTRJ6RWn5K9lJSKYE2npY2+PaFcPCCZh6qHxC2xM5pQ6?=
 =?us-ascii?Q?ryQqn6yHtkiHhyUNA5dFtBdazw0vZFEzmjegk9pICL5tTKuQvLBBCxqjt23c?=
 =?us-ascii?Q?H0Ienec0nj+VywbmhHt2dC10hRf8REPhf9SXGIYjL4brgjtRznk8oINpaTQM?=
 =?us-ascii?Q?QXemUjVpJS9leCtbb9rM+uygQCadVRBiJ3Hn4CocxNa1VuC5D2FDOz6v0enF?=
 =?us-ascii?Q?DZ1RQIVl+cAeugz0HeLmLlZavYk7Mbf+V6CjNbe0NKSPQkcK+NzEBrs7pblm?=
 =?us-ascii?Q?R9kDjrLhNFemH4aA99FNJ7DPxSB4HybI9TfGktPKiyerHQF6Ss5stM30nEt0?=
 =?us-ascii?Q?h4UoyZwWtuuNG4A0qXV/di7JmecCA/Ptg3OCicSKaDBKoa4cXMmKcjS8g+g2?=
 =?us-ascii?Q?HV1bJEwo558lOQ/aVRbOXYsNqdAPbDJuRmSQCkWpeN4nbHbTcavb6D2UQB2i?=
 =?us-ascii?Q?7xRZmIZjxuoIYybij8DdDLCCdaC9eNV1Ffk5BZVTjgP8YKCyhZIHECRKqo8p?=
 =?us-ascii?Q?XjR3T6Hc2ZenR+xHYE2ppfdnyhwhP5w=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3f5ad2e-0f1a-41ad-da4a-08da38f4952e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 17:33:55.5522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RfoZMw/1/LQLBrk6Q9VtnV/sx//AuY3kSydxeXm3mVifYWXrUvW/eTkFMM5so3wcDniYgyCxDQhCz/wtuAoz7mC9IDHo2edfk7IE+dh07Oc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5642
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-18_06:2022-05-17,2022-05-18 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0
 suspectscore=0 mlxlogscore=999 adultscore=0 phishscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205180104
X-Proofpoint-GUID: IqyTXUp8Wg0TgqwikoqwQGeE0ap8ZakT
X-Proofpoint-ORIG-GUID: IqyTXUp8Wg0TgqwikoqwQGeE0ap8ZakT
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

These failure paths should return -ENOMEM.  Currently they return
success.

Fixes: 359e893e8af4 ("crypto: sun8i-ss - rework handling of IV")
Fixes: 8eec4563f152 ("crypto: sun8i-ss - do not allocate memory when handling hash requests")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 .../crypto/allwinner/sun8i-ss/sun8i-ss-core.c    | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
index 98593a0cff69..ac2329e2b0e5 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
@@ -528,25 +528,33 @@ static int allocate_flows(struct sun8i_ss_dev *ss)
 
 		ss->flows[i].biv = devm_kmalloc(ss->dev, AES_BLOCK_SIZE,
 						GFP_KERNEL | GFP_DMA);
-		if (!ss->flows[i].biv)
+		if (!ss->flows[i].biv) {
+			err = -ENOMEM;
 			goto error_engine;
+		}
 
 		for (j = 0; j < MAX_SG; j++) {
 			ss->flows[i].iv[j] = devm_kmalloc(ss->dev, AES_BLOCK_SIZE,
 							  GFP_KERNEL | GFP_DMA);
-			if (!ss->flows[i].iv[j])
+			if (!ss->flows[i].iv[j]) {
+				err = -ENOMEM;
 				goto error_engine;
+			}
 		}
 
 		/* the padding could be up to two block. */
 		ss->flows[i].pad = devm_kmalloc(ss->dev, MAX_PAD_SIZE,
 						GFP_KERNEL | GFP_DMA);
-		if (!ss->flows[i].pad)
+		if (!ss->flows[i].pad) {
+			err = -ENOMEM;
 			goto error_engine;
+		}
 		ss->flows[i].result = devm_kmalloc(ss->dev, SHA256_DIGEST_SIZE,
 						   GFP_KERNEL | GFP_DMA);
-		if (!ss->flows[i].result)
+		if (!ss->flows[i].result) {
+			err = -ENOMEM;
 			goto error_engine;
+		}
 
 		ss->flows[i].engine = crypto_engine_alloc_init(ss->dev, true);
 		if (!ss->flows[i].engine) {
-- 
2.35.1