Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 18 May 2022 20:33:54 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Corentin Labbe <clabbe.montjoie@gmail.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        linux-crypto@vger.kernel.org, linux-sunxi@lists.linux.dev,
        kernel-janitors@vger.kernel.org
Subject: [PATCH] crypto: sun8i-ss - Fix error codes for dma_mapping_error()
Message-ID: <YoUuAsJndw7aLn+S@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?drVtAOG5va9cTJyOZjQng6/zU8r0YvFrlq/QIyU3d/M2uYePlFXxVpvyFNc/?=
 =?us-ascii?Q?GmX+YNwQtQSoDVp4jBV4qf0H6nmu4wJ9iekzF02FWbtpD58z56wA7LurMZnG?=
 =?us-ascii?Q?xl51154SaVLRrMx83vi74JK4uTAr9agbwpmUs5IK6yHWFA+YbpMoFQz5SiJd?=
 =?us-ascii?Q?J90wkTpzhIGCqAc8O3JKrUNsiMKpDwK9icqskIktxc97Rbp57i/5uiPmMLmz?=
 =?us-ascii?Q?TgAVZPXFDYEuExtxlaZr4r2oChsq/RJ1pesW795WVjX5MzX92AnRzj5+SQA7?=
 =?us-ascii?Q?85B00aA9ovCG3QF9lzdAEKAZhSSg+fWc/OUvsVd39rBCdkFIPbR+en1e2igB?=
 =?us-ascii?Q?X9MGHcH9RFE30PWraQvckxoflsUZQwAx6hnt+y2KkvNmGhQyJgI+X7PlZM7/?=
 =?us-ascii?Q?0z7ogac2/YKFMfRiAk0Duyrtno10/W6Ak5pglYwWYu8BSmNAkDMYU2yiFKlJ?=
 =?us-ascii?Q?L8FoDWXELvnJJx2yAokKr66mqlSFLlMOD74d0VGRdiEjUtty8AxlMArY4orW?=
 =?us-ascii?Q?rYV2yRW0v4ZqbEINTn10S66sLCzv0suSlKzokZ5l5jW9J8YxDI4KKqvpsfdH?=
 =?us-ascii?Q?yVeSR0wBfJVabBkHh9bC1iTf6WCLAkH0/4uoybdW6WUfJqMtAjJI+zM5XqnV?=
 =?us-ascii?Q?G9nVUvpgmg2xsxE/NSHgbgvsi0NJIsBx9AG4AWfAJ7RbXoxLj5QPmbY6+FtR?=
 =?us-ascii?Q?AYBeMGXPj5YEB3DpzM6smi/m7O+yhRi7mkBgzdbpp7oM4KUONFpoNEJK/JaL?=
 =?us-ascii?Q?YGVoJ2AEj/Y/NHpIYTLwq9dDc9qVw8GttHVR8EDMJXOTTrww4StFPVjZuDc+?=
 =?us-ascii?Q?aGMluVKlYGVKg6hDTtl+oePAaOpQVncl8WhMVuqe9jfW81FzigBUQj45rKOD?=
 =?us-ascii?Q?X6ZnfbYd0AY4atofC7lGFkANJijxZOVf/Wtk3QGPldJudx006ZVaZYji3JHn?=
 =?us-ascii?Q?xAVDx2BxBltVbZH7G1PU4zEG6t3Mj5wngsthfjh26fNdA4Tkem7tD3eAjJy4?=
 =?us-ascii?Q?yJCogANIhBFWYYFyUxp9sZL518pHXxsYBSH97rrm1GLGnr8XT53eZsUdYco/?=
 =?us-ascii?Q?n/SkQCAhXXDLYLI4MFIHpB7wsHyO+EutuKtVBNKOh1MVxOfnK0ddU2eER4fF?=
 =?us-ascii?Q?kgS2yueI/BfXsdATlR3KH56YkBCYDEnafxkbrW67G4uPMEbgsh+KZIV0nLGW?=
 =?us-ascii?Q?lT+HpZFZgw/QDxXL2qOrFVvpMUfYI0Fg7sl611DTCch7o8zIS210WjkWbb5A?=
 =?us-ascii?Q?zf6BkNNuqcsQdkTIvfR5MglEDx+umJrc4I5c5IbK2Hbct7Yz4PhWany4+lsz?=
 =?us-ascii?Q?6ytQfCFRXC4lqcB2y/Yu5Bi+EbQ1Q1aElbnlOPLWUKnjupMqvS7fm3V4f4s+?=
 =?us-ascii?Q?DdQn+SgGRg6gq+f6F1crQ7qOTA5WuzG0MZI8DsyGZJUl8t8zPYf7nIVRAT8J?=
 =?us-ascii?Q?Z4d0tXNCtFallew1CStlW4HOwSoAJUXkX5mKqp1SzxtimLBHZ+wswKgxNvc0?=
 =?us-ascii?Q?FG7dQ3zMPUW4D7uTRf+D8zZWpnt34fA/Xtyu9NWDYhH4fIWkFYhWqx3MT/6d?=
 =?us-ascii?Q?N0WAGqeOcKzB91fHZUif/oIIyUc95f2g0QtKoz+83Vj28jTAUPl63fN5Ppa+?=
 =?us-ascii?Q?yr+4D1nL/BRqtZOw7hZiwQRulNIjOAWIQn7DJXpNMbcH3h0CqvHTk9EKC4d3?=
 =?us-ascii?Q?gAVSJPsphFoKIa7fCwoNOjJ4QBlaiQrxe8RXTGU5kuUgdGVz0h6UlTvGy6SC?=
 =?us-ascii?Q?4AdMSLEeUCNQgQB0QGhlVe8kHf3ZJxY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 606474a8-3964-44ab-daa7-08da38f49b00
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 17:34:05.3015
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k/l/47LR9mhIh7EW5K1hqVE+WzkKBY0Onx+GLiTF9U7zlmlD6xZBykEo/fa+UhJ56WN/9+BDfUPua0cQNVXfQNAT3MtkQPBwD97zsnPMZ6I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1927
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-18_06:2022-05-17,2022-05-18 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 spamscore=0
 bulkscore=0 malwarescore=0 adultscore=0 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2205180104
X-Proofpoint-GUID: nNkzaciqEsbBejLAJvU6bVesmYQLTRXY
X-Proofpoint-ORIG-GUID: nNkzaciqEsbBejLAJvU6bVesmYQLTRXY
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

If there is a dma_mapping_error() then return negative error codes.
Currently this code returns success.

Fixes: 801b7d572c0a ("crypto: sun8i-ss - add hmac(sha1)")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
index ac417a6b39e5..845019bd9591 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
@@ -586,7 +586,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)
 			rctx->t_dst[k + 1].len = rctx->t_dst[k].len;
 		}
 		addr_xpad = dma_map_single(ss->dev, tfmctx->ipad, bs, DMA_TO_DEVICE);
-		if (dma_mapping_error(ss->dev, addr_xpad)) {
+		err = dma_mapping_error(ss->dev, addr_xpad);
+		if (err) {
 			dev_err(ss->dev, "Fail to create DMA mapping of ipad\n");
 			goto err_dma_xpad;
 		}
@@ -612,7 +613,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)
 			goto err_dma_result;
 		}
 		addr_xpad = dma_map_single(ss->dev, tfmctx->opad, bs, DMA_TO_DEVICE);
-		if (dma_mapping_error(ss->dev, addr_xpad)) {
+		err = dma_mapping_error(ss->dev, addr_xpad);
+		if (err) {
 			dev_err(ss->dev, "Fail to create DMA mapping of opad\n");
 			goto err_dma_xpad;
 		}
-- 
2.35.1