Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp867433iob; Wed, 18 May 2022 15:06:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsUzEDSTBw2WcrGSpEIP1ktz48LyXO/J2t2bfey+LJWudzBnISdFUTJyVaJ6RT7JfeEcP1 X-Received: by 2002:a63:eb45:0:b0:3db:b166:c518 with SMTP id b5-20020a63eb45000000b003dbb166c518mr1297254pgk.316.1652911618327; Wed, 18 May 2022 15:06:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652911618; cv=none; d=google.com; s=arc-20160816; b=te0QDTXNEtoEs4yQW6BGhLZe2KwzmCERSjdV5rjmdpv1B6kiyEDU2LUhUaz/tFF/Vx i0utGumYYiF3ABtxAcLKHTfevrji9aNxEmbuoKqcGB6gEnAVsgPLPtcWeTmmCVrjzW/6 NSDosYLKdXnclHoJ0M7iN7xd3AkKTdp5NsSGD+LrC2ZblyarFR5EfJP1Y1v1eWY3rLpM E1SrixJaPZJdJsVJu75RTz2RHWRK3Vr001orQ+Ji3jCb9t7s0qd59lQjObAegTLVmXDN fhrAvX1LGUV0Fxw5z9pKmSz+PEDbqR3h+PfATmn2SgwvuCObpYcH5mZIPsCidsrH2MUi DxZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=iMSU8o/vmnYNF8oQukQMHTmX2hEc142qWw/OVQkloYA=; b=Og6DCQu68xDs+zqzMqIPCCXVPGfM+Y1+a8WnORbYq5y/rKpbeEXHQqR1yvHhIHM+mY HK33LXD/Xlq/T6ZEbdN6vA215t98Ih3G/mp1ERZhyjdRSjV561O8VMNkaC6pj9nPcQmN stfL5d89dP8B6oyG3Ic9/8ES/0JpqZ6LxTemaTmHT+wlkFgdeIz6dTJjofTBujXO3o/s V1v29dyOIJvHLfmy/oLaLL+bRZFCtwfZSDChCJ4p+Baq/HQVrZ/2mNVW2ju+6qCHpLQ0 lq96FylGbE2yezMrybbCqy22PWnqX3cZHFToo5NNOOPqXgRH8mGzNwd3ue6m180n42Uy UJFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=MOOXL5WV; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o3-20020a637e43000000b003db822e2169si3506044pgn.228.2022.05.18.15.06.29; Wed, 18 May 2022 15:06:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=MOOXL5WV; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229869AbiERWFw (ORCPT + 99 others); Wed, 18 May 2022 18:05:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbiERWFm (ORCPT ); Wed, 18 May 2022 18:05:42 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B234ABF66 for ; Wed, 18 May 2022 15:03:38 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id ds11so3406510pjb.0 for ; Wed, 18 May 2022 15:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iMSU8o/vmnYNF8oQukQMHTmX2hEc142qWw/OVQkloYA=; b=MOOXL5WVm4dB91B2uKf9xSR4S+HJHSL0TSMbqIdkTz9lYASuHqAVOAh95f3WbJIGEb 2IaGHgmG9CFXLXuPdZupCWf8T178NlwE1qWO2jFgLEwYvF+sfpOK8l6uvCeDw5Wt4s/P 33mlqihbA8q89DMJJhJswWsj/E81EP1S3Q2TM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iMSU8o/vmnYNF8oQukQMHTmX2hEc142qWw/OVQkloYA=; b=Vhh1opKaoqdkZYD/wE3QhORpLpwmkkUs/yzzBXCwb5Q+0btjOGwVpOwfDcXpjCmwsL oNG5mNgMd3Yow+Ow/Fkra7+EGMFJuy/r4vobQlcGgQs8ZY7mMMRR5dssjeBrmgS2KMqA HC9CwHuvH/D2YepuNN/urd62Bt/uMTcj8bRz7jeDz29YGGmuZwSs72dn/AKlqgJrEPSr PsV4yJ+LkoeVbqkXgP+dmSGJzBgKgNyfx5Q0/bxZZs9e1Ah0XsXbxZkwjWiukSG1j1zK UEMDLYUWw5zAopQAyDRKvHdK+uG48tIpKfXi4ngFeiLsip28kW7rftajQhB7COVthRJp O46A== X-Gm-Message-State: AOAM531VrzlpAE8RKCjjBjpjcc7ZRV4yTWupOt75BbXI0nDK4pehLO9C 3i23mqYNr4hLz42tNRe2gCrGsA== X-Received: by 2002:a17:903:1c3:b0:161:8b3d:7948 with SMTP id e3-20020a17090301c300b001618b3d7948mr1426496plh.158.1652911418065; Wed, 18 May 2022 15:03:38 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p42-20020a056a0026ea00b0050dc762818dsm2529221pfw.103.2022.05.18.15.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 15:03:37 -0700 (PDT) Date: Wed, 18 May 2022 15:03:37 -0700 From: Kees Cook To: GUO Zihua Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, davem@davemloft.net, dhowells@redhat.com, herbert@gondor.apana.org.au, gustavoars@kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v3] crypto: Use struct_size() helper in kmalloc() Message-ID: <202205181503.AA72D88E15@keescook> References: <20220518062518.236965-1-guozihua@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518062518.236965-1-guozihua@huawei.com> X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, May 18, 2022 at 02:25:18PM +0800, GUO Zihua wrote: > Make use of struct_size() helper for structures containing flexible array > member instead of sizeof() which prevents potential issues, as well as > increase readability. > > Reference: https://lore.kernel.org/all/CAHk-=wiGWjxs7EVUpccZEi6esvjpHJdgHQ=vtUeJ5crL62hx9A@mail.gmail.com/ > > Signed-off-by: GUO Zihua Reviewed-by: Kees Cook -- Kees Cook