Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 20 May 2022 13:53:43 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Nathan Huckleberry <nhuck@google.com>
Cc:     linux-crypto@vger.kernel.org, linux-fscrypt@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        linux-arm-kernel@lists.infradead.org,
        Paul Crowley <paulcrowley@google.com>,
        Eric Biggers <ebiggers@kernel.org>,
        Sami Tolvanen <samitolvanen@google.com>,
        Ard Biesheuvel <ardb@kernel.org>,
        Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v8 8/9] crypto: arm64/polyval: Add PMULL accelerated
 implementation of POLYVAL
Message-ID: <Yocs5y9rvJJ+eI6C@gondor.apana.org.au>
References: <20220510172359.3720527-1-nhuck@google.com>
 <20220510172359.3720527-9-nhuck@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220510172359.3720527-9-nhuck@google.com>
Precedence: bulk

On Tue, May 10, 2022 at 05:23:58PM +0000, Nathan Huckleberry wrote:
>
> +module_cpu_feature_match(PMULL, polyval_ce_mod_init)
> +
> +module_init(polyval_ce_mod_init);

I get a cross-compile failure on this:

In file included from ../arch/arm64/crypto/polyval-ce-glue.c:25:
../include/linux/module.h:131:42: error: redefinition of ‘__inittest’
  131 |  static inline initcall_t __maybe_unused __inittest(void)  \
      |                                          ^~~~~~~~~~
../arch/arm64/crypto/polyval-ce-glue.c:187:1: note: in expansion of macro ‘module_init’
  187 | module_init(polyval_ce_mod_init);
      | ^~~~~~~~~~~
../include/linux/module.h:131:42: note: previous definition of ‘__inittest’ was here
  131 |  static inline initcall_t __maybe_unused __inittest(void)  \
      |                                          ^~~~~~~~~~
../include/linux/cpufeature.h:55:1: note: in expansion of macro ‘module_init’
   55 | module_init(cpu_feature_match_ ## x ## _init)
      | ^~~~~~~~~~~
../arch/arm64/crypto/polyval-ce-glue.c:185:1: note: in expansion of macro ‘module_cpu_feature_match’
  185 | module_cpu_feature_match(PMULL, polyval_ce_mod_init)
      | ^~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/module.h:133:6: error: redefinition of ‘init_module’
  133 |  int init_module(void) __copy(initfn)   \
      |      ^~~~~~~~~~~
../arch/arm64/crypto/polyval-ce-glue.c:187:1: note: in expansion of macro ‘module_init’
  187 | module_init(polyval_ce_mod_init);
      | ^~~~~~~~~~~
../include/linux/module.h:133:6: note: previous definition of ‘init_module’ was here
  133 |  int init_module(void) __copy(initfn)   \
      |      ^~~~~~~~~~~
../include/linux/cpufeature.h:55:1: note: in expansion of macro ‘module_init’
   55 | module_init(cpu_feature_match_ ## x ## _init)
      | ^~~~~~~~~~~
../arch/arm64/crypto/polyval-ce-glue.c:185:1: note: in expansion of macro ‘module_cpu_feature_match’
  185 | module_cpu_feature_match(PMULL, polyval_ce_mod_init)
      | ^~~~~~~~~~~~~~~~~~~~~~~~

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt