Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8f66aed7-2a46-d3bb-1121-a81f94763864@suse.de>
Date:   Fri, 27 May 2022 08:31:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCHv12 00/11] nvme: In-band authentication support
Content-Language: en-US
From:   Hannes Reinecke <hare@suse.de>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
        linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>
References: <20220518112234.24264-1-hare@suse.de>
 <bc8bea8b-2cdf-4d41-65b0-5c2bf28457d2@suse.de>
 <20220526090056.GA27050@lst.de>
 <99126556-65b8-d0eb-bcd5-7b850493b51f@suse.de>
In-Reply-To: <99126556-65b8-d0eb-bcd5-7b850493b51f@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/27/22 07:50, Hannes Reinecke wrote:
> On 5/26/22 11:00, Christoph Hellwig wrote:
>> On Wed, May 25, 2022 at 11:54:54AM +0200, Hannes Reinecke wrote:
>>> How do we proceed herese h
>>> This has been lingering for quite some time now, without any real 
>>> progress.
>>
>> As said it is a high priority for the upcoming merge window.  But we
>> also really need reviews from the crypto maintainers for the crypto
>> patches, without that I can't merge the series even if I'd like to.
> 
> Hmm. Guess I can remove those helpers; after all,
> both are just wrappers around existing exported helpers.
> I'll resend.
> 
Bummer. There was a reason after all why I coded those helpers; they 
require an internal pointer :-(
But all of these are just checks if specific hash/kpp functions are 
supported; replacing them with appropriate CONFIG_ statements should 
work as well.
I'll check.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman