Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 2 Jun 2022 15:07:17 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Vlad Dronov <vdronov@redhat.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        linux-crypto@vger.kernel.org, qat-linux@intel.com
Subject: Re: [PATCH 0/4] crypto: qat - enable configuration for 4xxx
Message-ID: <YpjEFQxtpfWQH9QH@silpixa00400314>
References: <20220517141002.32385-1-giovanni.cabiddu@intel.com>
 <CAMusb+TA6wRHtkz=wXohH9-184fK_v=X3v=eYxr7BSWuVimOmQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMusb+TA6wRHtkz=wXohH9-184fK_v=X3v=eYxr7BSWuVimOmQ@mail.gmail.com>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
Precedence: bulk

On Thu, Jun 02, 2022 at 03:21:57PM +0200, Vlad Dronov wrote:
> Hi, Giovanni, all,
> 
> I've read through the patchset and it looks good to me. I would have made
> the following two minor (really minor) changes.
> 
> Add a missing "in" to the patch message:
> 
> @@ [PATCH 1/4] crypto: qat - expose device state through sysfs for 4xxx
> -allow the change of states even if the device is the down state.
> +allow the change of states even if the device is in the down state.
> 
> Probably add an indication that cfg_services has been really changed to
> the sysfs-driver-qat doc for clarity:
> 
> @@ [PATCH 4/4] crypto: qat - expose device config through sysfs for 4xxx
> diff --git a/Documentation/ABI/testing/sysfs-driver-qat
> b/Documentation/ABI/testing/sysfs-driver-qat
>  +                       # echo dc > /sys/bus/pci/devices/<BDF>/qat/cfg_services
>  +                       # echo up > /sys/bus/pci/devices/<BDF>/qat/state
> ++                       # cat /sys/bus/pci/devices/<BDF>/qat/cfg_services
> ++                       dc
> 
> Anyway, please feel free to use:
> 
> Reviewed-by: Vladis Dronov <vdronov@redhat.com>
Thanks Vladis!
I'm going to rework and re-send.
Also I'm going to update the KernelVersion attribute in the
documentation as this patch didn't make kernel 5.19.

-- 
Giovanni