Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp1365387iof; Tue, 7 Jun 2022 04:17:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXsNfvQIv1NI7rzisTafov7t9ruQOqHP47VrrQApjokhZTJqGI8M9IuUFgvRtpC608AGjZ X-Received: by 2002:a63:6cc8:0:b0:3fa:387b:3991 with SMTP id h191-20020a636cc8000000b003fa387b3991mr25150685pgc.19.1654600640712; Tue, 07 Jun 2022 04:17:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654600640; cv=none; d=google.com; s=arc-20160816; b=xOi1lzWDuJK01j1zAak1y/DqkRwdvsItFOU7cFwXiKfpa8rUA1iA0yjOkqpIbIKZTr KBtYY08kRD5QHPPPDwqTe6L+ZAU3vNj/lalZEB8uPp0nPwKjX7LG5d63vxAlwtE9KB/f opCYsAzSDBLYIc8Xkec7E8TN8lNm7XB5KjgBCHmjjgP2q/0l9wInO4xPwU/PUrzpM9qT 2ZH9MAUEJijx70RQ0eqnia9rw1K83MYyQQwfsBbsk/rwPMxdqXeQ8Fmc/dfo7T5m49xl Z00uAafXhoW5WsAsiH1bBs1Am1URbWFgp+O7LuQs53terjjJT7FBeysRD0v9gQkTBOrF /4EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=QA8i6O8eC4oOKbqfFz87C9/p1kJZ16ndnu/DSOwEcLI=; b=ce87h0QOpthYSnfE2ATmrBcic/AR2SWqZxjLKwukVYKuu/r3Ezt/pdPajsDGryvnJC pb0yVPC6A+cL1Deak8MaGRewGUFArIGWExwGdDhyGYhfom/X9bZpNZriC/NAcqDmJsAv 4dSrrr0y4DtBBL2NnQTrogtc2j0xWdzmotyuJdkGZSGg7VLbvNzplUBpfUchE4oah9Ln wxxYUgTykFnyllwXPCaYS3HOzafU78XUK+1jmXTdd9ItjbzdeURxpgjLTOJPnCF0FBdA MSMzwy/0ultdQ1bfsPfwaU/EnNHBhYYNbN3hM+Rg1gtHjqA1deIzEclc62BqcPUcRGmZ zvxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x185-20020a6386c2000000b003fc962c76a2si8987295pgd.858.2022.06.07.04.16.56; Tue, 07 Jun 2022 04:17:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241638AbiFGKrP (ORCPT + 99 others); Tue, 7 Jun 2022 06:47:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241657AbiFGKqi (ORCPT ); Tue, 7 Jun 2022 06:46:38 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22457EFF0C for ; Tue, 7 Jun 2022 03:46:18 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 4A8DA67373; Tue, 7 Jun 2022 12:46:15 +0200 (CEST) Date: Tue, 7 Jun 2022 12:46:14 +0200 From: Christoph Hellwig To: Max Gurtovoy Cc: Hannes Reinecke , Christoph Hellwig , Sagi Grimberg , Keith Busch , linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH 09/11] nvmet: Implement basic In-Band Authentication Message-ID: <20220607104614.GB25515@lst.de> References: <20220518112234.24264-1-hare@suse.de> <20220518112234.24264-10-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, May 22, 2022 at 02:44:23PM +0300, Max Gurtovoy wrote: >> +#include "nvmet.h" >> +#include "../host/auth.h" > > maybe we can put the common stuff to include/linux/nvme-auth.h instead of > doing ../host/auth.h ? Agreed.