Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 9 Jun 2022 15:36:52 -0600
From:   Rob Herring <robh@kernel.org>
To:     Yoan Picchi <yoan.picchi@arm.com>
Cc:     Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>, qat-linux@intel.com,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andre Przywara <andre.przywara@arm.com>,
        Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH 2/2] Removes the x86 dependency on the QAT drivers
Message-ID: <20220609213652.GA115440-robh@kernel.org>
References: <20220607165840.66931-1-yoan.picchi@arm.com>
 <20220607165840.66931-3-yoan.picchi@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220607165840.66931-3-yoan.picchi@arm.com>
Precedence: bulk

On Tue, Jun 07, 2022 at 04:58:40PM +0000, Yoan Picchi wrote:
> This dependency looks outdated. After the previous patch, we have been able
> to use this driver to encrypt some data and to create working VF on arm64.
> We have not tested it yet on any big endian machine, hence the new dependency

For the subject, use prefixes matching the subsystem (like you did on 
patch 1).

The only testing obligation you have is compiling for BE. If kconfig was
supposed to capture what endianness drivers have been tested or not
tested with, then lots of drivers are missing the dependency. Kconfig
depends/select entries should generally be either to prevent compile
failures (you checked PPC, RiscV, etc.?) or to hide drivers *really*
specific to a platform. IMO, we should only have !CPU_BIG_ENDIAN if it 
is known not to work and not easily fixed.

Also, with the dependency, no one can test the driver without modifying 
the kernel and if it does work as-is, then one has to upstream a change 
and then wait for it to show up in distro kernels. You could mitigate 
the first part with COMPILE_TEST.

Rob