Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp129211iog; Tue, 14 Jun 2022 21:28:54 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tEEigmbGw0yae3XelFSf77s6uWI6sdnWh0IRjVBKbaYmhxZ4ZBmEPMLKr3QRXLJxa69HYo X-Received: by 2002:a05:6402:524a:b0:431:51b3:bc7 with SMTP id t10-20020a056402524a00b0043151b30bc7mr10397836edd.5.1655267334645; Tue, 14 Jun 2022 21:28:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655267334; cv=none; d=google.com; s=arc-20160816; b=f7GeGRDR3K+LcrpBk+w0Q6YLWfAG/hFzSirjoneMg/M6veW2GvSR+nTJhpYLfYqc7T /MPWVQZHuCFWHqM0wc41gaYoWO3hsR4JymjTyl80XqZGVlfTrFpsUmi+R7/KcPPgUAOX +xgFJQyfmYh30FNVxOI9CCSa/dk1jQhwHNDBOcylY3LtGbWX6MXY9Z2QTkUKtPWxvt26 fVK/sS4PCfcPKhgIfaHe6k8d1eQRvF73BLB3NTqYN0bzE3uvpiibpyvH29f1+Z9H4FRx nsmxMUPrW8y+JRzmDyDY29tibFcTiRAH9L0p9Y0Vy5xCE2Di2OfiKZ+k59zpI/gIn0Ni 5alw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=M8rnMcpjJ2UegdDQQqFn5AHdNBUtdZOMPLBVLVGA/8c=; b=TN6tFLx+o+hODvxFREssDX5P3iOtcoX2oIOeW5UaJJCVkxrr+j7wskaEh6Pd037lwr GO0lfVd3n6mwUBfJ7hoop+dx3gR5J9uvqKcB9WtOPDS6FjBB6aujNuK/GbRQLZXqAXvY pmCarNJ+Ka5lPB/qCk70c6mUrUJ6rWkIMTXcdGXNNtk27tjNP7PSHX/mRQQqwCrMjp6g Q/PmnHQiHtuLbVncUPjZ0Kl+1a1zQsLKylutXsv/wFoEEKsXVM7mLvQojI7PNhSP6TQF YbTZ1slW72KxEv7Iw3Bs0PRM7AjSl7GcXT7/rjD2XYH64g3KdMBotGW7/x0kUefKYvuf j3rA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr8-20020a170907720800b00711da8bb5easi15156043ejc.871.2022.06.14.21.28.14; Tue, 14 Jun 2022 21:28:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238435AbiFOEUx (ORCPT + 99 others); Wed, 15 Jun 2022 00:20:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234067AbiFOEUx (ORCPT ); Wed, 15 Jun 2022 00:20:53 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB2374A918; Tue, 14 Jun 2022 21:20:50 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1o1KWJ-007C2q-Im; Wed, 15 Jun 2022 14:20:45 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Wed, 15 Jun 2022 12:20:43 +0800 Date: Wed, 15 Jun 2022 12:20:43 +0800 From: Herbert Xu To: David Howells Cc: Simo Sorce , Jarkko Sakkinen , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] certs: Add FIPS self-test for signature verification Message-ID: References: <165515741424.1554877.9363755381201121213.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <165515741424.1554877.9363755381201121213.stgit@warthog.procyon.org.uk> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Jun 13, 2022 at 10:56:54PM +0100, David Howells wrote: > > Hi Herbert, > > If you could look over this pair of patches? The second patch adds a simple > selftest to allow the signature verification code so that it can be FIPS > compliant. The first moves load_certificate_list() to the asymmetric key code > to make this easier and renames it. Hi David: It looks OK to me. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt