Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp927473iog; Fri, 17 Jun 2022 17:47:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sI7kYWrE/JxxnFpf0d8u6WxiSORbpRFSDGL7xRkv8ng3WAJ6jiBLl6otMQ2+t6TXyDIlvS X-Received: by 2002:a17:902:d1cd:b0:169:f061:7341 with SMTP id g13-20020a170902d1cd00b00169f0617341mr7788396plb.16.1655513250018; Fri, 17 Jun 2022 17:47:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655513250; cv=none; d=google.com; s=arc-20160816; b=N2MTwR2Bf7m+EZhpwu15XW+MdEm+fTxMuL0CIU5swIPQZT7l70nWsE+Gl9aKoHvoGo kI90cOYBfXO7dkC0nRXqommhrLSu9EwFnJFAfswHbazAzpurZTv2021ozbmBV8kp9hpn d+sFbOlCvSKuHqNwLuASPVTdBAuQj09UMhxUzwxq978Qf9L73D4akyK4xjFLI9COA1oi tE2xahXUfUSY8BXSO6Y/bHNX54DWoRxe63STHIafKoILMXVHQ9j3s64SB+8KnopKIe/g VOg1KRR3wm3NydUqRt7MBygGobro27oGyjjRcUUlfr4dTbsjt5CziLoX0qzhSF9lKzL0 Xq5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=lZ79sX+NJPfDAxCDBVsMrqEoMTGb5GcEdj4eYBesXgk=; b=NfYW6hdsb6D8Go5lKfcuMKlqKtsKg8zcyUZo2JpDVydBXGvY/IGkRxk6rBlVzFBpF3 1qQY0zSYtd49YMI3iLa9dSLwkNxpCx0DEObPYgOmxO3HP1eYBWxOi21UQHfztJHOB1f7 7t1cDQRQZUSbvZwJ7lPVq88iMz6gd3NoZ3LvquvHMnzv7zRzeBsMaVRtSbEg6eBXZKpb BbwiqHAgZUyPj+cjhGHt7B626gjjpFKm6AlcWZpw080VP5yW/O5x2WVBYuyf2KDipjdj xzW0i0l9RgoUKMvJWhWgLJtM1/JRMlH7JkAjF56n9rbSdBRvkQGUeUWk+38kAE1BI9Lf jqfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=p1upQiOU; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i8-20020a17090332c800b00160c9429c19si716649plr.77.2022.06.17.17.47.04; Fri, 17 Jun 2022 17:47:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=p1upQiOU; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383713AbiFRAio (ORCPT + 99 others); Fri, 17 Jun 2022 20:38:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383754AbiFRAih (ORCPT ); Fri, 17 Jun 2022 20:38:37 -0400 Received: from mail-ua1-x931.google.com (mail-ua1-x931.google.com [IPv6:2607:f8b0:4864:20::931]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A95766CB4; Fri, 17 Jun 2022 17:38:36 -0700 (PDT) Received: by mail-ua1-x931.google.com with SMTP id b7so832953uap.5; Fri, 17 Jun 2022 17:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lZ79sX+NJPfDAxCDBVsMrqEoMTGb5GcEdj4eYBesXgk=; b=p1upQiOUMA8PL2CVEC6xwDEj/NXS9hZCuYq2h9VFhcZbwa7Iji2IfJbpJKs6+pz4HT iQKpTBiaIkZZbMAaB5YyaMHa3SkkDkxnurDzhu5hz1RkGgCPMbwx+a9bNB3wENYI1vXM JgBymJBBv00MrQk445/3gsty58kJcWyvSELlOLLFYRsbsKvP33cFOjpwmY7LP6cf0Miq W3dr5Gdpj2dPT94ZwHLypJ8Koh4HidHmdyHjQq0nO29gMeKFw+zsmeJq7bYJksF/+ZuM DlY4TSoamJkBEUKxYGGEvKnNcpgIX5f1/QPSc9ooVuyushZt39kntnahUFVrMMHQJQvJ BZqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lZ79sX+NJPfDAxCDBVsMrqEoMTGb5GcEdj4eYBesXgk=; b=kRcOt6dQvZZKUUHKM3h/E01amgGCXyOpBUkhwNMLDyUBxYpf4z8eDrF8dYm3fbz9Oy 7UNWliHJgkliiDJPFfHbKrE43PUsuLeK/Vry1Zj6IDI8LDpoFRdoZNjxvZB4DJgnJolo fQHSiVZiMmxaBKgU45b0fpRAvASCJSCCh/vN/uojpZWgqaRVk247TUsddMRtmnfEX096 kG1S6GbiMinpgx+Vevan/7ucTaxUUItcdaFJB3lqVZOW1o/pVc/JMiuH9o4GPbGAPXnD wHFLQcRP/30PJJkzde+WakHbVHDc0Ky7PKVPDk2Jj7puY9eVWtOWtw/SeC4Tb+aCm59o Pxuw== X-Gm-Message-State: AJIora9AX5ZDPH/4qNvikrGpNGAkqmcfNvHzE4vcPFnsfQpl28jWJedi sCpLXv5j/IX29TLk/cMdOrYv/RJXNAZE97qp8aDf+YYFdiU= X-Received: by 2002:ab0:7844:0:b0:37e:fc7f:ecd0 with SMTP id y4-20020ab07844000000b0037efc7fecd0mr2355220uaq.45.1655512715469; Fri, 17 Jun 2022 17:38:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Sandy Harris Date: Sat, 18 Jun 2022 08:38:23 +0800 Message-ID: Subject: Re: [PATCH] random Remove setting of chacha state to constant values. To: "Jason A. Donenfeld" Cc: Linux Crypto Mailing List , LKML , "Ted Ts'o" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Jason A. Donenfeld wrote: > > There is no such argument for > > memset(&chacha_state[12], 0, sizeof(u32) * 4); > > ChaCha has a counter and a nonce in those > > bits, so setting them to zero is a deviation. > > No. There's a new key each time. So the nonce begins at zero. And the > counter begins at zero as well at the beginning like usual. So it's > actually a rather boring by-the-books usage of chacha. No. ChaCha has a random nonce. > But the larger reason for rejecting your idea wholesale is that I'm > trying to enforce the property that input data goes through our hash > function (via mix_pool_bytes). Full stop! It's time that this > willy-nilly stuff ends where we're feeding in things right and left with > no actual design on which is ingesting what input and how it interacts. For input data, I agree completely. > So if you do think that a particular block of memory somewhere at some > point has some entropic value, then by all means call mix_pool_bytes or > add_device_randomness on it. But don't try to stuff it in where it > doesn't belong. This is not input data but more-or-less random state. I'm not trying to input it, just to leave it where it belongs rather than overwriting it with constants.