Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: [External] [PATCH] crypto: testmgr - fix version number of RSA
 tests
From:   =?utf-8?B?5L2V56OK?= <helei.sig11@bytedance.com>
In-Reply-To: <20220619030904-mutt-send-email-mst@kernel.org>
Date:   Mon, 20 Jun 2022 10:57:41 +0800
Cc:     =?utf-8?B?5L2V56OK?= <helei.sig11@bytedance.com>,
        herbert@gondor.apana.org.au, davem@davemloft.net,
        dhowells@redhat.com, arei.gonglei@huawei.com, jasowang@redhat.com,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        pizhenwei@bytedance.com, f4bug@amsat.org, berrange@redhat.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <315B0676-B712-4828-A4F4-0E559DB0DD89@bytedance.com>
References: <20220617070754.73667-1-helei.sig11@bytedance.com>
 <20220617070754.73667-3-helei.sig11@bytedance.com>
 <20220619030904-mutt-send-email-mst@kernel.org>
To:     "Michael S. Tsirkin" <mst@redhat.com>
Precedence: bulk

My mistake, please ignore this commit. I will resubmit and fix the bug =
reported by the bot

> On Jun 19, 2022, at 3:09 PM, Michael S. Tsirkin <mst@redhat.com> =
wrote:
>=20
> On Fri, Jun 17, 2022 at 03:07:51PM +0800, Lei He wrote:
>> From: lei he <helei.sig11@bytedance.com>
>>=20
>> According to PKCS#1 standard, the 'otherPrimeInfos' field contains
>> the information for the additional primes r_3, ..., r_u, in order.
>> It shall be omitted if the version is 0 and shall contain at least
>> one instance of OtherPrimeInfo if the version is 1, see:
>> 	https://www.rfc-editor.org/rfc/rfc3447#page-44
>>=20
>> Replace the version number '1' with 0, otherwise, some drivers may
>> not pass the run-time tests.
>>=20
>> Signed-off-by: lei he <helei.sig11@bytedance.com>
>=20
> Why is this posted as part of the virtio-crypto patchset thread =
though?
>=20
>=20
>> ---
>> crypto/testmgr.h | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>=20
>> diff --git a/crypto/testmgr.h b/crypto/testmgr.h
>> index 4d7449fc6a65..d57f24b906f1 100644
>> --- a/crypto/testmgr.h
>> +++ b/crypto/testmgr.h
>> @@ -186,7 +186,7 @@ static const struct akcipher_testvec =
rsa_tv_template[] =3D {
>> #ifndef CONFIG_CRYPTO_FIPS
>> 	.key =3D
>> 	"\x30\x81\x9A" /* sequence of 154 bytes */
>> -	"\x02\x01\x01" /* version - integer of 1 byte */
>> +	"\x02\x01\x00" /* version - integer of 1 byte */
>> 	"\x02\x41" /* modulus - integer of 65 bytes */
>> 	=
"\x00\xAA\x36\xAB\xCE\x88\xAC\xFD\xFF\x55\x52\x3C\x7F\xC4\x52\x3F"
>> 	=
"\x90\xEF\xA0\x0D\xF3\x77\x4A\x25\x9F\x2E\x62\xB4\xC5\xD9\x9C\xB5"
>> @@ -216,7 +216,7 @@ static const struct akcipher_testvec =
rsa_tv_template[] =3D {
>> 	}, {
>> 	.key =3D
>> 	"\x30\x82\x01\x1D" /* sequence of 285 bytes */
>> -	"\x02\x01\x01" /* version - integer of 1 byte */
>> +	"\x02\x01\x00" /* version - integer of 1 byte */
>> 	"\x02\x81\x81" /* modulus - integer of 129 bytes */
>> 	=
"\x00\xBB\xF8\x2F\x09\x06\x82\xCE\x9C\x23\x38\xAC\x2B\x9D\xA8\x71"
>> 	=
"\xF7\x36\x8D\x07\xEE\xD4\x10\x43\xA4\x40\xD6\xB6\xF0\x74\x54\xF5"
>> @@ -260,7 +260,7 @@ static const struct akcipher_testvec =
rsa_tv_template[] =3D {
>> #endif
>> 	.key =3D
>> 	"\x30\x82\x02\x20" /* sequence of 544 bytes */
>> -	"\x02\x01\x01" /* version - integer of 1 byte */
>> +	"\x02\x01\x00" /* version - integer of 1 byte */
>> 	"\x02\x82\x01\x01\x00" /* modulus - integer of 256 bytes */
>> 	=
"\xDB\x10\x1A\xC2\xA3\xF1\xDC\xFF\x13\x6B\xED\x44\xDF\xF0\x02\x6D"
>> 	=
"\x13\xC7\x88\xDA\x70\x6B\x54\xF1\xE8\x27\xDC\xC3\x0F\x99\x6A\xFA"
>> --=20
>> 2.20.1
>=20