Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp5788937iog; Thu, 23 Jun 2022 05:30:41 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vhkB+yIHENxoycjAXTd//tMRqL5VkE6a4fTeav9Escq0UMizJlpsxhCJ1R1UOWpSwkCPRy X-Received: by 2002:a17:907:80c7:b0:711:cdee:8490 with SMTP id io7-20020a17090780c700b00711cdee8490mr7768182ejc.611.1655987441233; Thu, 23 Jun 2022 05:30:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655987441; cv=none; d=google.com; s=arc-20160816; b=mYO/PTGOoXJeocAXqQtVBeXaOAiJoSNYvbhn6SZBQrK9ZFyDaby9J2oK8CK7tIQJD9 OrD08Cz6+MbpSeyKP+zZMip+j9eVPBhOsAAP4mzXdlI6cTvboYlNStqdyOHscPWTqVSa xFVpOQfRMojfCR9i6cDFV5U7U4NV0AzMMMPhBtLM6h7MqGSYsStCh4pKhZ2BKhN+mki+ IO4HkQCuE2WLsXABx2bSMiTI2GKVJMQBKpqqHTg8dNGgj6WEJPaa95ACiBfyNG4oeYvG dWEDEN5Aktmn4OgPdDXgCeglgBTpgKPy6dgkAZ2gzZW9u+9PoD+FCgDN13+KNnsYi2Ln d4mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ldgjSlcLJR6cjeouZsLQlrtYf5ACY3Wsfvn1/IBZujE=; b=zAmoIbs9nv80qQFTDzkpaKHTZq5DYsDzoFAlGUlur5LB2N3biXYdbsrGA3qTh6ZbJE iriNPyjg69BOGDjEXQMgm1yf8iZGcCHjnxbtdEG3qSmsLYwJJlDhTPM2X9C3glW54Fwo 7olrLcqqvqdtAEm0UDdJadJa7dh5S9wbVhVeA+qzRpcQ3lYGo6NyAg4RZR2SczdaeF/d 9lR71t8j951T3VuWiuIKcO+CLUgmE5EqXdrpTh5Wpg5jbCBJcEtl5X2LN8NCjLrRoEnV 6mPFhdI0Jw6d9MjykabcZqGsvfgN7KuIhiR/DNA7dFh88Uwe6+Y5EwsQTfmMX+/0L+LK ZNPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=fNTwnA8w; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x13-20020a05640226cd00b00435aba294bbsi6567712edd.325.2022.06.23.05.30.15; Thu, 23 Jun 2022 05:30:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=fNTwnA8w; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229913AbiFWMQj (ORCPT + 99 others); Thu, 23 Jun 2022 08:16:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229992AbiFWMQj (ORCPT ); Thu, 23 Jun 2022 08:16:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B85853151E; Thu, 23 Jun 2022 05:16:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5594361B54; Thu, 23 Jun 2022 12:16:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 016DBC341C6; Thu, 23 Jun 2022 12:16:35 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="fNTwnA8w" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1655986594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ldgjSlcLJR6cjeouZsLQlrtYf5ACY3Wsfvn1/IBZujE=; b=fNTwnA8wDG/wg9DlpnOHl13P9917UsEIoqsT+iu6UKmx+4kOwLaDhMxiwSTYvmahJbQnZf Fr3d//8sfs9SD3qv9NYC6i1OEgJPh/2JvsG9A6o2xieDpB3/2g0FOLaGBRI6+oD7ON1O+u eHK4z7j1ccL6eboVigbvq58/WxwDkQ8= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 89d1b8ea (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 23 Jun 2022 12:16:34 +0000 (UTC) Date: Thu, 23 Jun 2022 14:16:32 +0200 From: "Jason A. Donenfeld" To: Gregory Erwin Cc: Miaoqing Pan , Rui Salvaterra , ath9k-devel , linux-crypto@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: ath9k: hwrng blocks for several minutes when phy is un-associated Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Or perhaps more simply: diff --git a/drivers/net/wireless/ath/ath9k/rng.c b/drivers/net/wireless/ath/ath9k/rng.c index cb5414265a9b..5b44cd918c2b 100644 --- a/drivers/net/wireless/ath/ath9k/rng.c +++ b/drivers/net/wireless/ath/ath9k/rng.c @@ -83,7 +83,8 @@ static int ath9k_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait) if (!wait || !max || likely(bytes_read) || fail_stats > 110) break; - msleep_interruptible(ath9k_rng_delay_get(++fail_stats)); + if (msleep_interruptible(ath9k_rng_delay_get(++fail_stats))) + break; } if (wait && !bytes_read && max)