Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp155912iog; Fri, 24 Jun 2022 01:04:11 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s9DD+UpSjvF3/F3Q37KT9MY1dfLOCWi55+o2hA7RWsizv/jvnQvW2aD+NCR8jvYDoerLZs X-Received: by 2002:a17:902:f34a:b0:16a:e2d:3e9 with SMTP id q10-20020a170902f34a00b0016a0e2d03e9mr33922649ple.95.1656057851096; Fri, 24 Jun 2022 01:04:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656057851; cv=none; d=google.com; s=arc-20160816; b=BS0Eps+jqkjQjYtHPRrUsqQ9wwFArn8ey2oCLLreGg+O69g9yrNUxvdXNu/F04OUnF luZowlMcyhWchRmn1jFPI8HnaAx1kcO2V9r5lQF7jUb1chebXumJQnbhgm94jc7MW79K w/qZ+7EYnctbaZTHAZDBMEi4TPc2l98PWuP6ygyfr/HfNwNupmzDX/cqLRmWF9zYkBGO zIFfKLKGtVIfqSSQS8ghSatquTVUNJFIp9RshyC4wQxUcKuaZsr6J0fzIXi5ayCcHcjM taghUpvJpy2w9EBU2w3O+ZKMS9yg3DD6U39RJTTaKYZXRM84c941jgie9LCJ63NAE5eD VOkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=2PeOEnFR30X0NaXtuymuqzQ1kKEBVx/yugQZ/+xFneg=; b=j29KklbdmrjLOVNDa7fqTgtULycjrcMpZAjxN25AI+8ZdHRNTqDTRxDZa5mJd9yG48 VLLBfOKj1U+sTbFgoWN1RzRZBN22vH/diZEMmg/5sHxpoYbMZNCGl9gjdeWmXTx1h4eC I6n2x3mLXV9Zf24XlX7ptEge/CVoP4VEmdLm9/slkALGdV1dEjTs0tprmGJup+6g2++a 3WkXAGm4snbbEmz8v3LQJijYxawLp/X6I4iCYXOC2DM9SqxlcjtCNo8hSji7Cjkxj8d8 +Q9bmnUxV5Y3Ju8qZKJwpLswtSZdPV6Q8CmMLkBSU3rdfIqXIOXBZpvMvTtfthfwJVU9 29Rg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rj9-20020a17090b3e8900b001e285944aedsi2365910pjb.116.2022.06.24.01.03.44; Fri, 24 Jun 2022 01:04:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229488AbiFXIAe (ORCPT + 99 others); Fri, 24 Jun 2022 04:00:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229669AbiFXIAd (ORCPT ); Fri, 24 Jun 2022 04:00:33 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80FC26B8C9; Fri, 24 Jun 2022 01:00:32 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1o4eEO-00AgF9-Nt; Fri, 24 Jun 2022 17:59:58 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 24 Jun 2022 15:59:57 +0800 Date: Fri, 24 Jun 2022 15:59:57 +0800 From: Herbert Xu To: Qian Cai Cc: Eric Biggers , "David S. Miller" , Ard Biesheuvel , Catalin Marinas , Will Deacon , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/crypto: Select AEAD2 for GHASH_ARM64_CE Message-ID: References: <20220622142557.144536-1-quic_qiancai@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Jun 23, 2022 at 03:08:32PM -0400, Qian Cai wrote: > > I am not sure about that. I chose CRYPTO_AEAD2 because that is in the > Makefile. > > obj-$(CONFIG_CRYPTO_AEAD2) += aead.o As Eric said, AEAD2 is for internal use only and the correct option for general use is CONFIG_CRYPTO_AEAD. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt