Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220627083652.880303-1-giovanni.cabiddu@intel.com>
In-Reply-To: <20220627083652.880303-1-giovanni.cabiddu@intel.com>
From:   Vlad Dronov <vdronov@redhat.com>
Date:   Tue, 28 Jun 2022 14:15:26 +0200
Message-ID: <CAMusb+SU1AtWf+RQH6r9kxDwKfR0qTrGaB1BfSk0s7gTKjbp_Q@mail.gmail.com>
Subject: Re: [PATCH v2 0/4] crypto: qat - enable configuration for 4xxx
To:     Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        linux-crypto@vger.kernel.org, qat-linux@intel.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Mon, Jun 27, 2022 at 10:37 AM Giovanni Cabiddu
<giovanni.cabiddu@intel.com> wrote:
>
> qat_4xxx devices can be configured to allow either crypto or compression
> operations. By default, devices are configured statically according
> to following rule:
> - odd numbered devices assigned to compression services
> - even numbered devices assigned to crypto services
>
> This set exposes two attributes in sysfs that allow to report and change
> the state and the configuration of a QAT 4xxx device.
> The first, /sys/bus/pci/devices/<BDF>/qat/state, allows to bring a
> device down in order to change the configuration, and bring it up again.
> The second, /sys/bus/pci/devices/<BDF>/qat/cfg_services, allows to
> inspect the current configuration of a device (i.e. crypto or
> compression) and change it.
>
>     # cat /sys/bus/pci/devices/<BDF>/qat/state
>     up
>     # cat /sys/bus/pci/devices/<BDF>/qat/cfg_services
>     sym;asym
>     # echo down > /sys/bus/pci/devices/<BDF>/qat/state
>     # echo dc > /sys/bus/pci/devices/<BDF>/qat/cfg_services
>     # echo up > /sys/bus/pci/devices/<BDF>/qat/state
>     # cat /sys/bus/pci/devices/<BDF>/qat/state
>     dc
>
> Changes from v1:
>  - Updated target kernel version in documentation (from 5.19 to 5.20).
>  - Fixed commit message in patch #1 and updated documentation in patch
>    #4 after review from Vladis Dronov.
>
> Giovanni Cabiddu (4):
>   crypto: qat - expose device state through sysfs for 4xxx
>   crypto: qat - change behaviour of adf_cfg_add_key_value_param()
>   crypto: qat - relocate and rename adf_sriov_prepare_restart()
>   crypto: qat - expose device config through sysfs for 4xxx

The patchset looks good to me. Please feel free to use:

Reviewed-by: Vladis Dronov <vdronov@redhat.com>

Best regards,
Vladis Dronov | Red Hat, Inc. | The Core Kernel | Senior Software Engineer