Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <3c38b723-40e6-ded9-5a3b-7b442a3f65d8@linux.vnet.ibm.com> <YrvDEqdk3ZfcEy9i@sol.localdomain>
In-Reply-To: <YrvDEqdk3ZfcEy9i@sol.localdomain>
From:   Ignat Korchagin <ignat@cloudflare.com>
Date:   Wed, 29 Jun 2022 22:35:33 +0100
Message-ID: <CALrw=nEsEemxP4q4QkFGxOY3+fo07wopdtLUerzBP0oKhRLmUA@mail.gmail.com>
Subject: Re: [linux-next] [[5.19.0-rc4-next-20220627] WARNING during reboot to
 linux-next kernel
To:     Eric Biggers <ebiggers@kernel.org>,
        Tasmiya Nalatwad <tasmiya@linux.vnet.ibm.com>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        linux-block <linux-block@vger.kernel.org>,
        linux-crypto <linux-crypto@vger.kernel.org>,
        kernel-team <kernel-team@cloudflare.com>,
        abdhalee@linux.vnet.ibm.com, sachinp@linux.vnet.com,
        mputtash@linux.vnet.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jun 29, 2022 at 4:12 AM Eric Biggers <ebiggers@kernel.org> wrote:
>
> On Tue, Jun 28, 2022 at 02:33:55PM +0530, Tasmiya Nalatwad wrote:
> > Greetings,
> >
> > [linux-next] [[5.19.0-rc4-next-20220627] WARNING during reboot to linux-next
> > kernel
> >
> > --- Call Traces ---
> > [    1.788574] ------------[ cut here ]------------
> > [    1.788577] alg: self-tests for rsa-generic (rsa) failed (rc=-22)
> > [    1.788586] WARNING: CPU: 9 PID: 218 at crypto/testmgr.c:5774
> > alg_test+0x438/0x880
> > [    1.788598] Modules linked in:
> > [    1.788603] CPU: 9 PID: 218 Comm: cryptomgr_test Not tainted
> > 5.19.0-rc4-next-20220627-autotest #1
> > [    1.788609] NIP:  c00000000062e078 LR: c00000000062e074 CTR:
> > c00000000075e020
> > [    1.788614] REGS: c00000000e733980 TRAP: 0700   Not tainted
> > (5.19.0-rc4-next-20220627-autotest)
> > [    1.788620] MSR:  8000000000029033 <SF,EE,ME,IR,DR,RI,LE>  CR: 28008822
> > XER: 20040005
> > [    1.788632] CFAR: c00000000014f244 IRQMASK: 0
> > [    1.788632] GPR00: c00000000062e074 c00000000e733c20 c000000002a12000
> > 0000000000000035
> > [    1.788632] GPR04: 00000000ffff7fff c00000000e7339e0 c00000000e7339d8
> > 0000000000000000
> > [    1.788632] GPR08: c000000002826b78 0000000000000000 c000000002566a50
> > c0000000028e6bb8
> > [    1.788632] GPR12: 0000000000008000 c00000000fff3280 c00000000018b6d8
> > c00000000d640080
> > [    1.788632] GPR16: 0000000000000000 0000000000000000 0000000000000000
> > 0000000000000000
> > [    1.788632] GPR20: 0000000000000000 0000000000000000 0000000000000000
> > 0000000000000000
> > [    1.788632] GPR24: c000000000da49e8 0000000000000000 c000000050630480
> > 0000000000000400
> > [    1.788632] GPR28: c000000050630400 000000000000000d c000000002cd33d8
> > ffffffffffffffea
> > [    1.788691] NIP [c00000000062e078] alg_test+0x438/0x880
> > [    1.788696] LR [c00000000062e074] alg_test+0x434/0x880
> > [    1.788701] Call Trace:
> > [    1.788704] [c00000000e733c20] [c00000000062e074] alg_test+0x434/0x880
> > (unreliable)
> > [    1.788712] [c00000000e733d90] [c00000000062c040]
> > cryptomgr_test+0x40/0x70
> > [    1.788718] [c00000000e733dc0] [c00000000018b7f4] kthread+0x124/0x130
> > [    1.788726] [c00000000e733e10] [c00000000000ce54]
> > ret_from_kernel_thread+0x5c/0x64
> > [    1.788733] Instruction dump:
> > [    1.788736] 409e02e4 3d22002c 892913fd 2f890000 409e02d4 3c62fe63
> > 7f45d378 7f84e378
> > [    1.788746] 7fe6fb78 3863fa90 4bb2116d 60000000 <0fe00000> fa2100f8
> > fa410100 fa610108
> > [    1.788757] ---[ end trace 0000000000000000 ]---
> > --
>
> It's caused by:
>
> commit f145d411a67efacc0731fc3f9c7b2d89fb62523a
> Author: Ignat Korchagin <ignat@cloudflare.com>
> Date:   Fri Jun 17 09:42:10 2022 +0100
>
>     crypto: rsa - implement Chinese Remainder Theorem for faster private key operations

Thanks for the report. Seems the RSA test vectors need updating as we
now care about CRT parameters. I'll try to craft something.