Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <50203730-35f1-4bf9-3f3a-ca6cd3b01d4a@gmail.com>
Date:   Thu, 30 Jun 2022 16:13:19 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 0/2] crypto: Introduce ARIA symmetric cipher algorithm
Content-Language: en-US
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-crypto@vger.kernel.org, davem@davemloft.net
References: <Yr1FBOC8Zi1ltlBi@gondor.apana.org.au>
From:   Taehee Yoo <ap420073@gmail.com>
In-Reply-To: <Yr1FBOC8Zi1ltlBi@gondor.apana.org.au>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/30/22 15:39, Herbert Xu wrote:

Hi Herbert,
Thank you so much for your review!

 > Taehee Yoo <ap420073@gmail.com> wrote:
 >> This patchset adds a new ARIA(RFC 5794) symmetric cipher algorithm.
 >>
 >> Like SEED, the ARIA is a standard cipher algorithm in South Korea.
 >> Especially Government and Banking industry have been using this 
algorithm.
 >> So the implementation of ARIA will be useful for them and network 
vendors.
 >>
 >> Usecases of this algorithm are TLS[1], and IPSec.
 >> It would be very useful for them if it implements kTLS for ARIA.
 >
 > You haven't added any glue to use this for IPsec.  Unless there is
 > an in-kernel user we won't add any new algorithms.
 >
 > Thanks,

Unfortunately, IPsec draft[1] is expired so I think adding the 
aria-IPsec feature is not our rule as far as I know even if there are 
already  users in South Korea.
So, my plan is to add the kTLS feature because aria-TLS[2] is now standard.
So, Is it okay to add the aria-kTLS feature into the v2 patch, instead 
of aria-IPsec?

[1] https://datatracker.ietf.org/doc/draft-nsri-ipsecme-aria-ipsec/
[2] https://datatracker.ietf.org/doc/html/rfc6209

Thanks,
Taehee Yoo