Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liang He <windhl@126.com>
To:     herbert@gondor.apana.org.au, davem@davemloft.net,
        mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
        windhl@126.com, linux-crypto@vger.kernel.org
Subject: [PATCH v2 2/2] crypto: nx: Hold the reference returned by of_find_compatible_node
Date:   Thu, 30 Jun 2022 16:36:57 +0800
Message-Id: <20220630083657.206122-2-windhl@126.com>
In-Reply-To: <20220630083657.206122-1-windhl@126.com>
References: <20220630083657.206122-1-windhl@126.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

In nx842_pseries_init(), we should hold the reference returned by
of_find_compatible_node() and use it to call of_node_put to keep
refcount balance.

Signed-off-by: Liang He <windhl@126.com>
---
 changelog:

 v2: split v1 into two commits
 v1: fix bugs in two directories (amcc,nx) of crypto

 v1-link: https://lore.kernel.org/all/20220621073742.4081013-1-windhl@126.com/


 drivers/crypto/nx/nx-common-pseries.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/nx/nx-common-pseries.c b/drivers/crypto/nx/nx-common-pseries.c
index 7584a34ba88c..3ea334b7f820 100644
--- a/drivers/crypto/nx/nx-common-pseries.c
+++ b/drivers/crypto/nx/nx-common-pseries.c
@@ -1208,10 +1208,13 @@ static struct vio_driver nx842_vio_driver = {
 static int __init nx842_pseries_init(void)
 {
 	struct nx842_devdata *new_devdata;
+	struct device_node *np;
 	int ret;
 
-	if (!of_find_compatible_node(NULL, NULL, "ibm,compression"))
+	np = of_find_compatible_node(NULL, NULL, "ibm,compression");
+	if (!np)
 		return -ENODEV;
+	of_node_put(np);
 
 	RCU_INIT_POINTER(devdata, NULL);
 	new_devdata = kzalloc(sizeof(*new_devdata), GFP_KERNEL);
-- 
2.25.1