Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: [PATCH v2 0/4] virtio-crypto: support ECDSA algorithm
From:   Lei He <helei.sig11@bytedance.com>
In-Reply-To: <274D6476-E37F-4110-BAA5-5B5CE0B63BE9@bytedance.com>
Date:   Thu, 30 Jun 2022 20:50:43 +0800
Cc:     Lei He <helei.sig11@bytedance.com>, davem@davemloft.net,
        dhowells@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        =?utf-8?Q?=22Daniel_P_=2E_Berrang=C3=A9=22?= <berrange@redhat.com>,
        zhenwei pi <pizhenwei@bytedance.com>,
        Herbert Xu <herbert@gondor.apana.org.au>
Content-Transfer-Encoding: quoted-printable
Message-Id: <5F114A3E-2854-486F-AEFE-B04CFF3C3C52@bytedance.com>
References: <20220623070550.82053-1-helei.sig11@bytedance.com>
 <Yr1JvG1aJUp4I/fP@gondor.apana.org.au>
 <C7191BC8-5BE0-47CB-A302-735BBD1CBED0@bytedance.com>
 <Yr1TuPM8yvJUoV9r@gondor.apana.org.au>
 <CC761178-556D-44F6-9479-5151C69476C8@bytedance.com>
 <Yr1nybJ9eSNgU24i@gondor.apana.org.au>
 <274D6476-E37F-4110-BAA5-5B5CE0B63BE9@bytedance.com>
To:     Xin Zeng <xin.zeng@intel.com>
Precedence: bulk

On Jun 30, 2022, at 8:44 PM, Lei He <helei.sig11@bytedance.com> wrote:
>=20
> On Jun 30, 2022, at 5:07 PM, Herbert Xu <herbert@gondor.apana.org.au> =
wrote:
>=20
>>=20
>> On Thu, Jun 30, 2022 at 04:30:39PM +0800, Lei He wrote:
>>>=20
>>> I have explained above why we need a driver that supports ECDSA, and =
this patch
>>> enables virtio-crypto to support ECDSA. I think this is a good time =
to support ECDSA
>>> in the kernel crypto framework, and there will be more drivers =
supporting ECDSA in the=20
>>> future.
>>> Looking forward to your opinion :-).
>>=20
>> Until there are drivers in the kernel it's pointless to implement
>> this.
>>=20
>=20
> I guess you mean that if there are no drivers in the linux kernel =
source tree that supports the=20
> ECDSA, then there is no way under linux to offload ECDSA to other =
devices, so even if the
> virtio-crypto can get the akcipher request, it can=E2=80=99t do =
better, right? I have some different opinions
> on this:
> 1. There does exist hardware for offloading ECDSA calculations, for =
example, IBM PCIe
> Cryptographic Coprocessor, Intel QAT, etc, and those chips are already =
on the market now.
> Of course, they also provided corresponding drivers to access these =
devices, but for some reason,
> these drivers have not been submitted to the kernel source tree now.
> 2. With this patch, when we use QEMU to create a virtual machine, =
people can directly access the=20
> virtio-crypto device without caring about where these akcipher =
requests are executed, and no need
> to update drivers(and other stuff) for guest kernel when the  =
co-processor is updated.=20
> 3.  I will communicate with the Intel QAT team about their plans to =
provide ECDSA support and ECDH=20
> support.

Hi, xin:
	I would like to ask if you have any plans to support ECDSA in =
LKC for QAT driver, and if so how is
it going?=