Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1695855imw; Tue, 5 Jul 2022 13:56:43 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vZ1bEAzNSkmRcxOYWQCyfRkS3phZu8GOzq/ZIr2F/M5FTUnyQiyLFIAevJ5qs//DtulTe3 X-Received: by 2002:a17:90b:17cb:b0:1ec:9d52:46f7 with SMTP id me11-20020a17090b17cb00b001ec9d5246f7mr43362278pjb.221.1657054603655; Tue, 05 Jul 2022 13:56:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657054603; cv=none; d=google.com; s=arc-20160816; b=dIngYr5Z00gNLyolc7j3Mo/o0X08iXSwUg86lcQXiQqZVyFf07xPh+NEoPtIwAXrS3 kQvK2bnC0iMhzWB+MJSlrylXnYebGMfLEWKmnFho0y0GMMeEmfhOmYc8v9rM4tflk6EY VcDd4WQ8zA8cOwXPGG847lo8XNis2h7P6Fvqw/3QOIAGKM6zkrzsR21LWAGGU401evnG F9h1nkfs+LY5EiAVp4P0Yff9V5fQ8q2f75dwD/ciJc04zG7dewH8jvy9Ocw74JXvO/ER TpEb4fBiKBruy2vKtk9dAcQ3DDlwjOPLJYBml3VY46HEt5dUjeCvJXXX/bK5DkxuXbrL wQ0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=bPh4k3MT+3lJ/gS6AjsAkvzNhKtRTqo++07BpCo92wE=; b=SKPRyWtbshji68SAAIWH0kFrwv9aDJCg+NfOYIbLVt1mviuQRB1zCoJR9jbuszmk3S y4B2eYcX/PeZKTIha76BNNMe5LMXj6nP8ThXkB/ebQa78sIwO8F5wagRGcHahNFrt46d BUKgLlLwkAH6hG8BjzucuXuzIFENOpocNNAZHQoPPrIkqJHJF8DBdtRCV/dT89Yr9kMs 91vaaLAD6CqCX+TX+tE2gQJD0kYPLT7WoweEWZRbAfOTTbOEnYDaLsa7/kF+HrDQaiKU 4VnVbvX1wGYldiR1k+9GjNhBx5XJ/qZLnL/F+n0T2SsIQ2GzMOE0y/EV8T/ogXADVOfc nZ7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e2-20020a63f542000000b003fccbc8a085si44502746pgk.782.2022.07.05.13.56.31; Tue, 05 Jul 2022 13:56:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231337AbiGEUwF (ORCPT + 99 others); Tue, 5 Jul 2022 16:52:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230053AbiGEUwD (ORCPT ); Tue, 5 Jul 2022 16:52:03 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A22438D for ; Tue, 5 Jul 2022 13:52:02 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8pWX-0000tc-MM; Tue, 05 Jul 2022 22:51:57 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o8pWS-004dBN-I2; Tue, 05 Jul 2022 22:51:56 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o8pWV-003Ds7-9v; Tue, 05 Jul 2022 22:51:55 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski , Vladimir Zapolskiy , Herbert Xu , "David S. Miller" Cc: linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 7/7] crypto: s5p-sss: Drop if with an always false condition Date: Tue, 5 Jul 2022 22:51:44 +0200 Message-Id: <20220705205144.131702-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220705205144.131702-1-u.kleine-koenig@pengutronix.de> References: <20220705205144.131702-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=853; h=from:subject; bh=bogHrLWOhtcmBuEz8mG/TmgQiUKVPwTBmiYKM67IJrE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBixKRao/uc3yXouIxVSkn1OfxwsSKdJUfg3aNxeLh6 rrS1RlOJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYsSkWgAKCRDB/BR4rcrsCRWhB/ 0W08RBg8aZIfa5KTf034XdzCyDxQb3pqB2m60hY9sY81yVZV7kmvz4+HSgkUwT+QShLOiyD2qXxrAO FTPY5m4pv5fsr/N45hUagVGz7NiwW9QXKKLUvOfJMrGLFK/BMsGkR5wCAl7pvW6L/5cSQ+5BIE16OG nytNang79k98Bu5Z/G9oRQeoGE+BFEQAfb3vxHY47IJWTGnbVbBszMqdga7+qa1Qvc/+BugEjiIIXF EEZMoIxOfO61SZgXLEDvk0REWxXBY/MW191m+32alh8pM2BlFSN/R5dKFzRnefUUPbe72FRYBC25Mv ClSiAqodJd/AXREJ5dhm6V2al6Qq9C X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The remove callback is only called after probe completed successfully. In this case platform_set_drvdata() was called with a non-NULL argument and so pdata is never NULL. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König --- drivers/crypto/s5p-sss.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index 7717e9e5977b..b79e49aa724f 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -2321,9 +2321,6 @@ static int s5p_aes_remove(struct platform_device *pdev) struct s5p_aes_dev *pdata = platform_get_drvdata(pdev); int i; - if (!pdata) - return -ENODEV; - for (i = 0; i < ARRAY_SIZE(algs); i++) crypto_unregister_skcipher(&algs[i]); -- 2.36.1