Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp2112484imw; Tue, 5 Jul 2022 23:39:10 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tgDddDL+GsUiY3Rgs7kvCoyqYF+XRTqd2y8USjcDlKLqDYEZ2I4K5dBbDVDDA0d9kbNtjO X-Received: by 2002:a63:83c2:0:b0:40d:404c:f0d8 with SMTP id h185-20020a6383c2000000b0040d404cf0d8mr33599195pge.393.1657089550673; Tue, 05 Jul 2022 23:39:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657089550; cv=none; d=google.com; s=arc-20160816; b=kQHkD20rYt89KpwS7v7YraAVTdIGeAdM3ySkH5qg1m3jCGzd2FYATcWp/Vr23RnEer ydn4iAqT0DYVdSt6fJr7rU/IPPFszksz4zxU27+TkIwt3uTOTNd+jHIxdJSWm/64d3y8 4SAmPFO62K9uX9jkb+pQ4kHXp5r2RGQSczD0sEcFZ9kPX/slQYIzvzoqBIJGza5BsmOm gKo0gfwE9rUdJ43kionDnNuj0h0jPkuSJCQ7wDh6glHgJod+chh64Q2uPVMcDKVhtTDI +ZAGApO09XZ8woIHruJIptoPvvX+HasZxPp1w0myql6c+Ze2IKHHNiD6H31T3kbkPiTS AFCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=i1BMPZ/ewrNPyYNCuyDmgoFFvJ41CYWagfxQdw0+v9Y=; b=J4G0fZ1RTQvNA63mArmIhqvOh6iLbWcGb4yv+pYgfAd0z73CWdg+iR4zXNLWBARE38 30malQTxW9lMFTRwaYSHYLPEklP6VVndeosVwUqUHMZpb9Hu4S/u1Z0Mwtf1IILViMoq Mg+l8O9E4WcCj+FneW+tAePRtw3zACejFHu89E4Y4ffjDFYU4P7JxgzfNGPncl9E99nG SeQe7OIZHonq5FvG9GSHc9lB1Izo5UERKUFCZ7ut2d3m5Q8vHYs3g3DJ+JLZjKp1udTz yOv0ks2OAEw76lbyZhc3NKP9O0/yTVr6FNoV07oS+AXWk380P2dDFeSD3LgQ/1KxqCxt h60g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Lo3trhbM; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j7-20020a170903024700b00163e9849d54si33651923plh.214.2022.07.05.23.38.47; Tue, 05 Jul 2022 23:39:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Lo3trhbM; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229752AbiGFGeq (ORCPT + 99 others); Wed, 6 Jul 2022 02:34:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbiGFGeq (ORCPT ); Wed, 6 Jul 2022 02:34:46 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1667F658C for ; Tue, 5 Jul 2022 23:34:45 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id j23so487103lji.13 for ; Tue, 05 Jul 2022 23:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=i1BMPZ/ewrNPyYNCuyDmgoFFvJ41CYWagfxQdw0+v9Y=; b=Lo3trhbMqgjZoPdYYcnbvZhtIDuRabm8nZMnEBZyQLC3yvna+fxEmTnLai4ERTFrjg Iku7oKbwE8nsfygrKY5QkTPgJwjCFB+yo8fBRSE/GYqfQHK2X0GaZnUwN1bgPkivjtvY Nq7wx99tOa19wMED8G1K+jXoXERDjWhWZyQuyiIdeTkhHlQct6EYgTTR9Oz1brCFcage z8GLW5ePAoeK/iD0gCYSAfwHnq9kgSi6YhPWPvJH39exY03QmzaFpimDy7A/6wkojpHD a/UEo66WF8Snyuhk+m3P85WkTDNmIahYSH7DrEgoj+wDK0fGWt5HBwVyKIFGtZoSHnwf /z8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=i1BMPZ/ewrNPyYNCuyDmgoFFvJ41CYWagfxQdw0+v9Y=; b=Ia7rI2oa3vCuKrEZuEzLIbGGwqLXOfuFD9sqFeus8gF74wjZDjf7LYGAsU+0GWwI8g ZB888aKGq6FQQKnYSkrIhj6Yn/sPLDtCwbfslapL3KLRpj9iMWXRKHya5KA0uGgj5e4N C7LmVJza/8Ae4BtVqPLb7WLm4zEiWWqGmGZkjRYXikdFhdzdY6Hm6N8R+lwcXi0v7AWf 6I4Mr/vFe+2VIkFvdceN+erVZ5BeZ3kiIyMDB9goN0sQgyYSR0t/wt0v0/vyvcAn7gQ0 Xu3sQf7JVKO14/iXm1s19h4Gr4Mw2oBdEnJvT89x5b7sBftH4PFxenVpMf8M5WRjJa1U 8fUg== X-Gm-Message-State: AJIora/153g+WicFPeeMpcsapTMiuK2VQJn43wKCCtJfGxRSnzn1WVOy 59SZow5WQMMegZ9ptBRkW2Jjsw== X-Received: by 2002:a2e:9d84:0:b0:25b:c7f1:c978 with SMTP id c4-20020a2e9d84000000b0025bc7f1c978mr22662876ljj.126.1657089283491; Tue, 05 Jul 2022 23:34:43 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id c4-20020a196544000000b0047f6fe39bb9sm6113165lfj.27.2022.07.05.23.34.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 23:34:43 -0700 (PDT) Message-ID: <8c221a4b-8a66-f142-d57c-2d6b9ed047b0@linaro.org> Date: Wed, 6 Jul 2022 08:34:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 7/7] crypto: s5p-sss: Drop if with an always false condition Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Vladimir Zapolskiy , Herbert Xu , "David S. Miller" Cc: linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kernel@pengutronix.de References: <20220705205144.131702-1-u.kleine-koenig@pengutronix.de> <20220705205144.131702-7-u.kleine-koenig@pengutronix.de> From: Krzysztof Kozlowski In-Reply-To: <20220705205144.131702-7-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 05/07/2022 22:51, Uwe Kleine-König wrote: > The remove callback is only called after probe completed successfully. > In this case platform_set_drvdata() was called with a non-NULL argument > and so pdata is never NULL. > > This is a preparation for making platform remove callbacks return void. > > Signed-off-by: Uwe Kleine-König > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof