Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp2219657imw; Wed, 6 Jul 2022 02:06:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uBdDFt2qvmPddakHSo0vuNxuaI3udFSk+7MvcCHhcGt3VVm2lYjSsOz3zJ+eDxsXJxgfZK X-Received: by 2002:a05:6402:22a1:b0:437:78c2:d02b with SMTP id cx1-20020a05640222a100b0043778c2d02bmr52386537edb.64.1657098405851; Wed, 06 Jul 2022 02:06:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657098405; cv=none; d=google.com; s=arc-20160816; b=UZPdiwPzGBnTxwpU7p+fCRvpUSJ57eydXHBWYPMH/TOsYjyXXdyJZ4VpP4exMh7h8s Kt+6kuIXA8qf7f/kVUIuIr1GDiSYfz28dzZfiPx7hBv3hdC9K3ikBQMhXW06nrLlFZmm Hgo99GQ2uvAF44q4sIH2/IUM/lazmQAX20PdtYwT4VOwGPuvv/6KF6lH2A5KPrhvsEW9 FkYl9tKUZlkrQgnjclEQzI1oJ27QGWgEIkoaT3WYOfjHQd+nPxGtZeQAf6gMeMwzxLIM Pm5q0r64C9hwm3alyDKZ3f4QFnuPtUaC7PJm9CPn6s6nNEUdKQstl78Obcpwyw44tj+k ERtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2nwWkT4441Zvq5igIAOKA8C0HAjPPXDmTRADPlAyhok=; b=UEOFRrl7JgDVZyP6GMKqEyJfaTppjf/Ce0sEW0EhcV78NjDbLTz08RWwFnPAlF5Btk Yk5RIFh44mc/E/uXJhabEUKLxHEhEKHPeaijE8eo7Ljr/bSZWXxBNvYt5l0ZvgkPWF5R vptj1sXsCClKvfpKxEdrsCxY0YnolIOBDUk4M+b56ct1wS9YfN8E3rt4u63H1KvmxI3d wiiSlw5p38NbSJG6TCozdeEEJgOZOUi5o/LGIMEpOCi7H6DT0eFaNpf8NMr63LL3YfVa Qco7xcuNE54QkTZdvZGM1CmACsLu/aG6qhkETH1WmVI5m5AedVLNWLr7EpvvR9e61NjT 3Xzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=Pr3IXa8E; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ec16-20020a170906b6d000b00712237d858dsi18365314ejb.577.2022.07.06.02.06.20; Wed, 06 Jul 2022 02:06:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=Pr3IXa8E; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232362AbiGFJEh (ORCPT + 99 others); Wed, 6 Jul 2022 05:04:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231882AbiGFJEg (ORCPT ); Wed, 6 Jul 2022 05:04:36 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A7D61AF3C for ; Wed, 6 Jul 2022 02:04:35 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id h17so7902252wrx.0 for ; Wed, 06 Jul 2022 02:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2nwWkT4441Zvq5igIAOKA8C0HAjPPXDmTRADPlAyhok=; b=Pr3IXa8ExRhTFh+SPH7MrhQizXMmrRN4KOZzHqdYpWENJ96Ms04oBik0WfZbJ27egJ ldxRn/lKH+72j5pIK0nS2nYnViD4t7mh4Zb1sOqM2u2kO5jOs6YQUThf4H4eI2Km2Ujk DwddZ86xRnFapyFfMRqcT6ohi+6e0uc4u1C7mMTTJA/fIR7ogqFH26AfqYtb+NPy09S6 Lqsl7Gej6g7TLBDiNG7TJFSX2PL0SMt1IdS4uGkcq1ucTSIZUoDqeFV0sk0icX109eD0 +evOAKZrJ8Fcpr+vITTRyd9o5yoYy0tl+3ssElJnyQ3+12HdNMnyGRJT/M/jsAeeXFrC 2s1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2nwWkT4441Zvq5igIAOKA8C0HAjPPXDmTRADPlAyhok=; b=Zs6hUrTCK3vgyJ3+3tfyLyhxUmihV0eghZEz5VifKoGDN6m8wSf2u0qtVjsuhqpLIh oKB17RRP54HBx4MXbJlH61uUaodJvfelRwwhc7wL8mTga5QcwHmagJlApkzmoFc9Ighp DfE3o43iC2TdsPoAkAuOso8Ahs/TUt2Mj+0BrhZRAw4xT9kDqC4iBckixEX7OvwNjMuA Z3KgzMKteZ2F7ChhSUMrKSqBDUvQVugXMT32fZyO9tBtNChsMazIaY+Fzmb0t4x6r+5v 1wdL44SKBVk4HpN30809fWRwSdtxN3+EgZtXIdoLXhO9v+PzBnJI6q1uEQw7en+59cbf rCeg== X-Gm-Message-State: AJIora/mgSO31S54+rtdLDgqeLgaF35du7A32Df4mxp0hneQ6xcHss89 jsH7DkdUN0T9d6sErRK9U8gv6A== X-Received: by 2002:a5d:6d0c:0:b0:21b:ccda:fc67 with SMTP id e12-20020a5d6d0c000000b0021bccdafc67mr37250833wrq.246.1657098274092; Wed, 06 Jul 2022 02:04:34 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id v11-20020adfe28b000000b0021d6ef34b2asm5230223wri.51.2022.07.06.02.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 02:04:33 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, herbert@gondor.apana.org.au, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, p.zabel@pengutronix.de, robh+dt@kernel.org, sboyd@kernel.org Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, john@metanate.com, didi.debian@cknow.org, Corentin Labbe Subject: [PATCH v8 01/33] crypto: rockchip: use dev_err for error message about interrupt Date: Wed, 6 Jul 2022 09:03:40 +0000 Message-Id: <20220706090412.806101-2-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220706090412.806101-1-clabbe@baylibre.com> References: <20220706090412.806101-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Interrupt is mandatory so the message should be printed as error. Reviewed-by: John Keeping Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c index 35d73061d156..45cc5f766788 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -371,8 +371,7 @@ static int rk_crypto_probe(struct platform_device *pdev) crypto_info->irq = platform_get_irq(pdev, 0); if (crypto_info->irq < 0) { - dev_warn(crypto_info->dev, - "control Interrupt is not available.\n"); + dev_err(&pdev->dev, "control Interrupt is not available.\n"); err = crypto_info->irq; goto err_crypto; } -- 2.35.1