Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp203239imw; Fri, 8 Jul 2022 01:03:12 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uZ4ZQHLdkKvfKUahe61BsXw2iUMkotwAfMNEh7yUdj1HJLMqllqOWP7QbTHMfAWb5rmFu6 X-Received: by 2002:a17:90b:4c0d:b0:1ed:2466:c0d3 with SMTP id na13-20020a17090b4c0d00b001ed2466c0d3mr10535039pjb.6.1657267392453; Fri, 08 Jul 2022 01:03:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657267392; cv=none; d=google.com; s=arc-20160816; b=jwxeE9ko7IIDBhnlDEmtwbKgjRNatnDn3JRqea89LWfdkCZzWuzeJyqfp288mYeryP T41aA7b8OYNPCmDL2hGGNqLJki2hZSv2LwXfWYiTTfgbIn229tu0Z+/MzAladUCmvizZ Ggak53IXclh2TNYXZJzCM70e3gSriGjd501jwNYCrMghP4nTDgYRfd7xGjSxP6hwAQjv /i3aIHmj0m5DCKvGmFCKjly1rSErBQLdzoZjbwoaHaI+jn9WBGchHIjDkCfmbzb9flv9 2nIuXDsRpwc+CwZJs24Il9W70POAsR4UmF3YanSIgyYbGTQzjV544XMhaiYTUbRfqGik K/tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=AKDr1EIfUImn2/wEIHI3/liXQc5NPp7gGgAH9xK2dQA=; b=jnmzcrX/vVspfrTZ6RxzwD9sg0rSIJUEwpiuIgxCAfTk7dt3C2CeMYVN4VLaOhnju3 UgX3g3yCPW4Q5el57w+2CSfxki784EVqFLtfRkna1obEs7Q8F+aU/fBKRkHkUlqR63fI nV60UCtTG5pTuJ7wQQqP+O6jzuZyfuNgAUOPjFSDFRd2DjrQRe0+F5HYpjpXlyfFoq1F sMYQsZbUX56MqQ00WxWdeu1qI3eRHek/jGfZaD1OxIDzvGv4mlHMEkB/KNZEAULxt58z NgoM0800ZDSIxXwnkuXuiD23oyhAT24bQkK2bB+DFnRt8cUX/klEdvnrtIB65i9dpCBp kOzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d20-20020aa797b4000000b005180d1a94e9si49085868pfq.287.2022.07.08.01.02.58; Fri, 08 Jul 2022 01:03:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237129AbiGHIAM (ORCPT + 99 others); Fri, 8 Jul 2022 04:00:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230384AbiGHIAL (ORCPT ); Fri, 8 Jul 2022 04:00:11 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D937E65D7E for ; Fri, 8 Jul 2022 01:00:10 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1o9itw-00FrrO-EQ; Fri, 08 Jul 2022 17:59:49 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 08 Jul 2022 15:59:48 +0800 Date: Fri, 8 Jul 2022 15:59:48 +0800 From: Herbert Xu To: Liang He Cc: davem@davemloft.net, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH v2 1/2] crypto: amcc: Hold the reference returned by of_find_compatible_node Message-ID: References: <20220630083657.206122-1-windhl@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220630083657.206122-1-windhl@126.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Jun 30, 2022 at 04:36:56PM +0800, Liang He wrote: > In crypto4xx_probe(), we should hold the reference returned by > of_find_compatible_node() and use it to call of_node_put to keep > refcount balance. > > Signed-off-by: Liang He > --- > changelog: > > v2: split v1 into two commits, use short coding format for 'np=xx;' > v1: fix bugs in two directories (amcc,nx) of crypto > > v1-link: https://lore.kernel.org/all/20220621073742.4081013-1-windhl@126.com/ > > drivers/crypto/amcc/crypto4xx_core.c | 40 +++++++++++++++++----------- > 1 file changed, 24 insertions(+), 16 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt