Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp205286imw; Fri, 8 Jul 2022 01:06:00 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vv5vwPFa3eRSALiRTHfC3TIaJu0caXcExwtJCIYQaBk8E+9jRD6c0RKDla5J1rhsW1Wcm/ X-Received: by 2002:a17:906:8a58:b0:72a:d029:d92e with SMTP id gx24-20020a1709068a5800b0072ad029d92emr2208297ejc.354.1657267559991; Fri, 08 Jul 2022 01:05:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657267559; cv=none; d=google.com; s=arc-20160816; b=wrE2+bXyEqjEtJPgBaZgRLGxcPB7PPyB7VlROIWO78HfiuXrU5ELglYDgjJeuPYN+v diCNDcC2LDNSlBBxQUSqfjEEnaRB5BK/iJkp0mAlXrjn5rJjkOtROvd5Zyi66ak05pGb xFJsA1hPnvOgLnmeUAKgdpoBROpeteCfHMQRPXfH+vlku8iokf7MBmk5+yaPHzU17mm1 LrmQKb8LVvuDJu2pwG2MYxAZI4ChRtAM2YUoTwi6qFpci4+oher3yotx+3t8q65AggAy 60rh72qkS0VgQiQsMPY0Au/PbuhTcLKUbL29iZ6YKvU75rjXqyIrPKjn+7Ra1QSZitLe 3m1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Bgmp7Y49ik1s7vcdCMs//WLDLPPKr9iskkLGEdimCHs=; b=bP1yNoKxNjrAgJnXmAzgogCsKCW/HicJTEs/PtgLdWyjKuSi1xaivhjYsNb6rV8EVu tGK0Qb2TseKdk2gv5aBzt+C5K2MqO8VPmhqSREWqlkDlmrptvyLvgBmhu+nfAaRkxqCL 5pCTXEWI/SxWf930VQ3iMNZ3r+7VAZ3P8IddttqTG+bzUQPRpWmj2vLMhDJiEfohNWcc rVkTlxwNn9Lb4/h5bGqkg4eiEcAviwF+xBN/iDhOLPyh+igZQod87PsOsw7zyG0tn+z4 xb9WFjA6v/SQs/zkTZYk1qmFZ1cicPwCOO4H1o4PNq5X/N4eiWP+x5LPC2wWZMK22PB8 NTzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o8-20020a170906974800b00722e1f93942si5230110ejy.333.2022.07.08.01.05.35; Fri, 08 Jul 2022 01:05:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237462AbiGHICZ (ORCPT + 99 others); Fri, 8 Jul 2022 04:02:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237278AbiGHICZ (ORCPT ); Fri, 8 Jul 2022 04:02:25 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CCB77E01F for ; Fri, 8 Jul 2022 01:02:24 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1o9iwK-00Frwo-1R; Fri, 08 Jul 2022 18:02:17 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 08 Jul 2022 16:02:16 +0800 Date: Fri, 8 Jul 2022 16:02:16 +0800 From: Herbert Xu To: oferh@marvell.com Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, atenart@kernel.org Subject: Re: [PATCH] crypto: inside-secure: fix packed bit-field result descriptor Message-ID: References: <20220702071426.1915429-1-oferh@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220702071426.1915429-1-oferh@marvell.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Jul 02, 2022 at 10:14:26AM +0300, oferh@marvell.com wrote: > From: Ofer Heifetz > > When mixing bit-field and none bit-filed in packed struct the > none bit-field starts at a distinct memory location, thus adding > an additional byte to the overall structure which is used in > memory zero-ing and other configuration calculations. > > Fix this by removing the none bit-field that has a following > bit-field. > > Signed-off-by: Ofer Heifetz > --- > drivers/crypto/inside-secure/safexcel.h | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt