Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Gaurav Jain <gaurav.jain@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        Vabhav Sharma <vabhav.sharma@nxp.com>,
        Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
CC:     Horia Geanta <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: RE: [EXT] [PATCH crypto-next] crypto: caam/qi2 - switch to
 netif_napi_add_tx_weight()
Thread-Topic: [EXT] [PATCH crypto-next] crypto: caam/qi2 - switch to
 netif_napi_add_tx_weight()
Thread-Index: AQHYkMLh4MjakZTCuEmrih07fQSLsK10PEnQ
Date:   Fri, 8 Jul 2022 09:45:34 +0000
Message-ID: <VI1PR04MB534278EC3B0FD825ACD73E43E7829@VI1PR04MB5342.eurprd04.prod.outlook.com>
References: <20220705225857.923711-1-kuba@kernel.org>
In-Reply-To: <20220705225857.923711-1-kuba@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SZRdA3eh+iVGpptrBDjTdryz5i2dQVPJ7KjzHXFH/4792baokfwBQvnLmpjM?=
 =?us-ascii?Q?ippkp6brDMp2GMYAeONhujn1AZFrFpshEfrh0BV+JIppX0n4W6rIVEObTpTc?=
 =?us-ascii?Q?hP8zZvkxPjJS0dcfzvcJAZaB2A30WspetsM75OpswCsFYCoNT8jT4mXTID/9?=
 =?us-ascii?Q?RrS+LAe17PqURcMHQzj5hqzYG6NYPxySVR4l/Qnl0EAUjxubCaaHCAn4A8w+?=
 =?us-ascii?Q?UZv1mkNzs/qLcw2xuAmG3mCsy10ErnJc83yN9vkaBsjJBezvI5H1+B70WfuL?=
 =?us-ascii?Q?EPh8l+GLrbn2bJM3xJLw4Enh4JFAGO8tsdJbl0cHHBeEM7jfINdmKVlRonRJ?=
 =?us-ascii?Q?MrWzo9SsvlCrGTaKOYnXCXoEAUmNKyEFQOUt9CKxbbkPf9gclS9mdlSPfncT?=
 =?us-ascii?Q?tIsbIb4tudnQylltwoI5rThNGlqCfjK3TK3ddaxPtpz+w1yWz3OnF1JknZWE?=
 =?us-ascii?Q?X7mfyTGZ6twS0bZmwxzwP703AnhuMU4owoYyIcwOmn+jl7bX8ih3/ICHsyX/?=
 =?us-ascii?Q?Df5ZP5L7quGo2RmyiGXGhVbsryDJKqmuh9ZtrvWME0Cffuuv8tRmgvfm7NFe?=
 =?us-ascii?Q?F+8F4BgITkZ0qFgiY+AkfBb9WgAmJZyouVWjFpdEzguQLWlnwTDrgOgEgcmw?=
 =?us-ascii?Q?/SH6mxLwipisscAT25gW7DyA94o6ICiLyjq1HhS9Aodlcc2JYDp3JX0EgkAt?=
 =?us-ascii?Q?pFp9fQdJj9/MDNEn1BQi9SsUZh+5W0D9fBAZ0ZKZQwGuzpBVa+QykjwHl7R8?=
 =?us-ascii?Q?licEPPqhtDgR3WcP157ylNuBd1HU5knq8HL3UI/nt1pU+FXct8GDmxPcJS+F?=
 =?us-ascii?Q?qFN+wtn7qn/jo375qNwRrRRNaxdukVZjRN8DTc5i7GCIPGtxDYIxfHP3CZCe?=
 =?us-ascii?Q?31YiYZu9bEpqv1BHaHsU3xalmzdf9qu3cl0YoF6KYAB9VaOtD08MPdpCOOmi?=
 =?us-ascii?Q?0wGGsqHkrF84H7lMkwczI+dFVPR/vWVgUVnlUmyFMynhYn4Z8KatZbwlu9LS?=
 =?us-ascii?Q?IR/mHXO6DXk625O9+onOYSa7piYjr1YUD743drz5fK4Zxcy0cE89tbpZQKmV?=
 =?us-ascii?Q?s8Hnw0m5ynuKllwWbANoUDEaaDqEDAtPWKmF82s5vu1sLh5KoPRpLcGjD+MC?=
 =?us-ascii?Q?F9NPO+WmGu8JNfGP0ZTkJR6asYYz9SnUSCYib2HNy+O5aKvSBhblKXqg6PRb?=
 =?us-ascii?Q?gL82P9qEHQyul24z+uytM1ps+8H71CEjq5FVh7ChQVgJABKjlVw8QNMLUrzW?=
 =?us-ascii?Q?Svrj2ZlSPZ9cUXGoiZsdN3ao2oISsHfyiMOKKeeExlGJ6NC/1JrkUkj8b9P6?=
 =?us-ascii?Q?NICl0z1L2KSVP2x89n1LXmdbmej80+qEfyqxdvLJ+YKwIQ4Em0h+jamNeWW1?=
 =?us-ascii?Q?zLh0btlTqJP8++qtJWOinOvDvss+RouVPmFGFxOYYgoNMq66KcHwVMvl88/Y?=
 =?us-ascii?Q?juWfiiZ+htszc3LC1Q3y7ARly3uu7A8AmtreIMHhMYs6l0QLOa+7xmMLsblu?=
 =?us-ascii?Q?8zuCNPpsRe7loh15Qn0XZkipQzWn3UW6mfg90g6pF0V5z1chVBA/Ly6LzC4X?=
 =?us-ascii?Q?oOOlRyagrgUaZDqLhSsGE3bAOJTOArNDtZBzk5Oc?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5342.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fa81556-9236-436b-a00c-08da60c69b31
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2022 09:45:34.9702
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a0BM5WeXwhFHHdg56YNnBITbFk5XfTa8hJH+3ouzohg5uVDGg7t0Ko/PPmZoz3J94sMfhrOvq0wT+GcTph6dEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4762
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi Meenakshi, Vabhav

Please help to review the below patch..

Regards
Gaurav Jain

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Wednesday, July 6, 2022 4:29 AM
> To: herbert@gondor.apana.org.au
> Cc: Jakub Kicinski <kuba@kernel.org>; Horia Geanta <horia.geanta@nxp.com>=
;
> Pankaj Gupta <pankaj.gupta@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>;
> linux-crypto@vger.kernel.org
> Subject: [EXT] [PATCH crypto-next] crypto: caam/qi2 - switch to
> netif_napi_add_tx_weight()
>=20
> Caution: EXT Email
>=20
> caam has its own special NAPI weights. It's also a crypto device so presu=
mably it
> can't be used for packet Rx. Switch to the (new) correct API.
>=20
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: horia.geanta@nxp.com
> CC: pankaj.gupta@nxp.com
> CC: gaurav.jain@nxp.com
> CC: herbert@gondor.apana.org.au
> CC: linux-crypto@vger.kernel.org
> ---
>  drivers/crypto/caam/caamalg_qi2.c | 5 +++--
>  drivers/crypto/caam/qi.c          | 4 ++--
>  2 files changed, 5 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/crypto/caam/caamalg_qi2.c
> b/drivers/crypto/caam/caamalg_qi2.c
> index 6753f0e6e55d..56bbfdfb0d9f 100644
> --- a/drivers/crypto/caam/caamalg_qi2.c
> +++ b/drivers/crypto/caam/caamalg_qi2.c
> @@ -5083,8 +5083,9 @@ static int __cold dpaa2_dpseci_setup(struct
> fsl_mc_device *ls_dev)
>=20
>                 ppriv->net_dev.dev =3D *dev;
>                 INIT_LIST_HEAD(&ppriv->net_dev.napi_list);
> -               netif_napi_add(&ppriv->net_dev, &ppriv->napi, dpaa2_dpsec=
i_poll,
> -                              DPAA2_CAAM_NAPI_WEIGHT);
> +               netif_napi_add_tx_weight(&ppriv->net_dev, &ppriv->napi,
> +                                        dpaa2_dpseci_poll,
> +                                        DPAA2_CAAM_NAPI_WEIGHT);
>         }
>=20
>         return 0;
> diff --git a/drivers/crypto/caam/qi.c b/drivers/crypto/caam/qi.c index
> 8163f5df8ebf..1c9450b29583 100644
> --- a/drivers/crypto/caam/qi.c
> +++ b/drivers/crypto/caam/qi.c
> @@ -749,8 +749,8 @@ int caam_qi_init(struct platform_device *caam_pdev)
>                 net_dev->dev =3D *qidev;
>                 INIT_LIST_HEAD(&net_dev->napi_list);
>=20
> -               netif_napi_add(net_dev, irqtask, caam_qi_poll,
> -                              CAAM_NAPI_WEIGHT);
> +               netif_napi_add_tx_weight(net_dev, irqtask, caam_qi_poll,
> +                                        CAAM_NAPI_WEIGHT);
>=20
>                 napi_enable(irqtask);
>         }
> --
> 2.36.1