Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b707a74b-48ca-5547-3d07-8aa05be0c132@infradead.org>
Date:   Sun, 10 Jul 2022 17:36:04 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH -next] certs: Fix Kconfig dependency
Content-Language: en-US
To:     Ren Zhijie <renzhijie2@huawei.com>, dhowells@redhat.com,
        herbert@gondor.apana.org.au, davem@davemloft.net, simo@redhat.com
Cc:     keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220704112028.183193-1-renzhijie2@huawei.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220704112028.183193-1-renzhijie2@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/4/22 04:20, Ren Zhijie wrote:
> If CONFIG_PKCS7_MESSAGE_PARSER=m and CONFIG_FIPS_SIGNATURE_SELFTEST=y,
> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this:
> 
> crypto/asymmetric_keys/selftest.o: In function `fips_signature_selftest':
> selftest.c:(.init.text+0xc3): undefined reference to `pkcs7_parse_message'
> selftest.c:(.init.text+0x101): undefined reference to `pkcs7_supply_detached_data'
> selftest.c:(.init.text+0x112): undefined reference to `pkcs7_verify'
> selftest.c:(.init.text+0x13f): undefined reference to `pkcs7_validate_trust'
> selftest.c:(.init.text+0x169): undefined reference to `pkcs7_free_message'
> make: *** [vmlinux] Error 1
> 
> To fix this error, add depends on PKCS7_MESSAGE_PARSER=y to FIPS_SIGNATURE_SELFTEST
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 3cde3174eb91 ("certs: Add FIPS selftests")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
> ---
>  crypto/asymmetric_keys/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
> index 3df3fe4ed95f..fe007db96c69 100644
> --- a/crypto/asymmetric_keys/Kconfig
> +++ b/crypto/asymmetric_keys/Kconfig
> @@ -83,6 +83,6 @@ config FIPS_SIGNATURE_SELFTEST
>  	  for FIPS.
>  	depends on KEYS
>  	depends on ASYMMETRIC_KEY_TYPE
> -	depends on PKCS7_MESSAGE_PARSER
> +	depends on PKCS7_MESSAGE_PARSER=y
>  
>  endif # ASYMMETRIC_KEY_TYPE

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Reported-by: kernel test robot <lkp@intel.com> # 2022-06-30

thanks.

-- 
~Randy