Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Jul 2022 17:58:09 +0000
From:   Eric Biggers <ebiggers@kernel.org>
To:     "Guozihua (Scott)" <guozihua@huawei.com>
Cc:     linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        catalin.marinas@arm.com, herbert@gondor.apana.org.au,
        davem@davemloft.net, zengxianjun3@huawei.com,
        yunjia.wang@huawei.com
Subject: Re: An inquire about a read out-of-bound found in poly1305-neon
Message-ID: <YsxksSnCsk3TQVD+@gmail.com>
References: <65952163-6b78-a02a-ba14-933807d3cfec@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <65952163-6b78-a02a-ba14-933807d3cfec@huawei.com>
Precedence: bulk

On Mon, Jul 11, 2022 at 09:34:49PM +0800, Guozihua (Scott) wrote:
> Directly calling poly1305_init_arm64 instead of poly1305_init_arch() is also
> tried but it would fail the self-test as well.

I think that's the correct fix.  Are you sure it fails the self-test?  It should
look like:

	poly1305_init_arm64(&dctx->h, src);

Just like the arm32 version in arch/arm/crypto/poly1305-glue.c.  Note that
&dctx->h must be used rather than just dctx.

- Eric