Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <107b496c-8106-b262-2731-444bd5e6e6d6@huawei.com>
Date:   Tue, 12 Jul 2022 09:57:50 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: An inquire about a read out-of-bound found in poly1305-neon
Content-Language: en-US
To:     Eric Biggers <ebiggers@kernel.org>
CC:     <linux-crypto@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <catalin.marinas@arm.com>,
        <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
        <zengxianjun3@huawei.com>, <yunjia.wang@huawei.com>
References: <65952163-6b78-a02a-ba14-933807d3cfec@huawei.com>
 <YsxksSnCsk3TQVD+@gmail.com>
From:   "Guozihua (Scott)" <guozihua@huawei.com>
In-Reply-To: <YsxksSnCsk3TQVD+@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/7/12 1:58, Eric Biggers wrote:
> On Mon, Jul 11, 2022 at 09:34:49PM +0800, Guozihua (Scott) wrote:
>> Directly calling poly1305_init_arm64 instead of poly1305_init_arch() is also
>> tried but it would fail the self-test as well.
> 
> I think that's the correct fix.  Are you sure it fails the self-test?  It should
> look like:
> 
> 	poly1305_init_arm64(&dctx->h, src);
> 
> Just like the arm32 version in arch/arm/crypto/poly1305-glue.c.  Note that
> &dctx->h must be used rather than just dctx.
> 
> - Eric
> .

Thanks Eric, I'll have a try!

-- 
Best
GUO Zihua