Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <00e710db-3fcd-1fb7-3d19-b5761e241adc@huawei.com>
Date:   Tue, 19 Jul 2022 11:31:02 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.0.2
Subject: Re: [PATCH] crypto: hisilicon/hpre - don't use GFP_KERNEL to alloc
 mem during softirq
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <liulongfang@huawei.com>, <davem@davemloft.net>,
        <xuzaibo@huawei.com>, <weiyongjun1@huawei.com>,
        <yuehaibing@huawei.com>
References: <20220719021042.250882-1-shaozhengchao@huawei.com>
 <YtYT+JeYj7vlz9Xp@gondor.apana.org.au>
From:   shaozhengchao <shaozhengchao@huawei.com>
In-Reply-To: <YtYT+JeYj7vlz9Xp@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/7/19 10:16, Herbert Xu wrote:
> On Tue, Jul 19, 2022 at 10:10:42AM +0800, Zhengchao Shao wrote:
>>
>> @@ -252,7 +252,7 @@ static int hpre_prepare_dma_buf(struct hpre_asym_request *hpre_req,
>>   	if (unlikely(shift < 0))
>>   		return -EINVAL;
>>   
>> -	ptr = dma_alloc_coherent(dev, ctx->key_sz, tmp, GFP_KERNEL);
>> +	ptr = dma_alloc_coherent(dev, ctx->key_sz, tmp, flags);
> 
> How about just using GFP_ATOMIC unconditinoally?
> 
> Cheers,

Hi Herbert:
	Thank you for your reply. I think differentiate the application 
scenarios of GFP flags, which can be more suitable to allocate memory.

Zhengchao Shao