Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4040760imw; Mon, 18 Jul 2022 20:48:33 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ugm+fl/mr32Z8s97kOJLdm1De75kX//cxEMRuqgKgHvQ432dmsfj8SbSCwTrgi7mJkq2xi X-Received: by 2002:a17:907:7213:b0:72b:9ec4:9a63 with SMTP id dr19-20020a170907721300b0072b9ec49a63mr27338598ejc.399.1658202513687; Mon, 18 Jul 2022 20:48:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658202513; cv=none; d=google.com; s=arc-20160816; b=FXv2QRewA6SKBEDfqOH3GLi6Mrlbt/W46ikyhLC5jTegm5bWgyc0TgAQJCfObmcUq8 XUBLL/v+Ox1nS4VDIlr/VjKpgIQsvoEIz81Ai3qJYb8rxcvkjyaeEvsi2PbvN4XEvj6A IVTVarShFkFMqphhPrnTMydkuPQcyT6r12KCBu+hbuZJNz4WvoGCjNeRljJsSFS5BXXV 802x/JoIcIs/4h3EtUWEu4IX7QJq2H8vahQ1mHATtbTeeIxs/sTfxfMJTIR8BS9KxbzS f29mWXdKjycu06EW/D4ThEbFjIxJDDzl3cmJyYxBe/6zFC+xhbbNZlqYAjc9bIyggzq3 3rWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=KqOw1thi8crkf6t3f3QPT89IEYyaSAZfaSmG89N4Wo8=; b=sA4Yr9Y5xM/gCJgBOgbTzTuFCyxFJ+QQv6v89a212jS5rJ0g4he2elKxV6jayL1/vQ yC4RPlyDYviiI05nWzoD8CVXUFqlZjI8ztV8J6YNj2Ps22Bc29vN4XXZJTtsStbEwDsH lvtZ77Mib/FeYXTO3ovvHcbdr3SyK0svcoT7U9lEmUU4RwJYhVuX0xS7F4W1Jfy8SYPw xS9gXRN4SPW2PlKpVn3oleSZ+YVEyyJ2HtqAt3EFDHFNucYn5oTCJRFy8NguouU5GzLZ GR3yfFmDbW2A1dC0dnS4t0xjYZLzO3nUc9VBocFmf3kzmZ1hDsU99Kuk1dzFKqmKc7AS tF7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r5-20020a056402034500b0043acb8a22e9si16170399edw.340.2022.07.18.20.48.07; Mon, 18 Jul 2022 20:48:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234323AbiGSDrj (ORCPT + 99 others); Mon, 18 Jul 2022 23:47:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230165AbiGSDrj (ORCPT ); Mon, 18 Jul 2022 23:47:39 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 882C72018B; Mon, 18 Jul 2022 20:47:37 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oDeCp-001xuh-4W; Tue, 19 Jul 2022 13:47:32 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Tue, 19 Jul 2022 11:47:31 +0800 Date: Tue, 19 Jul 2022 11:47:31 +0800 From: Herbert Xu To: shaozhengchao Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, liulongfang@huawei.com, davem@davemloft.net, xuzaibo@huawei.com, weiyongjun1@huawei.com, yuehaibing@huawei.com Subject: Re: [PATCH] crypto: hisilicon/hpre - don't use GFP_KERNEL to alloc mem during softirq Message-ID: References: <20220719021042.250882-1-shaozhengchao@huawei.com> <00e710db-3fcd-1fb7-3d19-b5761e241adc@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00e710db-3fcd-1fb7-3d19-b5761e241adc@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jul 19, 2022 at 11:31:02AM +0800, shaozhengchao wrote: > > Thank you for your reply. I think differentiate the application scenarios > of GFP flags, which can be more suitable to allocate memory. You need to have a very strong reason to do this. I don't think it's appropriate here. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt