Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <188ecbc9-8624-2b74-7963-5f1b909ddf2f@amd.com>
Date:   Wed, 20 Jul 2022 07:58:06 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] crypto: ccp - Add support for new CCP/PSP device ID
Content-Language: en-US
To:     Mario Limonciello <mario.limonciello@amd.com>,
        John Allen <john.allen@amd.com>
Cc:     Rijo-john Thomas <Rijo-john.Thomas@amd.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220719161328.7907-1-mario.limonciello@amd.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20220719161328.7907-1-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dE14MDFJOU9IYjYxSHZaZmI2WHFvVWdFUXBCVjVxbCs0eCtFNG9iQW5nZ013?=
 =?utf-8?B?bWJwZjlidVVVQ3QzVUFiR1IxRlJnZ3hLZEdwc2J3ekEyOHJ1Y0pvQlRReGl1?=
 =?utf-8?B?OElWN3FXeThEdW41elY3Ykp2eFRvc3ZJY3lWSWRCUmRsOENKZm5sOHlxNmZx?=
 =?utf-8?B?TWlPa3llZU51SFdVMEptelFVOTlFbU12U1E0K21QTE5CaUF2UzBITE9VM3pJ?=
 =?utf-8?B?TnZmdjRidXdiUTFBOVpGS0pDS3FXaUN1bXdpZ0h3alRrOWJ5cXl0RGRxNU0v?=
 =?utf-8?B?bUp1Ym43MlNjOUxxQityQzVQUG5tcTMzWEZSbURZTmtwNzV6QmFYNTZqdFVy?=
 =?utf-8?B?V3lLdUFGSUhuRzhQcERhc1JHa2lQdGR6VnlSTm9ILzBDYVBnNjJxbWpQOTNa?=
 =?utf-8?B?b2FjNlZCMThqN2pvWUdWV0JrZGY0Nmkzb2Z0UGZDL0h4T0g3RUlEMmVPVkxT?=
 =?utf-8?B?ZWY5TTdCSk5FV1VxakZBYkszZTVrcG93c3ptamliTGRWbVpWUWl6MzBzMzdi?=
 =?utf-8?B?TXJzN1g4THhxWW9DNXhEMVB5UVlqZHQ4UndIVUdJTC9TdERJMy9XZ1hVRS93?=
 =?utf-8?B?eVkwL2RXSlF3b1hPV3A5VzI2OGxLWnd0bVhpSkZWV0dRdUZrU01BTGYrcW9D?=
 =?utf-8?B?MXdqeHhLN0lML0dZYUVKUHRGSExNdVpPeEdXV0Vpd0MrdTdIOVQ0dlNKS05j?=
 =?utf-8?B?bDVOY0NGR2FCT3JpeE14bFhkWVFubHF2MlRjMkNRZEhpWG9ZdmU0NjYreU9W?=
 =?utf-8?B?dktRajZQdm1hZGZxam1yRmlVRytrMm14RUwrZmc5b0kvTXBUVVpWY1NLT0tk?=
 =?utf-8?B?S1J3VHQ3ei95RnpQemVFWEZ4YitqZVJ0ZnFmdkFOTm1tMk9NNzJCL1Vwd2dv?=
 =?utf-8?B?QUFDYW8wUkRwZEsxTUtlZmZUd1pncmdkRGZGRnNsaG1EWkNXaGhNaVpNTzdo?=
 =?utf-8?B?Ym1RU0RySDV0QWwza0hLTnZIU2FmREFuNnRwNml6S2dXMDNYRUxnSnZnUGQ3?=
 =?utf-8?B?WlVoWHFUeXNDdzJtTkRzMGtBR0dCRE9vbXRaT0JwMU91MHg1Y05lZ0Q5cjFZ?=
 =?utf-8?B?blVDNHU5QWJMeHo3ZXFYZ3p1UGhNeWdGVGNXcSt4MXRoaTBMcGRWTmxsWHNr?=
 =?utf-8?B?ZHBia2lGZ3owZTVyelppUTBCUUhKTVZGaG0zL1FpeG40blFodXRRYUY1MzZW?=
 =?utf-8?B?NldFcVRabjUraGhTRlV3ZHo2enFHbUFrRHVxbnhiY2htNTBvcXdtdXpPcldC?=
 =?utf-8?B?aUMrV1ZGSXNIalo4OUVYQjM3NVBob1l6Tmx0QlI1V3NzRlV0ZWJBb1ZDVmpz?=
 =?utf-8?B?d1hXem9tV2dQNTVVNnR0bUN0N2dzVlpXdTR3dm5wVFFyQlRQSXlmQW1ZVzVy?=
 =?utf-8?B?OUdaMTJFVXgrb0grczJxNWJSQWMvV0piZW02QWVsWHFmOC83MW56eVZXQ3cv?=
 =?utf-8?B?YUtld0ZiVG1VL0ZIOEN6dXlrdTRWazRtOHNKemQ2YWEvT0tSN1BVS0x4U1hC?=
 =?utf-8?B?bXkyRkFubWdmT01zWFNHNjA2TkVRR2VVR1lxZHJPUWg3cVhTQjFBWUJqWFNW?=
 =?utf-8?B?cW1JRUt2QzNuYXhQKzQ4L0V1S25ZTWd5TUNTOUJmNW8vVVI4QUlMVDRKdE9z?=
 =?utf-8?B?UVhOQXdWRFA3bzdZU0gyWDk0dUN0b3BmQXN2SmZuSTNPZWFvenExeDcxOXpD?=
 =?utf-8?B?SFRHalVSaUpDQkgra2Nha3JjblNLQms5d2o2WlJmR3k2aVBFZ3ZCOHBhZXcz?=
 =?utf-8?B?Zkh4Q244V1l3TkhoaVg4MGgzZndRWlRPSnNnOU5YVFRWWS9QZ0dzcEZpb3N3?=
 =?utf-8?B?cnNjdm9zcWxtNDZsZXFqQmJkS0I1aHcxS3hxTjR4Qzg3b1M0bTRnSGpRazlP?=
 =?utf-8?B?WEtwYlUrbkVmWC92RWVZUEQ1Q2R6NWdzZ21nRTF2VjUyQkRRRk84K285SVFu?=
 =?utf-8?B?WVEwZWo1Q3E2WXVHRHhHdTEvOWhRRWJWS3N3MWhMUGpURjhrYVF4OGVDZm9v?=
 =?utf-8?B?MUpYM3psTnpVdVhCL2grV1VzbVJFeEVtOVFZaXd3UGk5K0lQMTBpYi9qWkhZ?=
 =?utf-8?B?VDRVdkJFZkxCNnExL2U0S0pJWlZhYkZwRzlnNTdGNy9XQXRyVEVjOU5hZ0h2?=
 =?utf-8?Q?dKlx61ASqMoBt/oqftSsyinbe?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f0dca42-5baa-4dcf-ae09-08da6a4f7e90
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 12:58:08.6280
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8G+0b6MpfCVYHP5cuy+d91x6VHdxSlsbDHJdqqM5QL+xWHBIenjKO+ic+6GQQogtct8eE+OgFjzWV+qzbqMa3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2552
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 7/19/22 11:13, Mario Limonciello wrote:
> Add a new CCP/PSP PCI device ID.  This uses same register offsets
> as the previously supported structure.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   drivers/crypto/ccp/sp-pci.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index b5970ae54d0e..792d6da7f0c0 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -427,6 +427,12 @@ static const struct sp_dev_vdata dev_vdata[] = {
>   		.bar = 2,
>   #ifdef CONFIG_CRYPTO_DEV_SP_PSP
>   		.psp_vdata = &pspv2,
> +#endif
> +	},
> +	{	/* 6 */
> +		.bar = 2,
> +#ifdef CONFIG_CRYPTO_DEV_SP_PSP
> +		.psp_vdata = &pspv3,
>   #endif
>   	},
>   };
> @@ -438,6 +444,7 @@ static const struct pci_device_id sp_pci_table[] = {
>   	{ PCI_VDEVICE(AMD, 0x15DF), (kernel_ulong_t)&dev_vdata[4] },
>   	{ PCI_VDEVICE(AMD, 0x1649), (kernel_ulong_t)&dev_vdata[4] },
>   	{ PCI_VDEVICE(AMD, 0x14CA), (kernel_ulong_t)&dev_vdata[5] },
> +	{ PCI_VDEVICE(AMD, 0x15C7), (kernel_ulong_t)&dev_vdata[6] },
>   	/* Last entry must be zero */
>   	{ 0, }
>   };