Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp418511imi; Fri, 22 Jul 2022 01:49:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uhkNFSE2kxW2wUSai9uAYJjPzKqCMQGt++ykd23soP7j1QY3tAOIZ8Mvqt9e5KruM1yecT X-Received: by 2002:a17:906:7e43:b0:72b:52de:b039 with SMTP id z3-20020a1709067e4300b0072b52deb039mr2293262ejr.198.1658479747731; Fri, 22 Jul 2022 01:49:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658479747; cv=none; d=google.com; s=arc-20160816; b=E8aYjSQLrhYBv0W46xwIMMIMu89DTBHqYR/BBnRj28JojYDAq7AWIrtygA69JBcKKk lyrS9RBAp5IDT2QaMUrvknE6RpJqCM2xyUwHE1GKuVvuxzMjpcvNNR0UNnxbov130X1H xUwXOBta58G3oDoFpLcgNPTZV8HNHvII9N/g6X17AQOPZ7bVD1Zl2gU7zfFYUI0P798X YPFo+ZNVdMHtozk6fd+gTjE6mre3Txi9rF6m9g+l/NbZ+wwcGkcRzca1I441Fj06Mecb QhWJVbAWYcGs5mOgbzFRprq72ug7zmcL0CcVyJyQ0tSB73NTbSdSEub4i40rklsbeGnt GBTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=kOzB9yoO4hrn7QWbjrTMeXQgh2J75l+xzLDRkNlOb9w=; b=EWxopsQtt2KV44pMPusTvqDkgkc00kQJ+W04TYpgg0p3CwnyiiiCEK7Aa/qjwf9Jsv 0ugMeDzyHNfqgNVa9IPsVQ/cAR7FhlsNM3uxsp9zDH7uI+9TrVPjzzDzTz/qOoN1o8SH ygS6dCJqHqlVTiUj21xilMH+WmLuoisM6fxqP6Vd5vacRWl+Zmbih1OLMhsc2x5IYFgh OPY27icHbrWnfoT3mQBDo7LfAUrW5FEaGvJoXiYoiECl5AdpAJK0fZy/dD8zf51LjJy/ 2CMynF7VYNeAolrwZYMvZ59cc56xDPBA2QgAs+gQUpSnaSFGcc4808CvDuxa/QwhSOYx /Xlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b14-20020aa7c6ce000000b0043a7080a79csi4310208eds.508.2022.07.22.01.48.43; Fri, 22 Jul 2022 01:49:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234474AbiGVIr0 (ORCPT + 99 others); Fri, 22 Jul 2022 04:47:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234488AbiGVIrX (ORCPT ); Fri, 22 Jul 2022 04:47:23 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 833435F7D; Fri, 22 Jul 2022 01:47:22 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oEoJa-003HWP-Fw; Fri, 22 Jul 2022 18:47:20 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 22 Jul 2022 16:47:18 +0800 Date: Fri, 22 Jul 2022 16:47:18 +0800 From: Herbert Xu To: Ignat Korchagin Cc: "David S . Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@cloudflare.com, Eric Biggers Subject: Re: [PATCH] crypto: testmgr - some more fixes to RSA test vectors Message-ID: References: <20220717133746.918-1-ignat@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220717133746.918-1-ignat@cloudflare.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Jul 17, 2022 at 02:37:46PM +0100, Ignat Korchagin wrote: > Two more fixes: > > * some test vectors in commit 79e6e2f3f3ff ("crypto: testmgr - populate > RSA CRT parameters in RSA test vectors") had misplaced commas, which > break the test and trigger KASAN warnings at least on x86-64 > > * pkcs1pad test vector did not have its CRT parameters > > Fixes: 79e6e2f3f3ff ("crypto: testmgr - populate RSA CRT parameters in RSA test vectors") > Reported-by: Eric Biggers > Signed-off-by: Ignat Korchagin > --- > crypto/testmgr.h | 102 +++++++++++++++++++++++++++++------------------ > 1 file changed, 63 insertions(+), 39 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt