Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] crypto: ccp - Add support for new CCP/PSP device ID
To:     Tom Lendacky <thomas.lendacky@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        John Allen <john.allen@amd.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220719161328.7907-1-mario.limonciello@amd.com>
 <188ecbc9-8624-2b74-7963-5f1b909ddf2f@amd.com>
From:   Rijo Thomas <Rijo-john.Thomas@amd.com>
Message-ID: <edd96cb6-aa74-bc21-9275-ca9e1f80c100@amd.com>
Date:   Mon, 25 Jul 2022 13:10:30 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
In-Reply-To: <188ecbc9-8624-2b74-7963-5f1b909ddf2f@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjZ6eWJyaVpRVlYxYVMvbWNnTkhMYjM1Yy80TnV5akE1dzdpa0hXc1hoUGto?=
 =?utf-8?B?N3YrVVpUZUhFaGoyQlVubmlkTEo0MFQ1VXNOQnF5ZWcrNUJsZGZTOFZvMmNU?=
 =?utf-8?B?aXlNRCttempBUzlGZUJvbytOcy9mTmxQUUlmdmhNRFlpSGZ0TnZrWDQ0NHht?=
 =?utf-8?B?dVdSMS9tblZXZzhqOHMrSld0emNWL0s1bE5XMkVnZlpIbkZVMDVtT3IxVXlR?=
 =?utf-8?B?NkN6dzdIZEZNaGdTYXBZaVdYOWc4R25nZnhlaFJiRkVaOE9XYmdsQUt1QWVG?=
 =?utf-8?B?TWs3UXdSMDBiYXR2UnhWcWZDcUU4YWc3dWJoM2QraklhT2xGUzJVcjY4REpk?=
 =?utf-8?B?dW9yR0lOQ1VqbnNYa0I4T0RCcExvN0pFTXJ1T0F0U0lIcThXejBzS1Z3MGww?=
 =?utf-8?B?SFRNUm4yQlZVL2ZFNFhxT0VJcG5WWktYVWJreEkxZ3BERUJoNTR0dm1RcU9T?=
 =?utf-8?B?NEovanVueU4yQUYxUDB1OGlKWUF0am1JWWtBUHRobG1WTmdtKzFhTjFBSUpu?=
 =?utf-8?B?UXA3ZWFjRmdldTE0a2VSTnNHdzlTUVZUd1Q3ZDdyLzVNTWVobFc0ZlU0RERt?=
 =?utf-8?B?dTBDWE1qS3NQRXVhRG15am1BVnZxa2RSQnAyZTJmbDBiMTh5TjJ2SXVjNjRF?=
 =?utf-8?B?eWd5QmJyZktZczh5U1p6aWNxVktCZENnU2FkS1JGQlNuY1FBMUFrNUlOdWpS?=
 =?utf-8?B?WmNLY002MUVaWm5oOURTV014V2JNbjd0eUkrOWNmZUNwZjlBTVBtUUl1QXk1?=
 =?utf-8?B?SmEycklCRHRXQzc0SG0xRFdTdFdVMFMvUTR5aEh0K1RZZFdldjBHdjRUTzls?=
 =?utf-8?B?MjJkWnQ3Z1NIMWJUVEJjVDlMeXI2OXEwMlVFVFRMUUlrcDd6QndWLzNqdWpP?=
 =?utf-8?B?eTRCK3BhVlJ1ZFI3S2xiYUkrZTUzSTU1TUIzUlFzdkd1dTVPK3Zjb3p1T1Iy?=
 =?utf-8?B?REpBSFluRGVyZ3lwZXN3TzM3aHlpUXJPaFh3Mnh2ZXM2eDd5bEZSckpTaXhu?=
 =?utf-8?B?UzRLTlRqV09MZytXZ0kxQUZIME5WWXFzdURKV3lkVEYwZS8rblZFRDdiWktG?=
 =?utf-8?B?YktPREI3d09rYkJIZkMwYlFTOW03YXVTVzFQOEpMbHJDVEpqVTJNSUlYTktV?=
 =?utf-8?B?QmNSbUZFR3JsV1YrS3Qyc3N6MzlmeWZDb0FWOHdqZ2xQZHc4YU1NejdEY0xs?=
 =?utf-8?B?aDhJYk8yU0U2dU9yQ2lON2hwaHlZaDJmSW1tWGo4bU5pQzVzTyttcHhDUHU1?=
 =?utf-8?B?NFlMYnI1Z1ZhNFpUdUJ5TkhNd01nemNRYkxib2ZkaXVHSnlTWXQ4V3o2UGNa?=
 =?utf-8?B?VkRjYXpPMEVYYTVBSk5Zalk3VEFvUFNKa3dtQ3o2S3lDdnJvMHJ0UWtXZ2RS?=
 =?utf-8?B?VVQvY25PWXgzZWp3M3ZNamhveEVZdHc3RTMzaEpXNVRoNFVUQndFM0tDenI0?=
 =?utf-8?B?L0UwWkVhSmF1bkdwNmE3VzZSYTBmcURySnIydU9hSXJXYS9yTGhrVFNqcERp?=
 =?utf-8?B?RWN1bXErbkRoc2l6cnNIYXovT1FZNmFlTVF5QU1VV2xGOUxhZHBsNWlBNWVX?=
 =?utf-8?B?SDJ6REJVQmJHSlZWWEVjdnJwSmdJSEpPK1J5KzRNakg2RWtNQ1c2MmtxOWtQ?=
 =?utf-8?B?T1UxZEk3djN3MlZrZmtFSkhQREY0bUdOZDgxNklNNXFIZlV3aFViY0IxVkVO?=
 =?utf-8?B?b3JzUVdpUnJrclFRUnoxYlZWcEJ5QlA3YnRscXpHUmJLcVU0WldsNmQxa2E4?=
 =?utf-8?B?Zjd5UklwL3VYVmVIb2tOcE5oZGpQdTFHSjQvTUxieEFFMGlKZW00SDBWUVJZ?=
 =?utf-8?B?M1Job3I4NjdPcTNmMUwrcCtmUzI3cTB3RFh4bDdRNk5jRmVhdmpmNGQzc0xF?=
 =?utf-8?B?dnFDSlhkaHE0QTFIcHhlTGpjTnZCZi85bkx3THVmb3VYWEV1T0pkNDg5M1hz?=
 =?utf-8?B?bzZCMGphd1pqL0l5dVZSdTZvby9jQzdDc1BIMzZxR28wdUhUZm1FQ2JndFUw?=
 =?utf-8?B?SFJUbXR1ZEZoekd0NHQyMU0wZVZ2R1c5bll0ejMzaFR5cFdPNEVIK3lScTUx?=
 =?utf-8?B?T3IzK1NDMDZhdWMvcWsyalcwMnNKZzVhYUNkSDdWUnduMVZkQjQwN2xPMG9w?=
 =?utf-8?Q?UPPXOVYKvbHD2XRB9XBchZewB?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b07d977-6076-498d-389f-08da6e10faef
X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5346.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 07:40:43.9078
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M0oMtt0ndCrYQKFmqZ3gJBRcGcCvPyLqDPNl6nrxn2iPE7yHeXzk0ZHlFxWR31E5QhgtWFyyIDli6JpFWUvJhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1890
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


On 7/20/2022 6:28 PM, Tom Lendacky wrote:
> On 7/19/22 11:13, Mario Limonciello wrote:
>> Add a new CCP/PSP PCI device ID.  This uses same register offsets
>> as the previously supported structure.
>>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> 

Acked-by: Rijo Thomas <Rijo-john.Thomas@amd.com>

>> ---
>>   drivers/crypto/ccp/sp-pci.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
>> index b5970ae54d0e..792d6da7f0c0 100644
>> --- a/drivers/crypto/ccp/sp-pci.c
>> +++ b/drivers/crypto/ccp/sp-pci.c
>> @@ -427,6 +427,12 @@ static const struct sp_dev_vdata dev_vdata[] = {
>>           .bar = 2,
>>   #ifdef CONFIG_CRYPTO_DEV_SP_PSP
>>           .psp_vdata = &pspv2,
>> +#endif
>> +    },
>> +    {    /* 6 */
>> +        .bar = 2,
>> +#ifdef CONFIG_CRYPTO_DEV_SP_PSP
>> +        .psp_vdata = &pspv3,
>>   #endif
>>       },
>>   };
>> @@ -438,6 +444,7 @@ static const struct pci_device_id sp_pci_table[] = {
>>       { PCI_VDEVICE(AMD, 0x15DF), (kernel_ulong_t)&dev_vdata[4] },
>>       { PCI_VDEVICE(AMD, 0x1649), (kernel_ulong_t)&dev_vdata[4] },
>>       { PCI_VDEVICE(AMD, 0x14CA), (kernel_ulong_t)&dev_vdata[5] },
>> +    { PCI_VDEVICE(AMD, 0x15C7), (kernel_ulong_t)&dev_vdata[6] },
>>       /* Last entry must be zero */
>>       { 0, }
>>   };