Received: by 2002:a05:6830:16d2:b0:61c:ac69:ca1b with SMTP id l18csp152031otr; Tue, 26 Jul 2022 19:53:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tokhNknMdoQCOJsGhMDY3DAQkDetrHWrOdmoX6jnGjZuHLZ5aUwxp7M14oxswE7tBBhc/R X-Received: by 2002:a17:902:d40d:b0:16d:a869:5b14 with SMTP id b13-20020a170902d40d00b0016da8695b14mr3651611ple.164.1658890403652; Tue, 26 Jul 2022 19:53:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658890403; cv=none; d=google.com; s=arc-20160816; b=bXedm/42/JaRSMTb9lgM7U39bjkotIInHQy1nzjJANdPGIHn0NPnjV6wSn3fWsvb1Z hw6XvbbP8HaLO5YW4MERjiMDKMIHAh9PkDKqVyY32nYeYDSgjZAWRQcXiKeLG+9+fPnu foapaIalqOCmw/Q1R1yA2b87nfFIPD0g5wKMDzkOuyDl4+xFFaco56Jb+pEqDKq5IHas 9BaEGppIwmRk3J6RO21DEmSfY/LBL/rPpxbwMT8FvmqlfqV47Jz9nDqipBzt7YIDIZJf oOWGJiLVYUfgf5aCAde6jVftXIj1apRqXa3wVUOyEmlnCbtqEzZhR0jLgTK6Vul3eBnA kcpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=j993AwE7JGiTWAngGGgR54HdaZizYH4yBOh1mA1BQek=; b=DFbx6TIGnATcpdv/w6hWhWMJW6Mzd9bcrKbpLLOeKiGXRZQTyyGSSxxbNQt/M1Izqr /YOILvhNhSkLF3v0qV9RPXaDce07xquJDhv5C6Mw0gNAkAwD25+ldIZ4kwIYjIaev9qV 4V1kU5CJAHZzdDXnjbAW57t88vDa/hYvJoPhpYUK2DtTHoBgo939veQUDajfdv9avMU3 XctTATgNkFzSXpF6s0qU+Tu4dm1yMJ4aU/m+rJgkMUMesx7Pntvivjq1rrKjkOmekZIh TuT4+oB/Aa4lHrAbrnAzttgvq6Y4UFtQ1JMhk5nMDb1sUSGSfZoe2BUftOXK0f4U8Uny UWaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NiMqKvPl; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i23-20020a056a00225700b005253e169119si21014114pfu.94.2022.07.26.19.52.37; Tue, 26 Jul 2022 19:53:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NiMqKvPl; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240067AbiG0Cwf (ORCPT + 99 others); Tue, 26 Jul 2022 22:52:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229717AbiG0Cwe (ORCPT ); Tue, 26 Jul 2022 22:52:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 018963B96B; Tue, 26 Jul 2022 19:52:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9463F61761; Wed, 27 Jul 2022 02:52:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68E95C433D6; Wed, 27 Jul 2022 02:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658890352; bh=mOvAqtymjKTyNB33hg2ZKI/KGchB0ZSy5/mlAYTBUOA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NiMqKvPl/nfHT0J/79eWG9MQcSvoCr/GfTZfPO5Y4E0dmORqA4TuvLHFCNFM9kop+ juo3Nj/x196GIHtKN7+tkp3imeXXdGaS8VP25mdKZaTO3GqR4UNBBknJlvbLEOG5s3 Gj3Os8kZJthXVknYUaY4zKJzOSgZbgnaYyFndF7AzyBi7MbWDRnumqsrD3ikIOxoO8 v6flBlepBQyWY1pfkUbJIoSKi1KbstGCaoBqxjeW3sx8UeTqYbP9r+14C/dQ9/j5oL pSC96vJ0XqHL0kdFcWAT+93nswod7CfsP2OF2Kuvfx6SWUt1Im9g6LuHLuEMH6oTs1 15Gfk+jeTf+7w== Date: Tue, 26 Jul 2022 19:52:30 -0700 From: Jakub Kicinski To: Dmitry Safonov Cc: linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Andy Lutomirski , Ard Biesheuvel , David Ahern , "David S. Miller" , Eric Biggers , Eric Dumazet , Francesco Ruggeri , Herbert Xu , Hideaki YOSHIFUJI , Leonard Crestez , Paolo Abeni , Salam Noureddine , netdev@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH 6/6] net/ipv6: sr: Switch to using crypto_pool Message-ID: <20220726195230.1ba174fb@kernel.org> In-Reply-To: <20220726201600.1715505-7-dima@arista.com> References: <20220726201600.1715505-1-dima@arista.com> <20220726201600.1715505-7-dima@arista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, 26 Jul 2022 21:16:00 +0100 Dmitry Safonov wrote: > The conversion to use crypto_pool has the following upsides: > - now SR uses asynchronous API which may potentially free CPU cycles and > improve performance for of CPU crypto algorithm providers; > - hash descriptors now don't have to be allocated on boot, but only at > the moment SR starts using HMAC and until the last HMAC secret is > deleted; > - potentially reuse ahash_request(s) for different users > - allocate only one per-CPU scratch buffer rather than a new one for > each user > - have a common API for net/ users that need ahash on RX/TX fast path Build problems on allmodconfig: ERROR: modpost: "crypto_pool_reserve_scratch" [net/ipv6/ipv6.ko] undefined!