Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4a8ddb5b-e7bf-5a7d-48dc-72f62771c79e@gmail.com>
Date:   Wed, 27 Jul 2022 11:49:13 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v6 02/26] tcp: authopt: Remove more unused noops
Content-Language: en-US
To:     David Ahern <dsahern@kernel.org>,
        Eric Dumazet <edumazet@google.com>
Cc:     Dmitry Safonov <0x7f454c46@gmail.com>,
        Shuah Khan <shuah@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Kuniyuki Iwashima <kuniyu@amazon.co.jp>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Yuchung Cheng <ycheng@google.com>,
        Francesco Ruggeri <fruggeri@arista.com>,
        Mat Martineau <mathew.j.martineau@linux.intel.com>,
        Christoph Paasch <cpaasch@apple.com>,
        Ivan Delalande <colona@arista.com>,
        Caowangbao <caowangbao@huawei.com>,
        Priyaranjan Jha <priyarjha@google.com>, netdev@vger.kernel.org,
        linux-crypto@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org, Philip Paeps <philip@trouble.is>
References: <cover.1658815925.git.cdleonard@gmail.com>
 <2e9007e2f536ef2b8e3dfdaa1dd44dcc6bfc125f.1658815925.git.cdleonard@gmail.com>
 <40928cfc-150c-8714-bb83-21d325ce93e5@kernel.org>
From:   Leonard Crestez <cdleonard@gmail.com>
In-Reply-To: <40928cfc-150c-8714-bb83-21d325ce93e5@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/27/22 04:17, David Ahern wrote:
> On 7/26/22 12:15 AM, Leonard Crestez wrote:
>> Signed-off-by: Leonard Crestez <cdleonard@gmail.com>
>> ---
>>   include/net/tcp_authopt.h | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/include/net/tcp_authopt.h b/include/net/tcp_authopt.h
>> index adf325c260d5..bc2cff82830d 100644
>> --- a/include/net/tcp_authopt.h
>> +++ b/include/net/tcp_authopt.h
>> @@ -60,14 +60,10 @@ DECLARE_STATIC_KEY_FALSE(tcp_authopt_needed_key);
>>   void tcp_authopt_clear(struct sock *sk);
>>   int tcp_set_authopt(struct sock *sk, sockptr_t optval, unsigned int optlen);
>>   int tcp_get_authopt_val(struct sock *sk, struct tcp_authopt *key);
>>   int tcp_set_authopt_key(struct sock *sk, sockptr_t optval, unsigned int optlen);
>>   #else
>> -static inline int tcp_get_authopt_val(struct sock *sk, struct tcp_authopt *key)
>> -{
>> -	return -ENOPROTOOPT;
>> -}
>>   static inline void tcp_authopt_clear(struct sock *sk)
>>   {
>>   }
>>   #endif
>>   
> added in the previous patch, so this one should be folded into patch 1
Yes this was intended for squashing but missed somehow; sorry!

--
Regards,
Leonard