Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <761e849c-3b9d-418e-eb68-664f09b3c661@huawei.com>
Date:   Thu, 28 Jul 2022 16:24:36 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: Inquiry about the removal of flag O_NONBLOCK on /dev/random
Content-Language: en-US
From:   "Guozihua (Scott)" <guozihua@huawei.com>
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
CC:     Eric Biggers <ebiggers@kernel.org>, <linux-crypto@vger.kernel.org>,
        <luto@kernel.org>, <tytso@mit.edu>,
        zhongguohua <zhongguohua1@huawei.com>
References: <13e1fa9d-4df8-1a99-ca22-d9d655f2d023@huawei.com>
 <YtaPJPkewin5uWdn@zx2c4.com>
 <b9cb514c-30ed-0b8b-5d54-75001e07bd36@huawei.com>
 <YtjREZMzuppTJHeR@sol.localdomain>
 <a93995db-a738-8e4f-68f2-42d7efd3c77d@huawei.com>
 <Ytj3RnGtWqg18bxO@sol.localdomain> <YtksefZvcFiugeC1@zx2c4.com>
 <29c4a3ec-f23f-f17f-da49-7d79ad88e284@huawei.com>
 <Yt/LPr0uJVheDuuW@zx2c4.com>
 <4a794339-7aaa-8951-8d24-9bc8a79fa9f3@huawei.com>
In-Reply-To: <4a794339-7aaa-8951-8d24-9bc8a79fa9f3@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/7/26 19:33, Guozihua (Scott) wrote:
> On 2022/7/26 19:08, Jason A. Donenfeld wrote:
>> Hi,
>>
>> On Tue, Jul 26, 2022 at 03:43:31PM +0800, Guozihua (Scott) wrote:
>>> Thanks for all the comments on this inquiry. Does the community has any
>>> channel to publishes changes like these? And will the man pages get
>>> updated? If so, are there any time frame?
>>
>> I was under the impression you were ultimately okay with the status quo.
>> Have I misunderstood you?
>>
>> Thanks,
>> Jason
>> .
> 
> Hi Jason.
> 
> To clarify, I does not have any issue with this change. I asked here 
> only because I would like some background knowledge on this flag, to 
> ensure I am on the same page as the community regarding this flag and 
> the change. And it seems that I understands it correctly.
> 
> However I do think it's a good idea to update the document soon to avoid 
> any misunderstanding in the future.
> 

Our colleague suggests that we should inform users clearly about the 
change on the flag by returning -EINVAL when /dev/random gets this flag 
during boot process. Otherwise programs might silently block for a long 
time, causing other issues. Do you think this is a good way to prevent 
similar issues on this flag?

-- 
Best
GUO Zihua