Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Date:   Thu, 28 Jul 2022 11:36:37 +0100
From:   Szabolcs Nagy <szabolcs.nagy@arm.com>
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Florian Weimer <fweimer@redhat.com>,
        Eric Biggers <ebiggers@kernel.org>, libc-alpha@sourceware.org,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH v6] arc4random: simplify design for better safety
Message-ID: <YuJmtY6agbe2pBSW@arm.com>
References: <20220726190830.1189339-1-Jason@zx2c4.com>
 <20220726195822.1223048-1-Jason@zx2c4.com>
 <YuJlCijOtAXOco6h@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YuJlCijOtAXOco6h@arm.com>
MIME-Version: 1.0
NoDisclaimer: true
X-Microsoft-Antispam-Message-Info-Original: LAaqm7cojCPmTqhNv6FgPD2hgrWGCxdv3uh8ThvqnUx/+CK7SBgiPt2v5Glv0ZdWBqccuH5B5m/71LZKr19MFtClt5oJK4wqzuZ71wjSyxn7AnQn4Fv+0JwskkDMHpiRQCw+pN8dGq88YuT4pnyw1F4+PXc6NzLYoWLfMV6s509GWxHQ56IQushL0YeDR53mjI4rqWomk1Jyw6TAW1hqcdDGWHjrJ1oYslV4jN6Zq2+TAyIXNXMejayu5gb+VwspJt70l31EQatR3xg0Zvyyx42nS/89YMhldHqxY1/MWLZCHuhppI7cEBjkDVJJfuovH/TiPcoJzpydt6WQlx6Ba9ssiN2pKVAMlIxmuAMMTvgdZiNKRxuM/vD7/X7AWFUmWMAb2dfssaLz3pOg5H9YxmeAFnrE+9pLffEK3qGeKkMACyIxLBCl3DhwHQ+mqmNleu7UlpmPeA69ivXO6rwOYesbsbN2xdZ5J50pGOVUT3QwqZnIDafk5wwNAhy0i4v4cCvTauNKH0NWe0wYWChdsgmhsZbiXsZbjVHvHo1WEsAUWMnMqPoo/6dDjkcmT5bXIDEaHNsUIB9KuOJZMfeSmJhjxEHwG/kgPFzqjPDji3lpHr5GSB5yLLTzZzQd2vmeFUXePQ8XFHX3nrigtL0USbKcTVlitVWj3iqrDpcuncdXkpXYiH78l9mwlqKm9cmgAY5MBuQZr2QgPubZu01Brq4ciu1NFrqQmj6oHmAcvFE+Vl5qyo2UkzbknM4VBKs6MF3h/ekjAMccuuoGsJpUrCY28HnXOwVt3PuZ2/jhRRg=
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(136003)(366004)(396003)(346002)(6486002)(86362001)(316002)(36756003)(26005)(6666004)(6506007)(41300700001)(38100700002)(478600001)(110136005)(6512007)(2616005)(66556008)(186003)(8936002)(5660300002)(66946007)(66476007)(2906002)(8676002)(4744005)(44832011)(32563001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1904
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 29603e65-383f-406f-9505-08da7085150b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: NrGexAhzBVA9zCvmRNVw6fu78MxG0G0o4CebIX6lXmneCZR2/GWPS4NCShrKSB23dPEY0FqvlLIimfeHenge69nLoPV+l6nkuzZ5eBzXx3ePAG59kuC2GpDX8lCNIIe02r18VqtFznLM23gGfY2MbtUisBBXoK0RUedAgcA8BsuKVPRQPMeyqX32vh1GVfH/gTl2umkmBJbGoneDnOcZh51ommUgdL7LjpodR37QP6Wx008I0vMlo5Taa9BLKvhsTx9/33trgXrbh/EPFaCCJMW1i8bZcJs9UPVq9bz6PUfg+IrM7Er0HkWg5qVpOEWJKtgzjfWm9W0oiJMOfhP5z0HYEMN7OUz+xrbmvfVKX3awrNQEB3988KI8gCQC+61YmHGW/kNWQlUCF/wGKmib4PlmS2Z3IOg5R0dbHB1kPyKfgydQ7PtHecfhtt6Ew53oSYUL7PQuOhrOiGrvG9ycnnJjjIeUCvcU2WWm5/wFzFTS+0KZApyZ4mUUXtHCcX9/cNDauYVBrOG8k97Rz1051JHrJV2CXvRk6xxTR1C0MwfWjvqDbt3QdEV7jicLcrgjMUpwiIQ2FZ52GM3T9QvwydmjGZ1FJdhGH0BQa4qbziMzS1Gmallpo03nH71sLo7tgqhHkmLlqNTrknp63hJ8wTO5GQDukWpb2UOHrY8FGbgLfltmJ+EFDgXcycbgpTwDLoEeJpLqDzodztwxaELj5ts72HcwvtIYffDwfbU0iBWnriPkNfGwzBkncsexnzMqOg2qMnK14YEXAeG7XSs9eauxbskhQuCs5K4kUWfb5nC6hzI0LeDZ/lI4pm2iGd3DEerje1j0KcVXYJG05qakUQ==
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(136003)(396003)(376002)(46966006)(36840700001)(40470700004)(36756003)(6512007)(82310400005)(26005)(6666004)(478600001)(6506007)(41300700001)(40480700001)(86362001)(110136005)(316002)(356005)(6486002)(4744005)(36860700001)(81166007)(40460700003)(186003)(47076005)(5660300002)(82740400003)(44832011)(336012)(8936002)(2616005)(70206006)(70586007)(8676002)(2906002)(32563001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 10:37:00.1915
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a02569c4-f0aa-488b-0b16-08da70851a64
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7025
X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_NONE,UNPARSEABLE_RELAY autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

The 07/28/2022 11:29, Szabolcs Nagy via Libc-alpha wrote:
> The 07/26/2022 21:58, Jason A. Donenfeld via Libc-alpha wrote:
...
> 
> fyi, after this patch i see
> 
> FAIL: stdlib/tst-arc4random-thread
> 
> with
> 
> $ cat stdlib/tst-arc4random-thread.out
> info: arc4random: minimum of 1750000 blob results expected
> info: arc4random: 1750777 blob results observed
> info: arc4random_buf: minimum of 1750000 blob results expected
> info: arc4random_buf: 1750000 blob results observed
> info: arc4random_uniform: minimum of 1750000 blob results expected
> Timed out: killed the child process
> Termination time: 2022-07-27T14:41:33.766791947
> Last write to standard output: 2022-07-27T14:41:22.522497854
> 
> on an arm and aarch64 builder.
> 
> running it manually it takes >30s to complete.

note that before the patch it was <5s on the same machine.