Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kshitiz Varshney <kshitiz.varshney@nxp.com>
To:     Horia Geanta <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Iuliana Prodan <iuliana.prodan@nxp.com>,
        Gaurav Jain <gaurav.jain@nxp.com>,
        Rahul Kumar Yadav <rahulkumar.yadav@nxp.com>,
        Vabhav Sharma <vabhav.sharma@nxp.com>,
        Sahil Malhotra <sahil.malhotra@nxp.com>,
        Matt Mackall <mpm@selenic.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Steffen Trumtrar <s.trumtrar@pengutronix.de>,
        PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
        Martin Kaiser <martin@kaiser.cx>
Cc:     linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
        Kshitiz Varshney <kshitiz.varshney@nxp.com>
Subject: [PATCH v1] Moving init_completion before request_irq
Date:   Fri, 29 Jul 2022 12:02:11 +0200
Message-Id: <20220729100211.2204126-1-kshitiz.varshney@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LaXVTetzyKHBazCwIO+fmOYtQVjE3xIwZHe3nCPLKliscJey/2myTjDFmjL8?=
 =?us-ascii?Q?Z73nfvAy0h72aEAPU8NAzM1BlsMvZV0z+eYX5Oln4NQHzeAREH0ba28WvyHX?=
 =?us-ascii?Q?zzYW/hzzpGZJwKzqL28iJxtqS1BwvsTvZ9t0LU6lv3/u6DtQOZ4mUmaL8OY1?=
 =?us-ascii?Q?NJSQ1QwrHZWz+7DBo7qLTGba6/CQLpjD4rM3dsBoeATHjjsOn/oSugAycH5+?=
 =?us-ascii?Q?3zsltLPY+J5pihRYH83CcaRpZeo+fc1aysLJBj0RsFf73QpwMblDb+e2LAFh?=
 =?us-ascii?Q?62ZT5AprAK+WGUaWzYaFp+Kxpyr/nC9r7xfIV0+Ya2rz6iqTfbekb0SNHHDM?=
 =?us-ascii?Q?NZ8fm782MQPR/vymmYsAmj3kZR9db9Cf8cpE14urmtSMeXkrSpWABsj8y/yt?=
 =?us-ascii?Q?ODIa0A2bS5hnKKX2flcWk1A5vJmV7SUYTv6T//g27q4W5wV4QxpmnJUD7DvE?=
 =?us-ascii?Q?oNYPwvYpY4zY2d4pBfdo2BEDX+ot7l7vzR+nhhrLhQvm71g8ydnKDr+N4BDI?=
 =?us-ascii?Q?6wAnYDu30MeDN3za249KTU4TV/4exVzkz/SsSri5UkcWBmfia8TbsdtKb+Ny?=
 =?us-ascii?Q?admjv8CTcZMXIWPvj4ACiH/y5/NTC0EymlCKkHu6L/0TB6F4Gq80Gl1wGolr?=
 =?us-ascii?Q?S+CAOCcMO6UkKY8WabB7pjnsdGBcCLEGVt1OGCQBXyAt2PO7Un2ikY8YLJwf?=
 =?us-ascii?Q?4ZRS0tvUlh3W7aN5m9T8LLEikljzXKe9EwQSztr9wQ8eea22jle1ma0Xwx5d?=
 =?us-ascii?Q?HfAXW7YfilGqR7bK96cualIg+cqyRgm+37y0t9ur4qz2SRsgUbjNlqQKF8Ow?=
 =?us-ascii?Q?5fqX2H+eYKVapCWs1M+CYiE3BTXX404V0vCWO/7NEVN3rFQRntmo2TNJYtD7?=
 =?us-ascii?Q?scJzsSnepPDntsyQnjWDIYAEyuQ/1Wf3OZofe8vEdUH7e59aBfNG0IJtUOk/?=
 =?us-ascii?Q?8PBLKTWU6SrxSLK6W1K4OLdBaNtxXPcwXmR2/hPVbm0i4QhdLhUhI+iZj4CZ?=
 =?us-ascii?Q?wnGyqlQhVkNUSuI1tWSgY4+AGlnqTdfwSD0BufLA5PWW85LYvK4ZuZrqUlrw?=
 =?us-ascii?Q?37h2ukZ27ju5SM6Smj4oNj58vkZtdQ6FYABobA3Krk5zs26q8N+3zu9nfrYz?=
 =?us-ascii?Q?/VKwbbwWp3/lxal4fQ9ab/vvuQkhtsMAw5pDdUbCKhloBn7o2YhiWo3w+Nol?=
 =?us-ascii?Q?wM+XAaU/i9BMhScR6ppJeStQsl4HP/8daOwxIWXsJgw03NeiPTYtsXcGtn7M?=
 =?us-ascii?Q?+gsu8dky01T5QFTucT2xSGJCsd+P/PtNUWrUj2hmmbA/AX2My9H7QxXPRmuv?=
 =?us-ascii?Q?Qan7F2Pyr4x/FeEhhiTY3gELv4BteAI0PocQ8Gtc51tz7p2Vz/Hh4f67m6KY?=
 =?us-ascii?Q?aJ//wZKPjYKNG9No9W3Q17KpEAZJfI3e/bLe9JAsaCO+oRYDSl8anJtu9ler?=
 =?us-ascii?Q?7LKUNfnvKk4kFkf0UUFNdpKL5wBc8g+wKcpdOMrfCIW1UeqHy8ofCKToq7mi?=
 =?us-ascii?Q?VCDFnH5yvThF1PRDUfNwTchy0VZUfCAfDaoqbRNzo/3xA+bJddh8gEost0ds?=
 =?us-ascii?Q?U71t85YcpUHf6Wu7hsUxFevzwsyZad5gN2NXOYniV6bDFVxRUdwxkISR7tA7?=
 =?us-ascii?Q?fg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a02942b-5318-4893-7d7a-08da714982e5
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8296.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 10:02:57.0694
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qXriYw1P5qSGg4poKGUkLVjvTw93daCUTB3PX65uHnSIXd3/cs4StsRz0iNKivrTwnudFHkS9T9L/bls9CnDhq01hazY9zJ8pgdXQ2/vh18=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2775
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Issue:
While servicing interrupt, trying to access variable rng_op_done,
which is not yet initalized hence causing kernel to crash
while booting.

Fix:
Moving initialization of rng_op_done before request_irq.

Fixes: 1d5449445bd0 (hwrng: mx-rngc - add a driver for Freescale RNGC)
Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com>
---
 drivers/char/hw_random/imx-rngc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
index b05d676ca814..53e571c4f283 100644
--- a/drivers/char/hw_random/imx-rngc.c
+++ b/drivers/char/hw_random/imx-rngc.c
@@ -270,6 +270,8 @@ static int imx_rngc_probe(struct platform_device *pdev)
 		goto err;
 	}
 
+	init_completion(&rngc->rng_op_done);
+
 	ret = devm_request_irq(&pdev->dev,
 			irq, imx_rngc_irq, 0, pdev->name, (void *)rngc);
 	if (ret) {
@@ -277,7 +279,6 @@ static int imx_rngc_probe(struct platform_device *pdev)
 		goto err;
 	}
 
-	init_completion(&rngc->rng_op_done);
 
 	rngc->rng.name = pdev->name;
 	rngc->rng.init = imx_rngc_init;
-- 
2.25.1