Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bb9d1a37-5406-72b7-00f9-4144028f0081@amd.com>
Date:   Wed, 10 Aug 2022 08:24:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2] crypto: ccp: Add a quirk to firmware update
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>
Cc:     Jarkko Sakkinen <jarkko@profian.com>,
        Harald Hoyer <harald@profian.com>,
        John Allen <john.allen@amd.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        "open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - SE..." 
        <linux-crypto@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20220809224915.92111-1-jarkko@kernel.org>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20220809224915.92111-1-jarkko@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QURtNFJJWlVXcFpIcWwvSWdvVjJRN1VKczR2d2wxMlFRanc1NFNqbFlOelJR?=
 =?utf-8?B?Q3IwVkprVUhIOVpVV091azJZbGJCbURBd01kODlFMUQxS1J1UnBBZjF1dy9m?=
 =?utf-8?B?Y2RWZ0luOUZaZWdBZksrcGtKYzZMcUxzcCtycEdwVisvMGkrR2p4M2dqR2xi?=
 =?utf-8?B?ckxsU1hWbk9BRmhtUzF5VWx1MkN3Z2hxQ3daVlZVYUE0THhPaUNUN1dadmVt?=
 =?utf-8?B?bFpoQWYvV051bklQek1Bd2R3TmMvZHNPOU9ta2NEbkl0bG9INTNaM2FFaEtC?=
 =?utf-8?B?cmlLTjMvZ0xQaEY2bUJ3dERBZCtDOFpSK3pCanhOSFdkQ3pIdnlHeTRvVWNJ?=
 =?utf-8?B?SENGZVBDU083WHNubGFBd25tRGRKc3BuSlVYL2tzeXhwUjQ0c1dvV2JTVFZK?=
 =?utf-8?B?OS9SdEthemxRS3ljcGhoYk9nU2pvZXpZTFdFSXcwdDF4WlJFS3orY2FjYzFx?=
 =?utf-8?B?cG9aN01EVXNEZmpObEM4VGpVNHBucjNhcWJ1UXNvWGYwek13OXJ2UFJCbGtW?=
 =?utf-8?B?NUNranR2U0haVWFDWnFJU29ZSTc3U0tLTmVONzF3dCtOVlR5SUt5V2ZBWmhL?=
 =?utf-8?B?aEluSkErT2pHS0kwWGhLaFhUejh6Zm9ITFV6VWlWM0g1ZHVlWmcvQ0NyWU4z?=
 =?utf-8?B?REhyZGNXejNiZnlyOENheHpJQ1NpM1plRURLMWYxMVhxTVMxbGNCaHVjaXRN?=
 =?utf-8?B?aUtRMCtEZWc3NTZVMEZaSGxuck1vaDFYdCtDcEVZV3NURlF3YzRkV2MvczJ3?=
 =?utf-8?B?U1VsY0FrMFpVQWVYVVNiR05lNGdNUUE5L0tVRlIxSk01QW14bldJdzdiVzVV?=
 =?utf-8?B?MERrK2dORTJOWWFkZGpOc1VjaDJycGV3ZTQ0VjdSQ1NVd3AxS2Vhb3pvMVhq?=
 =?utf-8?B?Tmczc3p4TU1meHRKK3MwVUpKblEvd2U0bEZSejE1MWNWWnoyaTNIVXFZaUhP?=
 =?utf-8?B?bHp4akdkSUVEYVNBUlVUVVVuUnB0eWIwSEpSZW1VTkhIWk5GSGdPWWM5QlI2?=
 =?utf-8?B?cndEQ2VrOXIwTkJvUXJ1Sm1mdHo0NTlvYmFvR0dzVnd3bCtnUmFDZi9PN2R6?=
 =?utf-8?B?YmhJSytCSVliZEtEK2xIekZVR2x1eXRUdGRLcVNpcGphRGpVUEE5alJkYWV4?=
 =?utf-8?B?VlBOZGxvZTZyRjBoRGZpTFEwLzRtNkF1TnJ5d1c2ZXFtUG9xNDI0S2plQUpN?=
 =?utf-8?B?Yis3ajc5RFc1Wm1MNVNzeHFBU3JCcUFJY1Q0YXpnYzg0bGtyT0pWNTFRcDdi?=
 =?utf-8?B?Q3BndGdHaWVPWHhjdm5LbUJDWU9RTi9QbDhXd2NvRXhra28rRHh0VHdPUGpQ?=
 =?utf-8?B?OFN0b1VtNC9MNjdWd3MwazJvVU1ldnlYYW9XTzlCVm5HOENlRlZpaVBCL1Fx?=
 =?utf-8?B?WjhwMHEzazJxWnVKaUY3eHVSZ0F4TGNmcXhPOXJnSXJlK1Q2RkdtUkJ6Mjhp?=
 =?utf-8?B?UVhkaEl6UTA0V0xyS3pMdC9yanRjR00rQ1lqL3hQRU9WUG1zYnFwdWFJSXNV?=
 =?utf-8?B?NXdzTC9mTUZYcU9wenBPejJydVMwUk1LT3B2Vm8yZnkwQzloQzdaRkdHS0dq?=
 =?utf-8?B?VDcrU0swSGx6ZDBKd3B3bjNZRXBCOVlNdFBGeDllVitZWEt2WWtnNnVIb3dV?=
 =?utf-8?B?Y2Q1aGcydGdGVkducWJjMERnbkJUbDFHdjZVTWtUVTUrajdVVmt4endERVdM?=
 =?utf-8?B?OHd1TDRaMUNrOENRZnJ2L2pwMk1aYmlUQzljTmpieTJUSkhVSGJGZDhoeFYy?=
 =?utf-8?B?TVQwVFFGcStiWmNPWHNqTHdMMXZ6a2UyQ2lUTC9WMWp5UFRRa0dQa3RWQXkx?=
 =?utf-8?B?ZjlxY1NTNTBtUmQ5aVpEM1MvZDNvSEdSSnEzazBHNmZnekZ3OUxWaUpTYmtC?=
 =?utf-8?B?YXJ6aXkxM1BESXBwbWtKNDFJZ1R4RVF2cWtZWEFzdlVuS3J6eklGR1lQeEFY?=
 =?utf-8?B?MU4yQkZhUEZmRnFKWGJ1cnhRMExXZEJxR3hxN2dhM3F2RllnV09HTHhzemZU?=
 =?utf-8?B?Z0VnU3M3YWlkdW5wVittYjdieWlKTzZBdXVyNU9xQmZCVkFFNGVxOUwvdG5s?=
 =?utf-8?B?L2VjMnpOMGNucHdSYzcvSElWSGJnK1lYM1ZueDQ5M1JwRlorWUkzSVVYbGM5?=
 =?utf-8?Q?d47K5UNYy9vS/epovpaJlo9zv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a75f4f5-3dc4-47f4-961b-08da7ad3adcb
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5221.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2022 13:24:40.0397
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qErgteN36FSfchrKxVySiS7eegKUUabIMa27ESEc5faf4D4/z1JeBBF385VBX/gDbvQSJPFiVhenjQL4DBRDvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4835
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 8/9/22 17:49, Jarkko Sakkinen wrote:
> From: Jarkko Sakkinen <jarkko@profian.com>
> 
> A quirk for fixing the committed TCB version, when upgrading from a
> firmware version earlier than 1.50. This is a known issue, and the
> documented workaround is to load the firmware twice.
> 
> Currently, this issue requires the  following workaround:
> 
> sudo modprobe -r kvm_amd
> sudo modprobe -r ccp
> sudo modprobe ccp
> sudo modprobe kvm_amd
> 
> Implement this workaround inside kernel by checking whether the API
> version is less than 1.50, and if so, download the firmware twice.
> This addresses the TCB version issue.
> 
> Link: https://lore.kernel.org/all/de02389f-249d-f565-1136-4af3655fab2a@profian.com/
> Reported-by: Harald Hoyer <harald@profian.com>
> Signed-off-by: Jarkko Sakkinen <jarkko@profian.com>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>