Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     Eric Biggers <ebiggers@kernel.org>
CC:     "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 10/10] crypto: Kconfig - add submenus
Thread-Topic: [PATCH v2 10/10] crypto: Kconfig - add submenus
Thread-Index: AQHYspAfNEVq9XUVOkGjN60mBqhWxK20FRUAgAADL7A=
Date:   Thu, 18 Aug 2022 05:44:09 +0000
Message-ID: <MW5PR84MB1842481DD734E43C27C5C049AB6D9@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20220815190608.47182-9-elliott@hpe.com>
 <20220817232057.73643-1-elliott@hpe.com>
 <20220817232057.73643-11-elliott@hpe.com> <Yv3DhH7WkhNPnqMu@sol.localdomain>
In-Reply-To: <Yv3DhH7WkhNPnqMu@sol.localdomain>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7fKRCyOFsCwSvCdQsqqQ6EfpsAyagMoaNRfGA58PF1PQS83QsNn0oSmtrQ3i?=
 =?us-ascii?Q?1aJ2CZ0uWzIypuzJdz4n97WvQ10lkEiUssjuV9sjLtntaSsj2oTG99QfVZWw?=
 =?us-ascii?Q?BgjlSKOBc4aSF+SVUeHLHc5vzN9K1GgVhqt5qT0xUJbWH2TAG20nk/KFk9fK?=
 =?us-ascii?Q?Dmo2ZOTe8K8JR4d0XK9D/5d57gOzoh2GdePkLxhl0GqNkyAXYtDIK3HBdQ+F?=
 =?us-ascii?Q?5RSzLJbSxqmId3FZs2X5YXfCg438JnIu6pBYSez1bU4wJE/nztBKH7u7rj1K?=
 =?us-ascii?Q?XZ1tlNwV65TlgK+OZAY4z8ldUB3qwWF/iz7Lt4zCZ4aRE0Cd9+U/4wkoBgS+?=
 =?us-ascii?Q?GcxOzyRybVLYkgmP3AS0uMeEPM6/5kBLuskMgJItTfxVU1ylFDUdZs3N5WSq?=
 =?us-ascii?Q?IK1R0yiP9pmPi0SFRPp6PpHlRfzgKZ40SumhE+cw1Zy3fEclJXowCzn4Gl4g?=
 =?us-ascii?Q?qSlrbHqTptW0KNTD+N28qcc0xGS9wVSI5OugNaBqqnO4i6L4c3ViDcEkQrF/?=
 =?us-ascii?Q?HT97zyZkb3ndjfLOTIpA7tpHb9oyIZsRyzd2Bbox6hO6uorrmD5aRbPoHI77?=
 =?us-ascii?Q?5clfVKrfuFI1S2hBBCs0EtH4X3iJxYUbH9BeS7N6Em3nzuCV40pznNj5mpbP?=
 =?us-ascii?Q?HRIDYZ+ST/nKGW72avGGckvHmRHpePZJW23v0XMwMCTPOtlvyGp3UOTDbSsi?=
 =?us-ascii?Q?YTRLPWVkM1VqOHNSWLZ5duDzxFO11SResH0U4asZiemoOh7hp7sADcLBfOBP?=
 =?us-ascii?Q?Og4ePFC/UuUnpbAAtghsSeOC0t3l/OANXaqt9XD5njqVd/RJjxQzXPArRKch?=
 =?us-ascii?Q?MOkKriO5wb0Pak6yQq6UOj1j+HcnD8YG95VlPWzOc7JHZnOr/KQklxCNW02z?=
 =?us-ascii?Q?Zlv1djpb5qvedhyeuc87gzh/VwtaWhK1nLE5OUyIm648x2bMGDHUimOORBfl?=
 =?us-ascii?Q?OIoWyg7BzoHs2MlS31g2nGvnMwa441B1OdhYFZvG0UgskqvmcskQ5u4OYcRk?=
 =?us-ascii?Q?dhwKtwos62iyTSg7h7P3d/JU+ar7W+znuOVhfAyYf4Wmhh9IuHoncDDEHmvP?=
 =?us-ascii?Q?68agBDTCS/XHamZfdTF7JH6JeGnWzjt+FYdEHIvUop7oDL9T/T7sDCgGL1AH?=
 =?us-ascii?Q?Ogfogdn3TbOrE5Q0QFQ8j1gK+c7FC2zBjL6Aqwh+ioMe6hkIFGHSoKfeoavc?=
 =?us-ascii?Q?p0a/mCycnXowHAyxqnTn0c4bnjnSdabiFcJX2m3G+01/1CnZ1p9oEaTxmBn2?=
 =?us-ascii?Q?Zn5vZHQOQ2NrlzJSMy3JF0DHT9g68UlNo2R9EVvVb55/XlN9eIvbU87VIv+t?=
 =?us-ascii?Q?0W7HHY7joEgL7EH8JNpmj9oEfOENNfgwpBHI7R47RoORqkcHYI+Uw6gVhfmP?=
 =?us-ascii?Q?wXtB58MRXCAESABGuxkO4nVIJMGH+5y6ty8NzBGUU7p9UBnmIKk3Dqx0A8yt?=
 =?us-ascii?Q?jx5lNSWEcmsl5AoNaHdr0owIS8/ViJK1Xa0qt8tPoDKPMFOOEK3/yw7JbO1L?=
 =?us-ascii?Q?ydMvTKZ+UWwg7GShNWPq4y2YArNif06yyF77MVklEd2Bg73biU4JtyCaOxE/?=
 =?us-ascii?Q?vIcuKVvzVWugHB0tVcw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d59580c-468f-47db-270c-08da80dcac28
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2022 05:44:09.5663
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xbALselyyMUJsD0XqKrL9C1OiLq6oF+ad+2aomsQ7Kw07IFmwVW/t0UKxXmg0ZZH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR84MB3167
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: XtIiRNUkoYTuLFF_HquJrOgbiEP8N8LH
X-Proofpoint-ORIG-GUID: XtIiRNUkoYTuLFF_HquJrOgbiEP8N8LH
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-18_02,2022-08-16_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 mlxlogscore=591 adultscore=0 clxscore=1015 phishscore=0
 impostorscore=0 bulkscore=0 spamscore=0 mlxscore=0 suspectscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208180017
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


> -----Original Message-----
> From: Eric Biggers <ebiggers@kernel.org>
> Sent: Wednesday, August 17, 2022 11:44 PM
> To: Elliott, Robert (Servers) <elliott@hpe.com>
> Cc: herbert@gondor.apana.org.au; davem@davemloft.net; linux-
> crypto@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 10/10] crypto: Kconfig - add submenus
>=20
> On Wed, Aug 17, 2022 at 06:20:57PM -0500, Robert Elliott wrote:
> > Convert each comment section into a submenu:
> > Cryptographic API
> >     Crypto core or helper
> >     Public-key cryptography
> >     AEAD (Authenticated Encryption with Associated Data) ciphers
> >     Block modes
> >     Hash modes
> >     Digests
> >     Ciphers
> >     Compression
> >     Random Number Generation
> >     User-space interface
>=20
> Thanks for doing this!
>=20
> Some of these proposed categories are confusing.  By "hash mode" you
> mean a mode that operates as a hash, not that uses a hash, right? =20
> (CMAC is included.) =20
> So what is "block mode", then?  And what's the difference between that an=
d
> "ciphers"?  What about modes that use both a hash and a block cipher,
> like Adiantum and HCTR2?  And there is a category for "Ciphers", but then=
 a
> category at the same level for "AEAD ciphers"?
>
> Some of the naming used in the code is poor, which is unfortunate and
> is not your fault, e.g. crypto_cipher really should be crypto_blockcipher=
.
> But this doesn't need to be carried through in these new menus.

Yeah, those are just the way the existing comment sections were
structured. I'm all for improving the structure.

>=20
> Just brainstorming, how about the following:
>=20
> 	* Block ciphers
> 		=3D> i.e. crypto_cipher algorithms

This could be characterized as algorithms that are length preserving, but=20
only processes one block.

> 	* AEAD (Authenticated Encryption with Associated Data) ciphers
> 		=3D> i.e. crypto_aead algorithms (and templates)

That could be viewed as any algorithm or template that has=20
    output size > input size

> 	* Length-preserving symmetric ciphers
> 		=3D> i.e. crypto_skcipher algorithms (and templates)

That could be viewed as any algorithm or template that processes more
than one block and has:
    output size =3D input size

> 	* Digests and MACs
> 		=3D> i.e. crypto_shash and crypto_ahash algorithms (and templates)

That could be viewed as any algorithm or template with
	output size < input size

There are a lot of digests now (20). We could move the 4 CRC algorithms
into their own category since they're not really cryptographic, which
would make space for the MACs.


> Those 4 categories would replace your 5 categories "AEAD ciphers",
> "Block modes", "Hash modes", "Digests", and "Ciphers".
>=20
> CRYPTO_AUTHENC would go in the AEAD ciphers category, while
> CRYPTO_ESSIV would go in length-preserving symmetric ciphers. =20
> (CRYPTO_ESSIV registers a crypto_aead too, for a weird reason, but that
> is an obscure case not worth worrying about.) CRYPTO_CHACHA would go
> in length-preserving symmetric ciphers since it's a stream cipher.


These are the module and driver names in each current section:

Crypto core or helper
          Module: fips
          Module(s): crypto_null
          Module(s): pcrypt
          Driver(s): pcrypt(...)
          Module(s): cryptd
          Driver(s): cryptd(...)
          Module(s): authenc
          Driver(s): authenc(...)
          Module(s): tcrypt

Public-key cryptography
          Module(s): rsa_generic
          Driver(s): rsa-generic
          Module(s): dh_generic
          Driver(s): dh-generic
          Module(s): ecdh_generic
          Driver(s): ecdh-nist-p192-generic, ecdh-nist-p256-generic, ecdh-n=
ist-p384-generic
          Module(s): ecdsa_generic
          Driver(s): ecdsa-nist-p384-generic, ecdsa-nist-p256-generic, ecds=
a-nist-p192-generic
          Module(s): ecrdsa_generic
          Driver(s): ecrdsa-generic
          Module(s): sm2_generic
          Driver(s): sm2-generic
          Module(s): curve25519-generic
          Driver(s): curve25519-generic

AEAD (Authenticated Encryption with Associated Data) ciphers
          Module(s): ccm
          Driver(s): ccm_base(...), rfc4309(...)
          Module(s): gcm
          Driver(s): gcm_base(...), rfc4106(...), rfc4543(...)
          Module(s): chacha20poly1305
          Driver(s): rfc7539(...), rfc7539esp(...)
          Module(s): aegis128
          Driver(s): aegis128-generic
          Module(s): aegis128
          Driver(s): aegis128-simd
          Module(s): seqiv
          Driver(s): seqiv(...)
          Module(s): echainiv
          Driver(s): echainiv(...)
          Module(s): essiv
          Driver(s): essiv(...)

Block modes
          Module(s): cbc
          Driver(s): cbc(...)
          Module(s): cfb
          Driver(s): cfb(...)
          Module(s): ctr
          Driver(s): ctr(...), rfc3686(...)
          Module(s): cts
          Driver(s): cts(...)
          Module(s): ecb
          Driver(s): ecb(...)
          Module(s): lrw
          Driver(s): lrw(...)
          Module(s): ofb
          Driver(s): ofb(...)
          Module(s): pcbc
          Driver(s): pcbc(...)
          Module(s): xts
          Driver(s): xts(...)
          Module(s): keywrap
          Driver(s): kw(...)
          Module(s): nhpoly1305
          Driver(s): nhpoly1305-generic
          Module(s): adiantum
          Driver(s): adiantum(...)

Hash modes
          Module(s): cmac
          Driver(s): cmac(...)
          Module(s): hmac
          Driver(s): hmac(...)
          Module(s): xcbc
          Driver(s): xcbc(...)
          Module(s): vmac
          Driver(s): vmac64(...)

Digests
          Module(s): crc32c_generic
          Driver(s): crc32c-generic
          Module(s): crc32_generic
          Driver(s): crc32-generic
          Module(s): crct10dif_generic
          Driver(s): crct10dif-generic
          Module(s): crc64_rocksoft_generic
          Driver(s): crc64-rocksoft-generic

          Module(s): blake2b
          Driver(s): blake2b-160-generic, blake2b-256-generic, blake2b-384-=
generic, blake2b-512-generic
          Module(s): blake2s_generic
          Driver(s): blake2s-128-generic, blake2s-160-generic, blake2s-224-=
generic, blake2s-256-generic
          Module(s): ghash-generic
          Driver(s): ghash-generic
          Module(s): poly1305_generic
          Driver(s): poly1305-generic
          Module(s): md4
          Driver(s): md4-generic
          Module(s): md5
          Driver(s): md5-generic
          Module(s): michael_mic
          Driver(s): michael_mic-generic
          Module(s): rmd160
          Driver(s): rmd160-generic
          Module(s): sha1_generic
          Driver(s): sha1-generic
          Module(s): sha256_generic
          Driver(s): sha224-generic, sha256-generic
          Module(s): sha512_generic
          Driver(s): sha384-generic, sha512-generic
          Module(s): sha3_generic
          Driver(s): sha3-224-generic, sha3-256-generic, sha3-384-generic, =
sha3-512-generic
          Module(s): sm3_generic
          Driver(s): sm3-generic
          Module(s): streebog_generic
          Driver(s): streebog256-generic, streebog512-generic
          Module(s): wp512
          Driver(s): wp256-generic, wp384-generic, wp512-generic
          Module(s): xxhash_generic
          Driver(s): xxhash64-generic

Ciphers
          Module(s): aes_generic
          Driver(s): aes-generic
          Module(s): aes_ti
          Driver(s): aes-fixed-time
          Module(s): anubis
          Driver(s): anubis-generic
          Module(s): arc4
          Driver(s): ecb(arc4)-generic
          Module(s): blowfish_generic
          Driver(s): blowfish-generic
          Module(s): blowfish_common
          Module(s): camellia_generic
          Driver(s): camellia-generic
          Module(s): cast_common
          Module(s): cast5_generic
          Driver(s): cast5-generic
          Module(s): cast6_generic
          Driver(s): cast6-generic
          Module(s): des_generic
          Driver(s): des-generic, des3_ede-generic
          Module(s): fcrypt
          Driver(s): fcrypt-generic
          Module(s): khazad
          Driver(s): khazad-generic
          Module(s): chacha_generic
          Driver(s): chacha20-generic, xchacha20-generic, xchacha12-generic
          Module(s): seed
          Driver(s): seed-generic
          Module(s): serpent_generic
          Driver(s): serpent-generic
          Module(s): sm4_generic
          Driver(s): sm4-generic
          Module(s): tea
          Driver(s): tea-generic, xtea-generic, xeta-generic
          Module(s): twofish_generic
          Driver(s): twofish-generic
          Module(s): twofish_common

Compression
          Module(s): deflate
          Driver(s): deflate-generic, deflate-scomp, zlib-deflate-scomp
          Module(s): lzo, lzo-rle
          Driver(s): lzo-generic, lzo-scomp, lzo-rle-generic, lzo-rle-scomp
          Module(s): 842
          Driver(s): 842-generic, 842-scomp
          Module(s): lz4
          Driver(s): lz4-generic, lz4-scomp
          Module(s): lz4hc
          Driver(s): lz4hc-generic, lz4hc-scomp
          Module(s): zstd
          Driver(s): zstd-generic, zstd-scomp

Random Number Generation
          Module(s): ansi_cprng
          Driver(s): ansi_cprng, fips_ansi_cprng
#         Driver(s): drbg_[pr|nopr]_hmac_sha[1,256,384,512]
          Driver(s): drbg_[pr|nopr]_sha[1,256,384,512]
          Driver(s): drbg_[pr|nopr][_ctr_aes[128,192,256]
          Module(s): jitterentropy_rng
          Driver(s): jitterentropy_rng

User-space interface
          Module(s): algif_hash
          Module(s): algif_skcipher
          Module(s): algif_rng
          Module(s): algif_aead