Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 Aug 2022 18:58:54 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Srinivas Kerekare <srinivas.kerekare@intel.com>
Cc:     linux-crypto@vger.kernel.org, qat-linux@intel.com,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
        Wojciech Ziemba <wojciech.ziemba@intel.com>
Subject: Re: [PATCH RESEND] crypto: qat - add check to validate firmware
 images
Message-ID: <Yv9s7gdv+TEPpVFV@gondor.apana.org.au>
References: <20220725104009.76267-1-srinivas.kerekare@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220725104009.76267-1-srinivas.kerekare@intel.com>
Precedence: bulk

On Mon, Jul 25, 2022 at 11:40:09AM +0100, Srinivas Kerekare wrote:
> The function qat_uclo_check_image() validates the MMP and AE firmware
> images. If the QAT device supports firmware authentication (indicated
> by the handle to firmware loader), the input signed binary MMP and AE
> images are validated by parsing the following information:
> - Header length
> - Full size of the binary
> - Type of binary image (MMP or AE Firmware)
> 
> Firmware binaries use RSA3K for signing and verification.
> The header length for the RSA3k is 0x384 bytes.
> 
> All the size field values in the binary are quantified
> as DWORDS (1 DWORD = 4bytes).
> 
> On an invalid value the function prints an error message and returns
> with an error code "EINVAL".
> 
> Signed-off-by: Srinivas Kerekare <srinivas.kerekare@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> Reviewed-by: Wojciech Ziemba <wojciech.ziemba@intel.com>
> ---
>  drivers/crypto/qat/qat_common/icp_qat_uclo.h |  3 +-
>  drivers/crypto/qat/qat_common/qat_uclo.c     | 56 +++++++++++++++++++-
>  2 files changed, 57 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt