Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 Aug 2022 19:00:59 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     James Cowgill <james.cowgill@blaize.com>
Cc:     Olivia Mackall <olivia@selenic.com>,
        Andre Przywara <andre.przywara@arm.com>,
        Ard Biesheuvel <ardb@kernel.org>,
        Mark Brown <broonie@kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwrng: arm-smccc-trng - fix NO_ENTROPY handling
Message-ID: <Yv9ta23samZEBgm1@gondor.apana.org.au>
References: <20220801200338.261264-1-james.cowgill@blaize.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220801200338.261264-1-james.cowgill@blaize.com>
Precedence: bulk

On Mon, Aug 01, 2022 at 08:04:18PM +0000, James Cowgill wrote:
> The SMCCC_RET_TRNG_NO_ENTROPY switch arm is never used because the
> NO_ENTROPY return value is negative and negative values are handled
> above the switch by immediately returning.
> 
> Fix by handling errors using a default arm in the switch.
> 
> Fixes: 0888d04b47a1 ("hwrng: Add Arm SMCCC TRNG based driver")
> Signed-off-by: James Cowgill <james.cowgill@blaize.com>
> ---
>  drivers/char/hw_random/arm_smccc_trng.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt